[jira] [Commented] (DISPATCH-921) Install console dependencies with npm during make install

2018-05-29 Thread Robbie Gemmell (JIRA) 


[ 
https://issues.apache.org/jira/browse/DISPATCH-921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493866#comment-16493866
 ] 

Robbie Gemmell commented on DISPATCH-921:
-

A couple of thoughts:

A) This JIRA is part of the 1.1.0 RC that already has sufficient votes and 
time-open to pass. The JIRA shouldnt be getting more changes made on it if that 
release goes out, use another (e.g create a new one as Ernie has).
B) All the chat on how to install the console during the dispatch install 
perhaps overlooks another area to think on: should the console still be part of 
the Dispatch install, or would it suit its own release?

> Install console dependencies with npm during make install
> -
>
> Key: DISPATCH-921
> URL: https://issues.apache.org/jira/browse/DISPATCH-921
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Console
>Affects Versions: 1.0.0
>Reporter: Ernest Allen
>Assignee: Ernest Allen
>Priority: Major
> Fix For: 1.1.0
>
> Attachments: 
> 0001-NEED-JIRA-install-NPM-files-automatically-as-part-of.patch
>
>
> During a make install, the stand-alone console's dependencies should be 
> installed using the command 'npm install' executed from the console's install 
> directory.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-921) Install console dependencies with npm during make install

2018-05-29 Thread Ernest Allen (JIRA) 


[ 
https://issues.apache.org/jira/browse/DISPATCH-921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493823#comment-16493823
 ] 

Ernest Allen commented on DISPATCH-921:
---

This could be a good solution until DISPATCH-1017 is implemented. That Jira 
would install the 3rd party libraries at router build time, but it would also 
run other utilities on the source files to compile/aggregate/minify/lint. Only 
a few larger files would be copied to the console's install dir and not all of 
the files under node_modules.

> Install console dependencies with npm during make install
> -
>
> Key: DISPATCH-921
> URL: https://issues.apache.org/jira/browse/DISPATCH-921
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Console
>Affects Versions: 1.0.0
>Reporter: Ernest Allen
>Assignee: Ernest Allen
>Priority: Major
> Fix For: 1.1.0
>
> Attachments: 
> 0001-NEED-JIRA-install-NPM-files-automatically-as-part-of.patch
>
>
> During a make install, the stand-alone console's dependencies should be 
> installed using the command 'npm install' executed from the console's install 
> directory.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-921) Install console dependencies with npm during make install

2018-03-02 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/DISPATCH-921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383699#comment-16383699
 ] 

ASF subversion and git services commented on DISPATCH-921:
--

Commit 0acbc8335f73be6b25a5578e69297f1a67699699 in qpid-dispatch's branch 
refs/heads/master from [~eallen]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=0acbc83 ]

DISPATCH-921 Revert the automatically npm install during a make build and 
update the console README to explain how to do it manually


> Install console dependencies with npm during make install
> -
>
> Key: DISPATCH-921
> URL: https://issues.apache.org/jira/browse/DISPATCH-921
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Console
>Affects Versions: 1.0.0
>Reporter: Ernest Allen
>Assignee: Ernest Allen
>Priority: Major
> Fix For: 1.1.0
>
>
> During a make install, the stand-alone console's dependencies should be 
> installed using the command 'npm install' executed from the console's install 
> directory.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-921) Install console dependencies with npm during make install

2018-01-30 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/DISPATCH-921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16345104#comment-16345104
 ] 

ASF GitHub Bot commented on DISPATCH-921:
-

Github user asfgit closed the pull request at:

https://github.com/apache/qpid-dispatch/pull/249


> Install console dependencies with npm during make install
> -
>
> Key: DISPATCH-921
> URL: https://issues.apache.org/jira/browse/DISPATCH-921
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Console
>Affects Versions: 1.0.0
>Reporter: Ernest Allen
>Assignee: Ernest Allen
>Priority: Major
>
> During a make install, the stand-alone console's dependencies should be 
> installed using the command 'npm install' executed from the console's install 
> directory.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-921) Install console dependencies with npm during make install

2018-01-30 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/DISPATCH-921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16345103#comment-16345103
 ] 

ASF subversion and git services commented on DISPATCH-921:
--

Commit 0c1d568c8ecf96b5e718bf9492d0c79baf65f215 in qpid-dispatch's branch 
refs/heads/master from [~eallen]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=0c1d568 ]

DISPATCH-921 Run npm install after stand-alone console install. This closes #249


> Install console dependencies with npm during make install
> -
>
> Key: DISPATCH-921
> URL: https://issues.apache.org/jira/browse/DISPATCH-921
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Console
>Affects Versions: 1.0.0
>Reporter: Ernest Allen
>Assignee: Ernest Allen
>Priority: Major
>
> During a make install, the stand-alone console's dependencies should be 
> installed using the command 'npm install' executed from the console's install 
> directory.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-921) Install console dependencies with npm during make install

2018-01-29 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/DISPATCH-921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343938#comment-16343938
 ] 

ASF GitHub Bot commented on DISPATCH-921:
-

Github user kgiusti commented on the issue:

https://github.com/apache/qpid-dispatch/pull/249
  
Other than the version issue this patch appears to work for me!


> Install console dependencies with npm during make install
> -
>
> Key: DISPATCH-921
> URL: https://issues.apache.org/jira/browse/DISPATCH-921
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Console
>Affects Versions: 1.0.0
>Reporter: Ernest Allen
>Assignee: Ernest Allen
>Priority: Major
>
> During a make install, the stand-alone console's dependencies should be 
> installed using the command 'npm install' executed from the console's install 
> directory.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-921) Install console dependencies with npm during make install

2018-01-29 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/DISPATCH-921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343909#comment-16343909
 ] 

ASF GitHub Bot commented on DISPATCH-921:
-

Github user kgiusti commented on a diff in the pull request:

https://github.com/apache/qpid-dispatch/pull/249#discussion_r164544618
  
--- Diff: console/CMakeLists.txt ---
@@ -25,33 +25,46 @@ set(CONSOLE_BASE_SOURCE_DIR 
"${CMAKE_SOURCE_DIR}/console/stand-alone/")
 option(CONSOLE_INSTALL "Install stand-alone console" ON)
 if(CONSOLE_INSTALL)
 
-   # Static console files
-   install(
- DIRECTORY ${CONSOLE_BASE_SOURCE_DIR}
+  # Static console files
+  install(
+DIRECTORY ${CONSOLE_BASE_SOURCE_DIR}
   DESTINATION ${CONSOLE_STAND_ALONE_INSTALL_DIR}
 )
 
+  # run npm install for console if npm is installed
+  find_program(PROG_NPM npm)
+  if (PROG_NPM STREQUAL "PROG_NPM-NOTFOUND")
+message(WARNING "Program npm not found. You must manually install 
console dependencies.")
--- End diff --

Hey - turns out the WARNING keyword is not supported with the minimum Cmake 
version we require.
But I think this is the Right Way to do it, and since Proton's minimum 
Cmake is set to 2.8.12 we should update our cmake_minimum_version to the same.

Can you update this patch and change the cmake_minimum_version in the 
topmost CMakeLists.txt fileto 2.8.12?


> Install console dependencies with npm during make install
> -
>
> Key: DISPATCH-921
> URL: https://issues.apache.org/jira/browse/DISPATCH-921
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Console
>Affects Versions: 1.0.0
>Reporter: Ernest Allen
>Assignee: Ernest Allen
>Priority: Major
>
> During a make install, the stand-alone console's dependencies should be 
> installed using the command 'npm install' executed from the console's install 
> directory.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-921) Install console dependencies with npm during make install

2018-01-29 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/DISPATCH-921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343627#comment-16343627
 ] 

ASF GitHub Bot commented on DISPATCH-921:
-

GitHub user ErnieAllen opened a pull request:

https://github.com/apache/qpid-dispatch/pull/249

DISPATCH-921 Run npm install after stand-alone console install

Checks to make sure npm is installed and runs npm install after console 
file have been copied.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ErnieAllen/qpid-dispatch ernie-DISPATCH-921

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/249.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #249


commit 9a0626878ea3f35e3a082f9591616e8b31380e13
Author: Ernest Allen 
Date:   2018-01-29T16:53:49Z

DISPATCH-921 Run npm install after stand-alone console install




> Install console dependencies with npm during make install
> -
>
> Key: DISPATCH-921
> URL: https://issues.apache.org/jira/browse/DISPATCH-921
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Console
>Affects Versions: 1.0.0
>Reporter: Ernest Allen
>Assignee: Ernest Allen
>Priority: Major
>
> During a make install, the stand-alone console's dependencies should be 
> installed using the command 'npm install' executed from the console's install 
> directory.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org