[jira] [Commented] (QPID-5365) Clean up file locations in Dispatch
[ https://issues.apache.org/jira/browse/QPID-5365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13827746#comment-13827746 ] Justin Ross commented on QPID-5365: --- Ted, if you approve of this change, I can commit it. The patch may not handle some of the deletions well. Clean up file locations in Dispatch --- Key: QPID-5365 URL: https://issues.apache.org/jira/browse/QPID-5365 Project: Qpid Issue Type: Improvement Components: Qpid Dispatch Reporter: Justin Ross Assignee: Justin Ross Attachments: relocations.patch The attached patch makes the file locations consistent wrt the conventions outlined in QPID-5351 and otherwise removes redundancies, simplifies, and prepares for future additions. With this change, the tests and installs without error in my environment. -- This message was sent by Atlassian JIRA (v6.1#6144) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-5365) Clean up file locations in Dispatch
[ https://issues.apache.org/jira/browse/QPID-5365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13827899#comment-13827899 ] Darryl L. Pierce commented on QPID-5365: We really can't nest the tools library within the package name for the router's private libraries. With QPID-5335, the two sets of Python code will be installed to two different locations. * qpid_dispatch under /usr/lib/qpid-dispatch/ * the tools package to /usr/lib/python2.7/site-packages Python won't work with the same top level package in two different locations; i.e., if it tries to import qpid_dispatch/tools/foo but it has the private library in its path first, it will fail. Clean up file locations in Dispatch --- Key: QPID-5365 URL: https://issues.apache.org/jira/browse/QPID-5365 Project: Qpid Issue Type: Improvement Components: Qpid Dispatch Reporter: Justin Ross Assignee: Justin Ross Attachments: relocations.patch The attached patch makes the file locations consistent wrt the conventions outlined in QPID-5351 and otherwise removes redundancies, simplifies, and prepares for future additions. With this change, the tests and installs without error in my environment. -- This message was sent by Atlassian JIRA (v6.1#6144) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-5365) Clean up file locations in Dispatch
[ https://issues.apache.org/jira/browse/QPID-5365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13827913#comment-13827913 ] Justin Ross commented on QPID-5365: --- I think that's a good change to make, but this patch is against the current state of affairs. AFAICT, there haven't been any changes yet to address QPID-5335. There's no patch there either. The only associated change seems to be misattributed. And the next step: none of the qpid dispatch python code needs to be in site-packages, at least so far. All of it IMO can go to /usr/lib/qpid-dispatch. Finally, why /usr/*lib*/qpid-dispatch, out of curiosity? I was thinking /usr/share/qpid-dispatch made more sense. I'd love any pointers to guidelines you have. Clean up file locations in Dispatch --- Key: QPID-5365 URL: https://issues.apache.org/jira/browse/QPID-5365 Project: Qpid Issue Type: Improvement Components: Qpid Dispatch Reporter: Justin Ross Assignee: Justin Ross Attachments: relocations.patch The attached patch makes the file locations consistent wrt the conventions outlined in QPID-5351 and otherwise removes redundancies, simplifies, and prepares for future additions. With this change, the tests and installs without error in my environment. -- This message was sent by Atlassian JIRA (v6.1#6144) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-5365) Clean up file locations in Dispatch
[ https://issues.apache.org/jira/browse/QPID-5365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13827922#comment-13827922 ] Ted Ross commented on QPID-5365: Justin, Go ahead and commit the change. Darryl, Lets address the the private path issue on top of this update. Clean up file locations in Dispatch --- Key: QPID-5365 URL: https://issues.apache.org/jira/browse/QPID-5365 Project: Qpid Issue Type: Improvement Components: Qpid Dispatch Reporter: Justin Ross Assignee: Justin Ross Attachments: relocations.patch The attached patch makes the file locations consistent wrt the conventions outlined in QPID-5351 and otherwise removes redundancies, simplifies, and prepares for future additions. With this change, the tests and installs without error in my environment. -- This message was sent by Atlassian JIRA (v6.1#6144) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-5365) Clean up file locations in Dispatch
[ https://issues.apache.org/jira/browse/QPID-5365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13827945#comment-13827945 ] ASF subversion and git services commented on QPID-5365: --- Commit 1543898 from [~justi9] in branch 'dispatch/trunk' [ https://svn.apache.org/r1543898 ] QPID-5365: Clean up file locations Clean up file locations in Dispatch --- Key: QPID-5365 URL: https://issues.apache.org/jira/browse/QPID-5365 Project: Qpid Issue Type: Improvement Components: Qpid Dispatch Reporter: Justin Ross Assignee: Justin Ross Attachments: relocations.patch The attached patch makes the file locations consistent wrt the conventions outlined in QPID-5351 and otherwise removes redundancies, simplifies, and prepares for future additions. With this change, the tests and installs without error in my environment. -- This message was sent by Atlassian JIRA (v6.1#6144) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-5365) Clean up file locations in Dispatch
[ https://issues.apache.org/jira/browse/QPID-5365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13827973#comment-13827973 ] ASF subversion and git services commented on QPID-5365: --- Commit 1543905 from [~tedross] in branch 'dispatch/trunk' [ https://svn.apache.org/r1543905 ] QPID-5365 - More cleanup related to file locations. Clean up file locations in Dispatch --- Key: QPID-5365 URL: https://issues.apache.org/jira/browse/QPID-5365 Project: Qpid Issue Type: Improvement Components: Qpid Dispatch Reporter: Justin Ross Assignee: Justin Ross Attachments: relocations.patch The attached patch makes the file locations consistent wrt the conventions outlined in QPID-5351 and otherwise removes redundancies, simplifies, and prepares for future additions. With this change, the tests and installs without error in my environment. -- This message was sent by Atlassian JIRA (v6.1#6144) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-5365) Clean up file locations in Dispatch
[ https://issues.apache.org/jira/browse/QPID-5365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13827983#comment-13827983 ] Darryl L. Pierce commented on QPID-5365: Ted: Okay. Justin: I discussed the issue with a few people in the #fedora-devel channel on Freenode. There it was suggested to go under /usr/lib/[appname] since they're libraries, but not public libraries. That said, /usr/lib/qpid-dispatch and /usr/share/qpid-dispatch are equally represented, and in the packaging guidelines [1] I found it references /usr/share specifically. [1] http://fedoraproject.org/wiki/Packaging:Python Clean up file locations in Dispatch --- Key: QPID-5365 URL: https://issues.apache.org/jira/browse/QPID-5365 Project: Qpid Issue Type: Improvement Components: Qpid Dispatch Reporter: Justin Ross Assignee: Justin Ross Attachments: relocations.patch The attached patch makes the file locations consistent wrt the conventions outlined in QPID-5351 and otherwise removes redundancies, simplifies, and prepares for future additions. With this change, the tests and installs without error in my environment. -- This message was sent by Atlassian JIRA (v6.1#6144) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
