Re: [PR] PROTON-2772: add printf format arg annotations to satisfy MSVC [qpid-proton]

2024-01-10 Thread via GitHub
jiridanek merged PR #419: URL: https://github.com/apache/qpid-proton/pull/419 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] PROTON-2772: add printf format arg annotations to satisfy MSVC [qpid-proton]

2024-01-07 Thread via GitHub
jiridanek commented on code in PR #419: URL: https://github.com/apache/qpid-proton/pull/419#discussion_r1444071676 ## c/src/core/encoder.c: ## @@ -78,7 +78,7 @@ static uint8_t pn_type2code(pn_encoder_t *encoder, pn_type_t type) case PN_MAP: return PNE_MAP32; case

Re: [PR] PROTON-2772: add printf format arg annotations to satisfy MSVC [qpid-proton]

2024-01-07 Thread via GitHub
jiridanek commented on code in PR #419: URL: https://github.com/apache/qpid-proton/pull/419#discussion_r1444071641 ## c/src/core/engine.c: ## @@ -1645,9 +1645,9 @@ void pn_delivery_dump(pn_delivery_t *d) printf("{tag=%s, local.type=%" PRIu64 ", remote.type=%" PRIu64 ",

Re: [PR] PROTON-2772: add printf format arg annotations to satisfy MSVC [qpid-proton]

2024-01-07 Thread via GitHub
jiridanek commented on code in PR #419: URL: https://github.com/apache/qpid-proton/pull/419#discussion_r1444069607 ## c/src/core/encoder.c: ## @@ -78,7 +78,7 @@ static uint8_t pn_type2code(pn_encoder_t *encoder, pn_type_t type) case PN_MAP: return PNE_MAP32; case

Re: [PR] PROTON-2772: add printf format arg annotations to satisfy MSVC [qpid-proton]

2024-01-07 Thread via GitHub
jiridanek commented on code in PR #419: URL: https://github.com/apache/qpid-proton/pull/419#discussion_r1444068569 ## c/src/core/engine.c: ## @@ -1645,9 +1645,9 @@ void pn_delivery_dump(pn_delivery_t *d) printf("{tag=%s, local.type=%" PRIu64 ", remote.type=%" PRIu64 ",