Re: [PR] PROTON-2772: make wrong printf format strings a MSVC compile error [qpid-proton]

jiridanek merged PR #409: URL: https://github.com/apache/qpid-proton/pull/409 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] PROTON-2772: make wrong printf format strings a MSVC compile error [qpid-proton]

jiridanek commented on PR #409: URL: https://github.com/apache/qpid-proton/pull/409#issuecomment-1880137421 This has been here for a long time with no objections raised. I'm going to squash the commits and merge this first part (annotations and CMakeLists.txt flags). I'll create a

Re: [PR] PROTON-2772: make wrong printf format strings a MSVC compile error [qpid-proton]

jiridanek commented on PR #409: URL: https://github.com/apache/qpid-proton/pull/409#issuecomment-1880060298 My plan here is to boot up Windows, add all the new warnings on MSVC to the CMakeLists.txt as suppressed, and merge that. I will add comments what these numbers mean. I'll consider

Re: [PR] PROTON-2772: make wrong printf format strings a MSVC compile error [qpid-proton]

jiridanek commented on PR #409: URL: https://github.com/apache/qpid-proton/pull/409#issuecomment-1762995906 This PR currently only reveals the issues, it does not try to fix them. There is few tens of warnings generated, for C6328 and C6340 warnings.