Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/230#discussion_r110523933
--- Diff: CMakeLists.txt ---
@@ -792,3 +794,13 @@ if (ENABLE_DISTRIBUTED)
${GFLAGS_LIB_NAME}
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/230#discussion_r110524066
--- Diff: cli/QuickstepClient.cpp ---
@@ -0,0 +1,109 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/230#discussion_r110524021
--- Diff: cli/CMakeLists.txt ---
@@ -150,7 +170,15 @@ if(USE_LINENOISE)
else()
target_link_libraries(quickstep_cli_LineReader
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/230#discussion_r110524143
--- Diff: cli/QuickstepClient.cpp ---
@@ -0,0 +1,109 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/230#discussion_r110523774
--- Diff: CMakeLists.txt ---
@@ -145,6 +145,7 @@ if (ENABLE_VECTOR_PREDICATE_SHORT_CIRCUIT)
)
endif()
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/230#discussion_r110524125
--- Diff: cli/QuickstepClient.cpp ---
@@ -0,0 +1,109 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/230#discussion_r110524371
--- Diff: cli/SingleNodeServer.proto ---
@@ -0,0 +1,34 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/230#discussion_r110524222
--- Diff: cli/QuickstepClient.cpp ---
@@ -0,0 +1,109 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/230#discussion_r110524089
--- Diff: cli/QuickstepClient.cpp ---
@@ -0,0 +1,109 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/230#discussion_r110524355
--- Diff: cli/SingleNodeServer.proto ---
@@ -0,0 +1,34 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/230#discussion_r110524040
--- Diff: cli/QuickstepClient.cpp ---
@@ -0,0 +1,109 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/230#discussion_r110524344
--- Diff: cli/QuickstepClient.cpp ---
@@ -0,0 +1,109 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/230#discussion_r110524033
--- Diff: cli/QuickstepClient.cpp ---
@@ -0,0 +1,109 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/230#discussion_r110524205
--- Diff: cli/QuickstepClient.cpp ---
@@ -0,0 +1,109 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/229
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/229#discussion_r110511246
--- Diff: parser/SqlParser.ypp ---
@@ -676,7 +686,7 @@ sql_statement:
| quit_statement {
$$ = $1;
}
- |
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/230
There are several ways to get `Protobuf 3` and `gRPC` in Travis, but
unfortunately all may result in time-out.
* PR #223 upgrades git submodule in the third_party.
* PR #220
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/230
@zuyu is there something special we specify in Travis to get Proto3?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/230
Unfortunately, for now no CIs for the distributed version due to both
`Protobuf 3` and `gRPC` dependencies. But we definitely should have!
One thing to add is that ccache could
19 matches
Mail list logo
