Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/232
We need to sync up with the master branch before merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/232
After @hbdeshmukh and I's code review, we created:
* QUICKSTEP-90
* QUICKSTEP-91
in response to some of the issues we found. @zuyu 90 will address the async
upgrade.
A
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/232
I mean, if this class is always a base class, move the constructor in
protected session.
On Mon, Apr 24, 2017 at 12:58 PM Marc S wrote:
> *@cramja* commented on this pull re
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/232
@zuyu Thank you for review. I addressed the minor stuff and will look into
Async when I have more time this coming week.
---
If your project is set up for it, you can reply to this email
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/232
I should also mention that @hbdeshmukh and I had a discussion yesterday
about refactoring the CLI main method. I was unhappy with how cluttered seeming
it has become, and this PR only mak
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/232
@zuyu Thank you for review. Regarding the question about mutexes and
cond_var in the `NetworkCliServiceImpl`, we disallow multiple gRPC threads from
submitting requests at the same time.
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/232
Thanks @hbdeshmukh , fixed validate_cmakelists issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
