Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/291
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136199350
--- Diff: relational_operators/TextScanOperator.cpp ---
@@ -82,14 +81,19 @@ static bool ValidateTextScanTextSegmentSize(const char
*flagname,
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136198329
--- Diff: query_optimizer/resolver/Resolver.cpp ---
@@ -143,6 +145,45 @@ namespace E = ::quickstep::optimizer::expressions;
namespace L =
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136197963
--- Diff: query_optimizer/logical/LogicalType.hpp ---
@@ -34,6 +34,7 @@ namespace logical {
enum class LogicalType {
kAggregate,
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136197848
--- Diff: query_optimizer/logical/CopyTo.hpp ---
@@ -0,0 +1,141 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136180815
--- Diff: query_optimizer/logical/CopyFrom.hpp ---
@@ -66,20 +67,14 @@ class CopyFrom : public Logical {
const std::string& file_name()
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136178849
--- Diff: parser/ParseStatement.hpp ---
@@ -771,122 +776,135 @@ class ParseStatementInsertSelection : public
ParseStatementInsert {
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136199193
--- Diff: relational_operators/TableExportOperator.hpp ---
@@ -0,0 +1,268 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136198182
--- Diff: query_optimizer/physical/CopyFrom.hpp ---
@@ -68,22 +69,14 @@ class CopyFrom : public Physical {
const std::string&
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136198572
--- Diff: query_optimizer/resolver/Resolver.cpp ---
@@ -418,27 +455,157 @@ L::LogicalPtr Resolver::resolve(const ParseStatement
_query) {
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136198255
--- Diff: query_optimizer/physical/CopyTo.hpp ---
@@ -0,0 +1,147 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136198306
--- Diff: query_optimizer/physical/PhysicalType.hpp ---
@@ -34,6 +34,7 @@ namespace physical {
enum class PhysicalType {
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136198462
--- Diff: query_optimizer/resolver/Resolver.cpp ---
@@ -418,27 +455,157 @@ L::LogicalPtr Resolver::resolve(const ParseStatement
_query) {
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136198547
--- Diff: query_optimizer/resolver/Resolver.cpp ---
@@ -418,27 +455,157 @@ L::LogicalPtr Resolver::resolve(const ParseStatement
_query) {
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136199047
--- Diff: query_optimizer/resolver/Resolver.cpp ---
@@ -1595,6 +1742,19 @@ void
Resolver::appendProjectIfNeedPrecomputationAfterAggregation(
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136199940
--- Diff: utility/ExecutionDAGVisualizer.cpp ---
@@ -55,12 +55,15 @@ using std::to_string;
namespace quickstep {
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136199148
--- Diff: relational_operators/TableExportOperator.hpp ---
@@ -0,0 +1,268 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136198676
--- Diff: query_optimizer/resolver/Resolver.cpp ---
@@ -418,27 +455,157 @@ L::LogicalPtr Resolver::resolve(const ParseStatement
_query) {
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136199029
--- Diff: query_optimizer/resolver/Resolver.cpp ---
@@ -418,27 +455,157 @@ L::LogicalPtr Resolver::resolve(const ParseStatement
_query) {
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136178749
--- Diff: parser/ParseStatement.hpp ---
@@ -60,16 +60,16 @@ class ParseStatement : public ParseTreeNode {
* @brief The possible types
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136175863
--- Diff: parser/ParseKeyValue.hpp ---
@@ -37,14 +37,15 @@ namespace quickstep {
*/
class ParseKeyValue : public ParseTreeNode {
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136171013
--- Diff: relational_operators/TableExportOperator.cpp ---
@@ -0,0 +1,329 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136162438
--- Diff: query_optimizer/resolver/Resolver.cpp ---
@@ -418,27 +455,157 @@ L::LogicalPtr Resolver::resolve(const ParseStatement
_query) {
}
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136148771
--- Diff: parser/ParseStatement.hpp ---
@@ -771,122 +776,135 @@ class ParseStatementInsertSelection : public
ParseStatementInsert {
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136173360
--- Diff: relational_operators/TextScanOperator.cpp ---
@@ -82,14 +81,19 @@ static bool ValidateTextScanTextSegmentSize(const char
*flagname,
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136164669
--- Diff: query_optimizer/resolver/Resolver.cpp ---
@@ -418,27 +455,157 @@ L::LogicalPtr Resolver::resolve(const ParseStatement
_query) {
}
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136158846
--- Diff: query_optimizer/physical/CopyTo.hpp ---
@@ -0,0 +1,147 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136158363
--- Diff: query_optimizer/logical/CopyTo.hpp ---
@@ -0,0 +1,141 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136158497
--- Diff: query_optimizer/logical/LogicalType.hpp ---
@@ -34,6 +34,7 @@ namespace logical {
enum class LogicalType {
kAggregate,
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136149449
--- Diff: parser/ParseStatement.hpp ---
@@ -898,24 +916,53 @@ class ParseStatementCopyFrom : public ParseStatement {
std::vector
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136165286
--- Diff: query_optimizer/resolver/Resolver.cpp ---
@@ -1595,6 +1742,19 @@ void
Resolver::appendProjectIfNeedPrecomputationAfterAggregation(
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136161344
--- Diff: query_optimizer/resolver/Resolver.cpp ---
@@ -418,27 +455,157 @@ L::LogicalPtr Resolver::resolve(const ParseStatement
_query) {
}
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136162397
--- Diff: query_optimizer/resolver/Resolver.cpp ---
@@ -418,27 +455,157 @@ L::LogicalPtr Resolver::resolve(const ParseStatement
_query) {
}
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136165036
--- Diff: query_optimizer/resolver/Resolver.cpp ---
@@ -143,6 +145,45 @@ namespace E = ::quickstep::optimizer::expressions;
namespace L =
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136154199
--- Diff: utility/BulkIOConfiguration.hpp ---
@@ -0,0 +1,198 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136162361
--- Diff: query_optimizer/resolver/Resolver.cpp ---
@@ -418,27 +455,157 @@ L::LogicalPtr Resolver::resolve(const ParseStatement
_query) {
}
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136172992
--- Diff: relational_operators/TableExportOperator.hpp ---
@@ -0,0 +1,268 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136173116
--- Diff: relational_operators/TableExportOperator.hpp ---
@@ -0,0 +1,268 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136148367
--- Diff: parser/ParseStatement.hpp ---
@@ -60,16 +60,16 @@ class ParseStatement : public ParseTreeNode {
* @brief The possible types of
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136158632
--- Diff: query_optimizer/physical/CopyFrom.hpp ---
@@ -68,22 +69,14 @@ class CopyFrom : public Physical {
const std::string& file_name()
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136156631
--- Diff: utility/BulkIOConfiguration.hpp ---
@@ -0,0 +1,198 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136161900
--- Diff: query_optimizer/resolver/Resolver.cpp ---
@@ -418,27 +455,157 @@ L::LogicalPtr Resolver::resolve(const ParseStatement
_query) {
}
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136161515
--- Diff: query_optimizer/resolver/Resolver.cpp ---
@@ -418,27 +455,157 @@ L::LogicalPtr Resolver::resolve(const ParseStatement
_query) {
}
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136154272
--- Diff: utility/BulkIOConfiguration.hpp ---
@@ -0,0 +1,198 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136153634
--- Diff: utility/BulkIOConfiguration.hpp ---
@@ -0,0 +1,198 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136161982
--- Diff: query_optimizer/resolver/Resolver.cpp ---
@@ -418,27 +455,157 @@ L::LogicalPtr Resolver::resolve(const ParseStatement
_query) {
}
GitHub user jianqiao opened a pull request:
https://github.com/apache/incubator-quickstep/pull/291
Add "COPY TO" operator for exporting data from Quickstep.
This PR adds support for the "COPY TO" statement for exporting tables from
Quickstep. Two formats `TEXT` and `CSV` are
47 matches
Mail list logo
