[GitHub] incubator-quickstep pull request #308: Removed unused argument always_mark_f...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-quickstep/pull/308


---

[GitHub] incubator-quickstep pull request #308: Removed unused argument always_mark_f...

[zuyu]

Github user zuyu commented on a diff in the pull request:

https://github.com/apache/incubator-quickstep/pull/308#discussion_r143825045
  
--- Diff: storage/InsertDestinationInterface.hpp ---
@@ -104,7 +104,7 @@ class InsertDestinationInterface {
*insertion from ValueAccessor even when partially full.
**/
   virtual void bulkInsertTuples(ValueAccessor *accessor,
-bool always_mark_full = false) = 0;
+const bool always_mark_full = false) = 0;
--- End diff --

It is required by the first pass of the multi-pass sort.


---

[GitHub] incubator-quickstep pull request #308: Removed unused argument always_mark_f...

[hbdeshmukh]

Github user hbdeshmukh commented on a diff in the pull request:

https://github.com/apache/incubator-quickstep/pull/308#discussion_r143823339
  
--- Diff: storage/InsertDestinationInterface.hpp ---
@@ -104,7 +104,7 @@ class InsertDestinationInterface {
*insertion from ValueAccessor even when partially full.
**/
   virtual void bulkInsertTuples(ValueAccessor *accessor,
-bool always_mark_full = false) = 0;
+const bool always_mark_full = false) = 0;
--- End diff --

Similar to other variants of bulkInsert methods, why are we not getting rid 
of the ``always_mark_full`` parameter in this function? 


---

[GitHub] incubator-quickstep pull request #308: Removed unused argument always_mark_f...

[zuyu]

GitHub user zuyu opened a pull request:

https://github.com/apache/incubator-quickstep/pull/308

Removed unused argument always_mark_full.

This PR cleans up the unused argument `always_mark_full`, and avoids 
branching overhead.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zuyu/incubator-quickstep always-mark-full-arg

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-quickstep/pull/308.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #308


commit f4c27de2e19f56a0410c9c216a7b96604358b50b
Author: Zuyu Zhang 
Date:   2017-10-05T22:18:05Z

Removed unused argument always_mark_full.




---