Re: [racket-dev] [plt] Push #21701: master branch updated

2010-12-10 Thread Eli Barzilay
5 minutes ago, Casey Klein wrote: For anyone following at home, the change turns this message [...] Ah, so that's what broke enough tests to make the build log explode... into this one /Users/clklein/tmp/contract-violator.rkt:9.17: found a contradiction between the contract (- any/c

Re: [racket-dev] [plt] Push #21701: master branch updated

2010-12-10 Thread Eli Barzilay
Two minutes ago, Eli Barzilay wrote: 5 minutes ago, Casey Klein wrote: For anyone following at home, the change turns this message [...] Ah, so that's what broke enough tests to make the build log explode... See also the drdr party:

Re: [racket-dev] [plt] Push #21701: master branch updated

2010-12-10 Thread Robby Findler
Positive suggestions for improvement are welcome. Bad analogies that don't help are like someone coming over to your house and hitting you with hammer before you even get a chance to have some coffee. Robby On Fri, Dec 10, 2010 at 5:01 AM, Eli Barzilay e...@barzilay.org wrote: 5 minutes ago,

Re: [racket-dev] [plt] Push #21701: master branch updated

2010-12-10 Thread Eli Barzilay
15 minutes ago, Robby Findler wrote: Positive suggestions for improvement are welcome. Bad analogies that don't help are like someone coming over to your house and hitting you with hammer before you even get a chance to have some coffee. I didn't even intend for this to be a (bad) analogy --

Re: [racket-dev] [plt] Push #21701: master branch updated

2010-12-10 Thread Robby Findler
Thanks, Casey. Perhaps I should have announced our intentions in changing this message but you've pretty much gotten it (implicitly written below). A little more detail: recently I got a complaint that the contract system error messages were wrong, a complaint that I had now heard many many

Re: [racket-dev] [plt] Push #21701: master branch updated

2010-12-10 Thread Robby Findler
Okay. So I'll just start by spelling out the pieces of information that's there to be put into a message: - is the contract blaming the party where the contract was written (or not) - the source location where the contract was written down - the contract, written out - the names of the two

Re: [racket-dev] [plt] Push #21701: master branch updated

2010-12-10 Thread Casey Klein
On Fri, Dec 10, 2010 at 7:00 AM, Eli Barzilay e...@barzilay.org wrote: As for a suggestion, I don't have anything concrete (and I don't have nearly enough contract experience to say something concrete) -- but in general I prefer to see those important bits first, and the vague human text

Re: [racket-dev] [plt] Push #21701: master branch updated

2010-12-10 Thread Sam Tobin-Hochstadt
On Fri, Dec 10, 2010 at 8:26 AM, Casey Klein clkl...@eecs.northwestern.edu wrote: On Fri, Dec 10, 2010 at 7:00 AM, Eli Barzilay e...@barzilay.org wrote: As for a suggestion, I don't have anything concrete (and I don't have nearly enough contract experience to say something concrete) -- but in

Re: [racket-dev] [plt] Push #21701: master branch updated

2010-12-10 Thread Stevie Strickland
On Dec 10, 2010, at 8:12 AM, Robby Findler wrote: If someone besides me wants to take a stab at formulating a less painful message, the code is in collects/racket/contract/private/blame.rkt and, thanks to Stevie's refactoring, very easy to work with. While I'd love to take the credit on

Re: [racket-dev] [plt] Push #21701: master branch updated

2010-12-10 Thread Robby Findler
On Fri, Dec 10, 2010 at 9:26 AM, Stevie Strickland sstri...@ccs.neu.edu wrote: On Dec 10, 2010, at 8:12 AM, Robby Findler wrote: If someone besides me wants to take a stab at formulating a less painful message, the code is in collects/racket/contract/private/blame.rkt and, thanks to Stevie's

Re: [racket-dev] [plt] Push #21701: master branch updated

2010-12-10 Thread Casey Klein
On Fri, Dec 10, 2010 at 7:34 AM, Sam Tobin-Hochstadt sa...@ccs.neu.edu wrote: On Fri, Dec 10, 2010 at 8:26 AM, Casey Klein clkl...@eecs.northwestern.edu wrote: On Fri, Dec 10, 2010 at 7:00 AM, Eli Barzilay e...@barzilay.org wrote: As for a suggestion, I don't have anything concrete (and I

Re: [racket-dev] [plt] Push #21701: master branch updated

2010-12-10 Thread Eli Barzilay
Three hours ago, Robby Findler wrote: Okay. So I'll just start by spelling out the pieces of information that's there to be put into a message: - is the contract blaming the party where the contract was written (or not) - the source location where the contract was written down - the

Re: [racket-dev] [plt] Push #21701: master branch updated

2010-12-10 Thread Robby Findler
Both this and Sam's idea seem like good ways to improve the error message to me. Not sure if Casey or Sam (or Christos?) wants to try to their hand at the actual formatting or not. I will, if not. I don't like the possible fixes include language, tho-- I prefer that we either say that this error

Re: [racket-dev] [plt] Push #21701: master branch updated

2010-12-10 Thread Robby Findler
On Fri, Dec 10, 2010 at 10:38 AM, Robby Findler ro...@eecs.northwestern.edu wrote: Both this and Sam's idea seem like good ways to improve the error message to me. Not sure if Casey or Sam (or Christos?) wants to try to their hand at the actual formatting or not. I will, if not. I don't like

Re: [racket-dev] [plt] Push #21701: master branch updated

2010-12-10 Thread Stevie Strickland
On Dec 10, 2010, at 11:38 AM, Robby Findler wrote: Both this and Sam's idea seem like good ways to improve the error message to me. Not sure if Casey or Sam (or Christos?) wants to try to their hand at the actual formatting or not. I will, if not. A couple of things to note for anyone who