Re: Review Request 61116: RANGER-1664 Add-ons to support ADLS in Ranger Authorization Model

[Velmurugan Periasamy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61116/#review200647
---




agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java
Line 63 (original), 63 (patched)


Can you please revise the patch? Fails to apply. 

```
$ git apply --check -v < ~/Downloads/RANGER-1664.1.patch
Checking patch 
agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java...
error: while searching for:
public static final String EMBEDDED_SERVICEDEF_NIFI_NAME  = "nifi";
public static final String EMBEDDED_SERVICEDEF_ATLAS_NAME  = "atlas";
public static final String EMBEDDED_SERVICEDEF_WASB_NAME  = "wasb";

public static final String PROPERTY_CREATE_EMBEDDED_SERVICE_DEFS = 
"ranger.service.store.create.embedded.service-defs";

error: patch failed: 
agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java:63
error: 
agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java:
 patch does not apply
Checking patch 
agents-common/src/main/resources/service-defs/ranger-servicedef-adls.json...
```


- Velmurugan Periasamy


On Nov. 20, 2017, 1:11 p.m., Anandsagar Kothapalli wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61116/
> ---
> 
> (Updated Nov. 20, 2017, 1:11 p.m.)
> 
> 
> Review request for ranger, Abhay Kulkarni, Ramesh Mani, and Velmurugan 
> Periasamy.
> 
> 
> Bugs: RANGER-1664
> https://issues.apache.org/jira/browse/RANGER-1664
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Add-ons to support Azure Data lake(ADLS) in Ranger Authorization Model
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java
>  0bc09f60 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-adls.json 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/61116/diff/1/
> 
> 
> Testing
> ---
> 
> Tested creating a VM
> 
> 
> Thanks,
> 
> Anandsagar Kothapalli
> 
>

Re: Review Request 61116: RANGER-1664 Add-ons to support ADLS in Ranger Authorization Model

[Anandsagar Kothapalli via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61116/
---

(Updated Nov. 20, 2017, 1:11 p.m.)


Review request for ranger, Abhay Kulkarni, Ramesh Mani, and Velmurugan 
Periasamy.


Bugs: RANGER-1664
https://issues.apache.org/jira/browse/RANGER-1664


Repository: ranger


Description
---

Add-ons to support Azure Data lake(ADLS) in Ranger Authorization Model


Diffs
-

  
agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java
 0bc09f60 
  agents-common/src/main/resources/service-defs/ranger-servicedef-adls.json 
PRE-CREATION 


Diff: https://reviews.apache.org/r/61116/diff/1/


Testing
---

Tested creating a VM


Thanks,

Anandsagar Kothapalli

Re: Review Request 61116: RANGER-1664 Add-ons to support ADLS in Ranger Authorization Model

[Anandsagar Kothapalli via Review Board]

> On Aug. 25, 2017, 7:32 a.m., Madhan Neethiraj wrote:
> > Anandsagar Kothapalli - the patch looks good. Are you planning to add 
> > plugin implementation as well?

yes, but there no more changes in ranger repo in regards to that.


- Anandsagar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61116/#review183831
---


On July 25, 2017, 6:42 p.m., Anandsagar Kothapalli wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61116/
> ---
> 
> (Updated July 25, 2017, 6:42 p.m.)
> 
> 
> Review request for ranger, Abhay Kulkarni, Ramesh Mani, and Velmurugan 
> Periasamy.
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Add-ons to support Azure Data lake(ADLS) in Ranger Authorization Model
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java
>  0bc09f60 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-adls.json 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/61116/diff/1/
> 
> 
> Testing
> ---
> 
> Tested creating a VM
> 
> 
> Thanks,
> 
> Anandsagar Kothapalli
> 
>

Re: Review Request 61116: RANGER-1664 Add-ons to support ADLS in Ranger Authorization Model

[Anandsagar Kothapalli via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61116/#review186163
---


Ship it!




Ship It!

- Anandsagar Kothapalli


On July 25, 2017, 6:42 p.m., Anandsagar Kothapalli wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61116/
> ---
> 
> (Updated July 25, 2017, 6:42 p.m.)
> 
> 
> Review request for ranger, Abhay Kulkarni, Ramesh Mani, and Velmurugan 
> Periasamy.
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Add-ons to support Azure Data lake(ADLS) in Ranger Authorization Model
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java
>  0bc09f60 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-adls.json 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/61116/diff/1/
> 
> 
> Testing
> ---
> 
> Tested creating a VM
> 
> 
> Thanks,
> 
> Anandsagar Kothapalli
> 
>

Re: Review Request 61116: RANGER-1664 Add-ons to support ADLS in Ranger Authorization Model

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61116/#review183831
---


Ship it!




Anandsagar Kothapalli - the patch looks good. Are you planning to add plugin 
implementation as well?

- Madhan Neethiraj


On July 25, 2017, 6:42 p.m., Anandsagar Kothapalli wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61116/
> ---
> 
> (Updated July 25, 2017, 6:42 p.m.)
> 
> 
> Review request for ranger, Abhay Kulkarni, Ramesh Mani, and Velmurugan 
> Periasamy.
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Add-ons to support Azure Data lake(ADLS) in Ranger Authorization Model
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java
>  0bc09f60 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-adls.json 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/61116/diff/1/
> 
> 
> Testing
> ---
> 
> Tested creating a VM
> 
> 
> Thanks,
> 
> Anandsagar Kothapalli
> 
>