[GitHub] incubator-rocketmq pull request #33: [ROCKETMQ-37] Log output information is...
Github user asfgit closed the pull request at: https://github.com/apache/incubator-rocketmq/pull/33 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq pull request #33: [ROCKETMQ-37] Log output information is...
Github user a2888409 commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/33#discussion_r96159731
--- Diff:
client/src/main/java/org/apache/rocketmq/client/impl/MQClientManager.java ---
@@ -53,8 +53,9 @@ public MQClientInstance
getAndCreateMQClientInstance(final ClientConfig clientCo
MQClientInstance prev =
this.factoryTable.putIfAbsent(clientId, instance);
if (prev != null) {
instance = prev;
-} else {
log.warn("Previous MQClientInstance has created for
clientId:[{}]", clientId);
+} else {
+log.info("new MQClientInstance has created for
clientId:[{}]", clientId);
--- End diff --
thanks, i have fixed it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq pull request #33: [ROCKETMQ-37] Log output information is...
Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/33#discussion_r95966853
--- Diff:
client/src/main/java/org/apache/rocketmq/client/impl/MQClientManager.java ---
@@ -53,8 +53,9 @@ public MQClientInstance
getAndCreateMQClientInstance(final ClientConfig clientCo
MQClientInstance prev =
this.factoryTable.putIfAbsent(clientId, instance);
if (prev != null) {
instance = prev;
-} else {
log.warn("Previous MQClientInstance has created for
clientId:[{}]", clientId);
+} else {
+log.info("new MQClientInstance has created for
clientId:[{}]", clientId);
--- End diff --
It will be best if using active tune here. Something like, Returned
previous MQClientInstance for clientId: ..., Created new MQClientInstance for
clientId: ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq pull request #33: [ROCKETMQ-37] Log output information is...
GitHub user a2888409 opened a pull request: https://github.com/apache/incubator-rocketmq/pull/33 [ROCKETMQ-37] Log output information is not accurate Jira issue: https://issues.apache.org/jira/browse/ROCKETMQ-37 You can merge this pull request into a Git repository by running: $ git pull https://github.com/a2888409/incubator-rocketmq master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-rocketmq/pull/33.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #33 commit 633eca2665edca4999b28f3f57857649d821c52c Author: qianzhenyu <122274...@qq.com> Date: 2017-01-09T08:54:31Z Fix-37 [ROCKETMQ-37] Log output information is not accurate --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
