Re: Nightly Builds Available

2017-10-04 Thread Carlos Rovira
I think what Piotr propose is very good for organization, revision and matching with issues. The workflow I know (and I think works pretty well) is the following. Notice that this method tries to always develop in branches and ensures develop is always stable and green. That should be our mantra,

Re: Nightly Builds Available

2017-10-03 Thread Piotr Zarzycki
If you are committing any changes use for example: "my commit message (reference #issuenumber)" - Than we will see on github all commits under issue and can review it. Piotr 2017-10-03 17:20 GMT+02:00 Alex Harui : > I"m not sure what you mean by "use issue number".

Re: Nightly Builds Available

2017-10-03 Thread Harbs
Not sure what Piotr meant. > On Oct 3, 2017, at 6:46 PM, Alex Harui wrote: > > Maybe I didn't get enough sleep last night. There is already an issue > open, yes? Am I supposed to type that issue# in the commit message or > something like that? I didn't see that from

Re: Nightly Builds Available

2017-10-03 Thread Alex Harui
Maybe I didn't get enough sleep last night. There is already an issue open, yes? Am I supposed to type that issue# in the commit message or something like that? I didn't see that from the link you posted. -Alex On 10/3/17, 8:42 AM, "Harbs" wrote: >I think he means

Re: Nightly Builds Available

2017-10-03 Thread Harbs
I think he means cross references between issues and commits. It’s also possible to have a list of issues within and issue.[1] Harbs [1]https://guides.github.com/features/issues/ > On Oct 3, 2017, at 6:20 PM, Alex Harui

Re: Nightly Builds Available

2017-10-03 Thread Alex Harui
I"m not sure what you mean by "use issue number". Where am I supposed to use it? -Alex On 10/3/17, 1:02 AM, "Piotr Zarzycki" wrote: >Alex, > >If you start renaming under some branch etc. please use issue number >(reference #number) - we will have everything under

Re: Nightly Builds Available

2017-10-03 Thread Piotr Zarzycki
Alex, If you start renaming under some branch etc. please use issue number (reference #number) - we will have everything under our created issue. It help a lot with reviewing. I have found that is much worse for me looking into the emails than on github right now. Thanks, Piotr 2017-10-03 7:25

Re: Nightly Builds Available

2017-10-02 Thread Alex Harui
OK, I merged packaging to develop. I think I see some consensus around the rename, so I will start on that tomorrow in feature branches. -Alex On 10/2/17, 12:29 AM, "Piotr Zarzycki" wrote: >Alex, > >I think we should have separate branch for renaming. Packaging

Re: Nightly Builds Available

2017-10-02 Thread Piotr Zarzycki
Hah! Harbs greate idea for creating issue. If you could do that. Thanks, Piotr 2017-10-02 9:32 GMT+02:00 Harbs : > I was in middle of writing the same thing. :) > > I think we should create an issue with what needs to be done for the > rename. The obvious is a

Re: Nightly Builds Available

2017-10-01 Thread Piotr Zarzycki
Alex, Thanks new nightly JS Only is working nicely with Moonshine along with my fix. :) Thank you! Piotr 2017-10-01 16:13 GMT+02:00 Alex Harui : > Yes, you are correct that the SWCs got corrupted. I made one change but > won't have time to test until later today.

Re: Nightly Builds Available

2017-09-30 Thread Piotr Zarzycki
I just fixed that issue in Moonshine. It will be available in upcoming 1.6.0 release. :) Thanks! 2017-09-30 19:32 GMT+02:00 Piotr Zarzycki : > Alex, > > You are right. I have found issue in Moonshine it basically parsing the > target player from flex-config.xml to

Re: Nightly Builds Available

2017-09-30 Thread Piotr Zarzycki
I just made small experiment. 1) I've downloaded FlexJS nightly using installer with Flash Player 23. 2) Create new project in Moonshine and build it with -targets=JSFlex - Build pass without the problem 3) I went to the folder "\frameworks\js\FlexJS\libs\" and removed all swc 4) I have copied

Re: Nightly Builds Available

2017-09-30 Thread Piotr Zarzycki
Alex, You are right. I have found issue in Moonshine it basically parsing the target player from flex-config.xml to 11.0.0 not 11.7. However I think something is wrong itself with SDK, cause I should be able to build project from console, but I'm getting strange errors for swcs. [1] [1]

Re: Nightly Builds Available

2017-09-30 Thread Alex Harui
The flex-config.xml in the JSOnly package should have target-player of 11.7 and there should be a frameworks/libs/player/11.7/playerglobal.swc Are you not seeing that? Maybe Moonshine is changing something? I'm out of time for this morning. Won't have more time until about 13 hours from now.

Re: Nightly Builds Available

2017-09-30 Thread Piotr Zarzycki
The last test was using console and it's failed with similar stack as ANT failed. [1] [1] https://paste.apache.org/TY72 Thanks, Piotr 2017-09-30 10:49 GMT+02:00 Piotr Zarzycki : > I just did also try to build project by build.xml ant file which I've > prepared for