Re: Review Request 52962: SAMZA-1029: Prepare release candidate for 0.11.0

2016-10-18 Thread Boris Shkolnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52962/#review153105 --- Ship it! - Boris Shkolnik On Oct. 18, 2016, midnight, Xinyu

Re: Review Request 52403: SAMZA-1028: Moving logline before closing kafka producer and making exception thrown AtomicReference

2016-10-18 Thread Prateek Maheshwari
> On Sept. 29, 2016, 2:30 p.m., Prateek Maheshwari wrote: > > samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemProducer.scala, > > line 220 > > > > > > If the intention is to allow user to ensure

Re: Review Request 52960: SAMZA-1029: Prepare release candidate for 0.11.0

2016-10-18 Thread Xinyu Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52960/ --- (Updated Oct. 18, 2016, 9:28 p.m.) Review request for samza and Navina Ramesh.

Re: Review Request 52960: SAMZA-1029: Prepare release candidate for 0.11.0

2016-10-18 Thread Xinyu Liu
> On Oct. 18, 2016, 12:32 a.m., Navina Ramesh wrote: > > docs/learn/tutorials/versioned/samza-rest-getting-started.md, line 51 > > > > > > Shouldn't this be 0.11.1-SNAPSHOT as well? Thanks for the catch! - Xinyu

Review Request 53000: SAMZA-1038: Update hello-samza master to use Samza 0.11.0

2016-10-18 Thread Xinyu Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53000/ --- Review request for samza. Repository: samza-hello-samza Description ---

Re: Review Request 53004: SAMZA-1038: Update hello-samza master to use Samza 0.11.0

2016-10-18 Thread Jagadish Venkatraman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53004/#review153197 --- Ship it! Ship It! - Jagadish Venkatraman On Oct. 18, 2016,

Review Request 53004: SAMZA-1038: Update hello-samza master to use Samza 0.11.0

2016-10-18 Thread Xinyu Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53004/ --- Review request for samza, Navina Ramesh and Jagadish Venkatraman. Repository:

Re: Review Request 53000: SAMZA-1038: Update hello-samza master to use Samza 0.11.0

2016-10-18 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53000/#review153191 --- Ship it! Ship It! - Jake Maes On Oct. 18, 2016, 10:17 p.m.,

Re: Review Request 53004: SAMZA-1038: Update hello-samza master to use Samza 0.11.0

2016-10-18 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53004/#review153193 --- Ship it! Ship It! - Jake Maes On Oct. 18, 2016, 10:17 p.m.,

Re: Review Request 53002: Do not load the monitor, if the MonitorFactoryClass is not defined for the monitor in the config.

2016-10-18 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53002/#review153224 --- Fix it, then Ship it! One minor issue below. Once that's

Re: Review Request 53002: Do not load the monitor, if the MonitorFactoryClass is not defined for the monitor in the config.

2016-10-18 Thread Shanthoosh Venkataraman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53002/ --- (Updated Oct. 19, 2016, 1:11 a.m.) Review request for samza and Jake Maes.

Re: Review Request 53002: Do not load the monitor, if the MonitorFactoryClass is not defined for the monitor in the config.

2016-10-18 Thread Fred Ji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53002/#review153208 --- Ship it!

Re: Review Request 53002: Do not load the monitor, if the MonitorFactoryClass is not defined for the monitor in the config.

2016-10-18 Thread Shanthoosh Venkataraman
> On Oct. 18, 2016, 11:11 p.m., Fred Ji wrote: > > samza-rest/src/main/java/org/apache/samza/monitor/SamzaMonitorService.java, > > line 71 > > > > > > nit: this line of comment is not needed since log warn is very

Re: Review Request 53000: SAMZA-1038: Update hello-samza master to use Samza 0.11.0

2016-10-18 Thread Jagadish Venkatraman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53000/#review153198 --- Ship it! Ship It! - Jagadish Venkatraman On Oct. 18, 2016,

Review Request 53002: Do not load the monitor, if the MonitorFactoryClass is not defined for the monitor in the config.

2016-10-18 Thread Shanthoosh Venkataraman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53002/ --- Review request for samza and Jake Maes. Repository: samza Description