Re: Review Request 48243: SAMZA-961: Async tasks and multithreading model

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48243/ --- (Updated July 11, 2016, 5:30 p.m.) Review request for samza, Chris Pettitt,

Re: Review Request 48243: SAMZA-961: Async tasks and multithreading model

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48243/#review138013 --- Fix it, then Ship it! Contingent on perf tests, of course.

Re: Review Request 48243: SAMZA-961: Async tasks and multithreading model

> On June 15, 2016, 3:08 p.m., Chris Pettitt wrote: > > samza-core/src/main/java/org/apache/samza/task/AsyncRunLoop.java, line 188 > > > > > > Do we need to handle the case that the SSP is not in the mappings or is

Re: Review Request 48243: SAMZA-961: Async tasks and multithreading model

> On June 15, 2016, 3:08 p.m., Chris Pettitt wrote: > > samza-core/src/main/java/org/apache/samza/task/AsyncRunLoop.java, line 188 > > > > > > Do we need to handle the case that the SSP is not in the mappings or is

Re: Review Request 48243: SAMZA-961: Async tasks and multithreading model

> On June 15, 2016, 6:49 a.m., Yi Pan (Data Infrastructure) wrote: > > samza-core/src/main/java/org/apache/samza/container/RunLoopFactory.java, > > line 62 > > > > > > It would be better to throw an exception when

Re: Review Request 48243: SAMZA-961: Async tasks and multithreading model

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48243/ --- (Updated June 15, 2016, 11:41 p.m.) Review request for samza, Chris Pettitt,

Re: Review Request 48243: SAMZA-961: Async tasks and multithreading model

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48243/#review137543 --- samza-core/src/main/java/org/apache/samza/task/AsyncRunLoop.java

Re: Review Request 48243: SAMZA-961: Async tasks and multithreading model

> On June 15, 2016, 6:49 a.m., Yi Pan (Data Infrastructure) wrote: > > samza-core/src/main/java/org/apache/samza/task/AsyncRunLoop.java, line 578 > > > > > > Don't quite get this point. It seems to me that the

Re: Review Request 48243: SAMZA-961: Async tasks and multithreading model

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48243/ --- (Updated June 9, 2016, 7:49 p.m.) Review request for samza, Chris Pettitt,

Re: Review Request 48243: SAMZA-961: Async tasks and multithreading model

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48243/#review136357 --- Biggest take away on this pass is that the async run loop code