Re: Review Request 53002: Do not load the monitor, if the MonitorFactoryClass is not defined for the monitor in the config.

2016-10-19 Thread Shanthoosh Venkataraman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53002/ --- (Updated Oct. 19, 2016, 6 p.m.) Review request for samza and Jake Maes.

Re: Review Request 53002: Do not load the monitor, if the MonitorFactoryClass is not defined for the monitor in the config.

2016-10-18 Thread Shanthoosh Venkataraman
> On Oct. 18, 2016, 11:11 p.m., Fred Ji wrote: > > samza-rest/src/main/java/org/apache/samza/monitor/SamzaMonitorService.java, > > line 71 > > > > > > nit: this line of comment is not needed since log warn is very

Re: Review Request 53002: Do not load the monitor, if the MonitorFactoryClass is not defined for the monitor in the config.

2016-10-18 Thread Shanthoosh Venkataraman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53002/ --- (Updated Oct. 19, 2016, 1:11 a.m.) Review request for samza and Jake Maes.

Re: Review Request 53002: Do not load the monitor, if the MonitorFactoryClass is not defined for the monitor in the config.

2016-10-18 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53002/#review153224 --- Fix it, then Ship it! One minor issue below. Once that's

Re: Review Request 53002: Do not load the monitor, if the MonitorFactoryClass is not defined for the monitor in the config.

2016-10-18 Thread Fred Ji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53002/#review153208 --- Ship it!