[GitHub] Yongyao commented on a change in pull request #7: SDAP-35 Overhaul MUDROD configuration
Yongyao commented on a change in pull request #7: SDAP-35 Overhaul MUDROD
configuration
URL:
https://github.com/apache/incubator-sdap-mudrod/pull/7#discussion_r174137301
##
File path:
core/src/main/java/org/apache/sdap/mudrod/weblog/structure/ApacheAccessLog.java
##
@@ -15,55 +15,49 @@
import com.google.gson.Gson;
+import org.apache.sdap.mudrod.main.MudrodConstants;
+import org.apache.sdap.mudrod.weblog.pre.CrawlerDetection;
+
import java.io.IOException;
import java.io.Serializable;
import java.text.ParseException;
import java.text.SimpleDateFormat;
import java.util.Date;
+import java.util.Properties;
import java.util.regex.Matcher;
import java.util.regex.Pattern;
-import org.apache.sdap.mudrod.weblog.pre.CrawlerDetection;
-
/**
* This class represents an Apache access log line. See
* http://httpd.apache.org/docs/2.2/logs.html for more details.
*/
public class ApacheAccessLog extends WebLog implements Serializable {
-
-
- /**
- *
- */
- private static final long serialVersionUID = 1L;
-
- public ApacheAccessLog() {
-//default constructor
- }
-
- String response;
- String referer;
- String browser;
+ String Response;
Review comment:
These variables were all upper case at the beginning. The previous
enhancement PR changed it to lower case which can result in a null-pointer
error, as they correspond to the field names in Elasticsearch which he didn't
change. Therefore, I changed it back for the time being as these filed names
are used explicitly at many places.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] Yongyao commented on a change in pull request #7: SDAP-35 Overhaul MUDROD configuration
Yongyao commented on a change in pull request #7: SDAP-35 Overhaul MUDROD
configuration
URL:
https://github.com/apache/incubator-sdap-mudrod/pull/7#discussion_r173500638
##
File path:
core/src/main/java/org/apache/sdap/mudrod/weblog/structure/ApacheAccessLog.java
##
@@ -15,55 +15,49 @@
import com.google.gson.Gson;
+import org.apache.sdap.mudrod.main.MudrodConstants;
+import org.apache.sdap.mudrod.weblog.pre.CrawlerDetection;
+
import java.io.IOException;
import java.io.Serializable;
import java.text.ParseException;
import java.text.SimpleDateFormat;
import java.util.Date;
+import java.util.Properties;
import java.util.regex.Matcher;
import java.util.regex.Pattern;
-import org.apache.sdap.mudrod.weblog.pre.CrawlerDetection;
-
/**
* This class represents an Apache access log line. See
* http://httpd.apache.org/docs/2.2/logs.html for more details.
*/
public class ApacheAccessLog extends WebLog implements Serializable {
-
-
- /**
- *
- */
- private static final long serialVersionUID = 1L;
-
- public ApacheAccessLog() {
-//default constructor
- }
-
- String response;
- String referer;
- String browser;
+ String Response;
Review comment:
I suggest creating a new issue about lower/upper case. If I just change them
to lower case here, lots of other code will be affected
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] Yongyao commented on a change in pull request #7: SDAP-35 Overhaul MUDROD configuration
Yongyao commented on a change in pull request #7: SDAP-35 Overhaul MUDROD
configuration
URL:
https://github.com/apache/incubator-sdap-mudrod/pull/7#discussion_r173500190
##
File path:
core/src/main/java/org/apache/sdap/mudrod/metadata/pre/ApiHarvester.java
##
@@ -57,7 +57,8 @@ public Object execute() {
//remove old metadata from ES
es.deleteType(props.getProperty(MudrodConstants.ES_INDEX_NAME),
props.getProperty(MudrodConstants.RAW_METADATA_TYPE));
//harvest new metadata using PO.DAAC web services
-harvestMetadatafromWeb();
+if(props.getProperty(MudrodConstants.METADATA_DOWNLOAD).equals("1"))
Review comment:
Could you explain the difference? The results looks the same to me.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] Yongyao commented on a change in pull request #7: SDAP-35 Overhaul MUDROD configuration
Yongyao commented on a change in pull request #7: SDAP-35 Overhaul MUDROD
configuration
URL:
https://github.com/apache/incubator-sdap-mudrod/pull/7#discussion_r173499832
##
File path:
core/src/main/java/org/apache/sdap/mudrod/integration/LinkageIntegration.java
##
@@ -173,32 +171,32 @@ public JsonObject getIngeratedListInJson(String input) {
* the similarities from different sources
*/
public Map>
aggregateRelatedTermsFromAllmodel(String input) {
-aggregateRelatedTerms(input, props.getProperty("userHistoryLinkageType"));
-aggregateRelatedTerms(input, props.getProperty("clickStreamLinkageType"));
-aggregateRelatedTerms(input, props.getProperty("metadataLinkageType"));
-aggregateRelatedTermsSWEET(input,
props.getProperty("ontologyLinkageType"));
+aggregateRelatedTerms(input, MudrodConstants.USE_HISTORY_LINKAGE_TYPE);
Review comment:
This variable is not in the conf.properties file. It is just a constant.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
