Re: Review Request 67174: SENTRY-2156: Update provider-db backend code to grant privileges to user

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67174/#review203769 --- Ship it! Thanks Lina. - Sergio Pena On May 24, 2018, 12:03

Re: Review Request 67174: SENTRY-2156: Update provider-db backend code to grant privileges to user

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67174/ --- (Updated May 24, 2018, 12:03 a.m.) Review request for sentry, Alexander

Re: Review Request 67174: SENTRY-2156: Update provider-db backend code to grant privileges to user

> On May 23, 2018, 5:03 p.m., Sergio Pena wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Lines 852-860 (patched) > > > > > > Lina,

Re: Review Request 67174: SENTRY-2156: Update provider-db backend code to grant privileges to user

> On May 23, 2018, 5:09 p.m., Sergio Pena wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Lines 785-788 (original), 897-905 (patched) > >

Re: Review Request 67174: SENTRY-2156: Update provider-db backend code to grant privileges to user

> On May 22, 2018, 10:29 p.m., Sergio Pena wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Lines 801-812 (patched) > > > > > > This

Re: Review Request 67174: SENTRY-2156: Update provider-db backend code to grant privileges to user

> On May 17, 2018, 10:22 p.m., Sergio Pena wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/QueryParamBuilder.java > > Lines 303 (patched) > > > > > >

Re: Review Request 67174: SENTRY-2156: Update provider-db backend code to grant privileges to user

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67174/#review203598 ---

Re: Review Request 67174: SENTRY-2156: Update provider-db backend code to grant privileges to user

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67174/#review203669 ---

Re: Review Request 67174: SENTRY-2156: Update provider-db backend code to grant privileges to user

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67174/#review203668 ---

Re: Review Request 67174: SENTRY-2156: Update provider-db backend code to grant privileges to user

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67174/#review203600 ---

Re: Review Request 67174: SENTRY-2156: Update provider-db backend code to grant privileges to user

> On May 17, 2018, 10:22 p.m., Sergio Pena wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Lines 4336 (patched) > > > > > >

Re: Review Request 67174: SENTRY-2156: Update provider-db backend code to grant privileges to user

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67174/ --- (Updated May 21, 2018, 10:48 p.m.) Review request for sentry, Alexander

Re: Review Request 67174: SENTRY-2156: Update provider-db backend code to grant privileges to user

> On May 17, 2018, 10:22 p.m., Sergio Pena wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Lines 172-173 (original), 176-178 (patched) > >

Re: Review Request 67174: SENTRY-2156: Update provider-db backend code to grant privileges to user

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67174/ --- (Updated May 21, 2018, 10:22 p.m.) Review request for sentry, Alexander

Re: Review Request 67174: SENTRY-2156: Update provider-db backend code to grant privileges to user

> On May 17, 2018, 10:22 p.m., Sergio Pena wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Lines 4336 (patched) > > > > > >

Re: Review Request 67174: SENTRY-2156: Update provider-db backend code to grant privileges to user

> On May 17, 2018, 4:06 p.m., kalyan kumar kalvagadda wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Lines 169-173 (original), 171-178 (patched) > >

Re: Review Request 67174: SENTRY-2156: Update provider-db backend code to grant privileges to user

> On May 17, 2018, 10:22 p.m., Sergio Pena wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java > > Lines 1054 (patched) > > > > > > Don't

Re: Review Request 67174: SENTRY-2156: Update provider-db backend code to grant privileges to user

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67174/ --- (Updated May 18, 2018, 3:27 p.m.) Review request for sentry, Alexander

Re: Review Request 67174: SENTRY-2156: Update provider-db backend code to grant privileges to user

> On May 17, 2018, 2:45 p.m., Arjun Mishra wrote: > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/service/common/ServiceConstants.java > > Lines 253 (patched) > > > > > > Can we also have a type

Re: Review Request 67174: SENTRY-2156: Update provider-db backend code to grant privileges to user

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67174/#review203371 ---

Re: Review Request 67174: SENTRY-2156: Update provider-db backend code to grant privileges to user

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67174/ --- (Updated May 17, 2018, 9:41 p.m.) Review request for sentry, Alexander

Re: Review Request 67174: SENTRY-2156: Update provider-db backend code to grant privileges to user

> On May 17, 2018, 9:40 a.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/QueryParamBuilder.java > > Lines 303 (patched) > > > > > >

Re: Review Request 67174: SENTRY-2156: Update provider-db backend code to grant privileges to user

> On May 17, 2018, 4:06 p.m., kalyan kumar kalvagadda wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Lines 169-173 (original), 171-178 (patched) > >

Re: Review Request 67174: SENTRY-2156: Update provider-db backend code to grant privileges to user

> On May 17, 2018, 12:36 p.m., kalyan kumar kalvagadda wrote: > > In general note can't you seperate patches for below? > > 1.Add functions related to grant/revoke privileges to/from user > > 2.Fix the bugs related to grant/revoke partial privileges. They are caused > > by adding fine grained

Re: Review Request 67174: SENTRY-2156: Update provider-db backend code to grant privileges to user

> On May 17, 2018, 2:45 p.m., Arjun Mishra wrote: > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/service/common/ServiceConstants.java > > Lines 253 (patched) > > > > > > Can we also have a type

Re: Review Request 67174: SENTRY-2156: Update provider-db backend code to grant privileges to user

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67174/#review203329 ---

Re: Review Request 67174: SENTRY-2156: Update provider-db backend code to grant privileges to user

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67174/#review203312 ---

Re: Review Request 67174: SENTRY-2156: Update provider-db backend code to grant privileges to user

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67174/#review203327 --- In general note can't you seperate patches for below? 1.Add

Re: Review Request 67174: SENTRY-2156: Update provider-db backend code to grant privileges to user

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67174/#review203319 ---