Re: Review Request 52138: SENTRY-1463: Ensure HMS point-in-time snapshot consistency

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52138/#review153758 --- Ship it! Ship It! - Sravya Tirukkovalur On Oct. 24, 2016,

Re: Review Request 52138: SENTRY-1463: Ensure HMS point-in-time snapshot consistency

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52138/ --- (Updated Oct. 24, 2016, 11:25 p.m.) Review request for sentry, Alexander

Re: Review Request 52138: SENTRY-1463: Ensure HMS point-in-time snapshot consistency

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52138/#review152452 --- Ship it! Just one small nit with logging. - Alexander

Re: Review Request 52138: SENTRY-1463: Ensure HMS point-in-time snapshot consistency

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52138/#review152450 ---

Re: Review Request 52138: SENTRY-1463: Ensure HMS point-in-time snapshot consistency

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52138/#review152377 --- Can we add a comment that, this is a workaround until HIVE-14906

Re: Review Request 52138: SENTRY-1463: Ensure HMS point-in-time snapshot consistency

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52138/#review152359 --- Ship it! Ship It! - Li Li On Oct. 12, 2016, 7:15 a.m., Hao

Re: Review Request 52138: SENTRY-1463: Ensure HMS point-in-time snapshot consistency

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52138/ --- (Updated Oct. 12, 2016, 7:15 a.m.) Review request for sentry, Alexander

Re: Review Request 52138: SENTRY-1463: Ensure HMS point-in-time snapshot consistency

> On Oct. 7, 2016, 12:56 a.m., Sravya Tirukkovalur wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java, > > line 77 > > > > > > Shall we name this as

Re: Review Request 52138: SENTRY-1463: Ensure HMS point-in-time snapshot consistency

> On Oct. 11, 2016, 6:20 p.m., Li Li wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java, > > line 77 > > > > > > I think we should set fullUpdateComplete to

Re: Review Request 52138: SENTRY-1463: Ensure HMS point-in-time snapshot consistency

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52138/#review152171 ---

Re: Review Request 52138: SENTRY-1463: Ensure HMS point-in-time snapshot consistency

> On Sept. 24, 2016, 11:59 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java, > > lines 215-216 > > > > > > fullUpdateComplete

Re: Review Request 52138: SENTRY-1463: Ensure HMS point-in-time snapshot consistency

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52138/ --- (Updated Oct. 6, 2016, 10:22 p.m.) Review request for sentry, Alexander

Re: Review Request 52138: SENTRY-1463: Ensure HMS point-in-time snapshot consistency

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52138/ --- (Updated Oct. 4, 2016, 11:18 p.m.) Review request for sentry, Alexander

Re: Review Request 52138: SENTRY-1463: Ensure HMS point-in-time snapshot consistency

> On Sept. 23, 2016, 4:41 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java, > > lines 239-257 > > > > > > Are there any

Re: Review Request 52138: SENTRY-1463: Ensure HMS point-in-time snapshot consistency

> On Sept. 24, 2016, 11:59 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java, > > lines 215-216 > > > > > > fullUpdateComplete

Re: Review Request 52138: SENTRY-1463: Ensure HMS point-in-time snapshot consistency

> On Oct. 4, 2016, 6:44 a.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java, > > lines 130-135 > > > > > > So this isn't

Re: Review Request 52138: SENTRY-1463: Ensure HMS point-in-time snapshot consistency

> On Sept. 24, 2016, 11:59 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java, > > lines 215-216 > > > > > > fullUpdateComplete

Re: Review Request 52138: SENTRY-1463: Ensure HMS point-in-time snapshot consistency

> On Sept. 23, 2016, 4:41 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java, > > lines 239-257 > > > > > > should it be an

Re: Review Request 52138: SENTRY-1463: Ensure HMS point-in-time snapshot consistency

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52138/#review150322 ---

Re: Review Request 52138: SENTRY-1463: Ensure HMS point-in-time snapshot consistency

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52138/#review150297 ---

Re: Review Request 52138: SENTRY-1463: Ensure HMS point-in-time snapshot consistency

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52138/#review150295 ---

Re: Review Request 52138: SENTRY-1463: Ensure HMS point-in-time snapshot consistency

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52138/#review150197 ---

Re: Review Request 52138: SENTRY-1463: Ensure HMS point-in-time snapshot consistency

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52138/#review150190 --- Ship it! Ship It! - Li Li On Sept. 23, 2016, 6:15 a.m., Hao

Re: Review Request 52138: SENTRY-1463: Ensure HMS point-in-time snapshot consistency

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52138/ --- (Updated Sept. 23, 2016, 6:15 a.m.) Review request for sentry, Alexander

Re: Review Request 52138: SENTRY-1463: Ensure HMS point-in-time snapshot consistency

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52138/#review150116 ---

Re: Review Request 52138: SENTRY-1463: Ensure HMS point-in-time snapshot consistency

> On Sept. 22, 2016, 12:39 a.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java, > > line 212 > > > > > > Is the TODO: read

Re: Review Request 52138: SENTRY-1463: Ensure HMS point-in-time snapshot consistency

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52138/#review150070 ---

Re: Review Request 52138: SENTRY-1463: Ensure HMS point-in-time snapshot consistency

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52138/ --- (Updated Sept. 21, 2016, 11:47 p.m.) Review request for sentry and Sravya

Review Request 52138: SENTRY-1463: Ensure HMS point-in-time snapshot consistency

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52138/ --- Review request for sentry and Sravya Tirukkovalur. Repository: sentry