[GitHub] yhs0092 opened a new pull request #568: [SCB-352] Support provider operation level flow control

2018-03-05 Thread GitBox
yhs0092 opened a new pull request #568: [SCB-352] Support provider operation level flow control URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/568 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a

[GitHub] asifdxtreme commented on a change in pull request #295: [SCB-367] Fix LICENSE and NOTICE issue

2018-03-05 Thread GitBox
asifdxtreme commented on a change in pull request #295: [SCB-367] Fix LICENSE and NOTICE issue URL: https://github.com/apache/incubator-servicecomb-service-center/pull/295#discussion_r172115308 ## File path: NOTICE ## @@ -3,276 +3,3 @@ Copyright 2017-2018 The Apache

[GitHub] WillemJiang closed pull request #142: SCB-346 Create the distribution kit for Saga

2018-03-05 Thread GitBox
WillemJiang closed pull request #142: SCB-346 Create the distribution kit for Saga URL: https://github.com/apache/incubator-servicecomb-saga/pull/142 This is an automated message from the Apache Git Service. To respond to

[GitHub] yangbor opened a new pull request #571: [SCB-260] Correct LICENSE/NOTICE for src/binary release

2018-03-05 Thread GitBox
yangbor opened a new pull request #571: [SCB-260] Correct LICENSE/NOTICE for src/binary release URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/571 Use different set of LICENCE/NOTICE files for src/binary release. Also modified the distribution module to pack both

[Discussion] Saga API design

2018-03-05 Thread Eric Lee
Hi, all Currently, we encounter some problems in implementing forward recovery in saga. If we use synchronous API, the error code will respond immediately if any exception throws. However, the transaction still goes on until it's done. It may lead to bad experience to the user as user may see

[GitHub] lijasonvip opened a new pull request #569: SCB-210 remove extra useless config item

2018-03-05 Thread GitBox
lijasonvip opened a new pull request #569: SCB-210 remove extra useless config item URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/569 Signed-off-by: lijasonvip Follow this checklist to help us incorporate your contribution quickly and

[GitHub] WillemJiang commented on a change in pull request #571: [SCB-260] Correct LICENSE/NOTICE for src/binary release

2018-03-05 Thread GitBox
WillemJiang commented on a change in pull request #571: [SCB-260] Correct LICENSE/NOTICE for src/binary release URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/571#discussion_r172165858 ## File path: java-chassis-distribution/src/release/LICENSE ##

[GitHub] wujimin opened a new pull request #570: SCB-360 write simpler eventBus to optimize performance

2018-03-05 Thread GitBox
wujimin opened a new pull request #570: SCB-360 write simpler eventBus to optimize performance URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/570 IDE compile warnings check:

[GitHub] WillemJiang commented on a change in pull request #571: [SCB-260] Correct LICENSE/NOTICE for src/binary release

2018-03-05 Thread GitBox
WillemJiang commented on a change in pull request #571: [SCB-260] Correct LICENSE/NOTICE for src/binary release URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/571#discussion_r172165023 ## File path: java-chassis-distribution/src/release/NOTICE ##

[GitHub] asifdxtreme closed pull request #295: [SCB-367] Fix LICENSE and NOTICE issue

2018-03-05 Thread GitBox
asifdxtreme closed pull request #295: [SCB-367] Fix LICENSE and NOTICE issue URL: https://github.com/apache/incubator-servicecomb-service-center/pull/295 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] asifdxtreme opened a new pull request #143: Cut 1.0.0-m1 Release

2018-03-05 Thread GitBox
asifdxtreme opened a new pull request #143: Cut 1.0.0-m1 Release URL: https://github.com/apache/incubator-servicecomb-saga/pull/143 Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA

[GitHub] liubao68 commented on a change in pull request #570: SCB-360 write simpler eventBus to optimize performance

2018-03-05 Thread GitBox
liubao68 commented on a change in pull request #570: SCB-360 write simpler eventBus to optimize performance URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/570#discussion_r172182357 ## File path:

[GitHub] WillemJiang commented on a change in pull request #143: Cut 1.0.0-m1 Release

2018-03-05 Thread GitBox
WillemJiang commented on a change in pull request #143: Cut 1.0.0-m1 Release URL: https://github.com/apache/incubator-servicecomb-saga/pull/143#discussion_r172200445 ## File path: acceptance-tests/acceptance-pack/pom.xml ## @@ -22,7 +22,7 @@ acceptance-tests

[GitHub] WillemJiang commented on a change in pull request #143: Cut 1.0.0-m1 Release

2018-03-05 Thread GitBox
WillemJiang commented on a change in pull request #143: Cut 1.0.0-m1 Release URL: https://github.com/apache/incubator-servicecomb-saga/pull/143#discussion_r172200445 ## File path: acceptance-tests/acceptance-pack/pom.xml ## @@ -22,7 +22,7 @@ acceptance-tests

[GitHub] WillemJiang commented on a change in pull request #143: Cut 1.0.0-m1 Release

2018-03-05 Thread GitBox
WillemJiang commented on a change in pull request #143: Cut 1.0.0-m1 Release URL: https://github.com/apache/incubator-servicecomb-saga/pull/143#discussion_r172200159 ## File path: .travis.settings.xml ## @@ -24,4 +24,14 @@ ${env.SONATYPE_PASSWORD} +

[GitHub] coveralls commented on issue #143: SCB-346 Prepare 1.0.0-m1 release

2018-03-05 Thread GitBox
coveralls commented on issue #143: SCB-346 Prepare 1.0.0-m1 release URL: https://github.com/apache/incubator-servicecomb-saga/pull/143#issuecomment-370440772 [![Coverage Status](https://coveralls.io/builds/15810745/badge)](https://coveralls.io/builds/15810745) Coverage remained

[GitHub] liubao68 commented on a change in pull request #570: SCB-360 write simpler eventBus to optimize performance

2018-03-05 Thread GitBox
liubao68 commented on a change in pull request #570: SCB-360 write simpler eventBus to optimize performance URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/570#discussion_r172178676 ## File path: foundations/foundation-common/pom.xml ## @@ -16,65

[GitHub] coveralls commented on issue #144: SCB-346 Add third party licenses

2018-03-05 Thread GitBox
coveralls commented on issue #144: SCB-346 Add third party licenses URL: https://github.com/apache/incubator-servicecomb-saga/pull/144#issuecomment-370650512 [![Coverage Status](https://coveralls.io/builds/15822745/badge)](https://coveralls.io/builds/15822745) Coverage remained

[GitHub] wujimin commented on a change in pull request #570: SCB-360 write simpler eventBus to optimize performance

2018-03-05 Thread GitBox
wujimin commented on a change in pull request #570: SCB-360 write simpler eventBus to optimize performance URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/570#discussion_r172360772 ## File path: foundations/foundation-common/pom.xml ## @@ -16,65

[GitHub] wujimin commented on a change in pull request #570: SCB-360 write simpler eventBus to optimize performance

2018-03-05 Thread GitBox
wujimin commented on a change in pull request #570: SCB-360 write simpler eventBus to optimize performance URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/570#discussion_r172399613 ## File path:

[GitHub] WillemJiang commented on a change in pull request #571: [SCB-260] Correct LICENSE/NOTICE for src/binary release

2018-03-05 Thread GitBox
WillemJiang commented on a change in pull request #571: [SCB-260] Correct LICENSE/NOTICE for src/binary release URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/571#discussion_r172381684 ## File path: NOTICE ## @@ -1,142 +1,5 @@ -Apache ServiceComb

[GitHub] wujimin commented on issue #567: [SCB-365]when configured ssl certificates not exists, startup will hang and no error messages

2018-03-05 Thread GitBox
wujimin commented on issue #567: [SCB-365]when configured ssl certificates not exists, startup will hang and no error messages URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/567#issuecomment-370636920 submit a vertx issue, waiting for response.

[GitHub] WillemJiang closed pull request #143: SCB-346 Prepare 1.0.0-m1 release

2018-03-05 Thread GitBox
WillemJiang closed pull request #143: SCB-346 Prepare 1.0.0-m1 release URL: https://github.com/apache/incubator-servicecomb-saga/pull/143 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] wujimin commented on a change in pull request #569: SCB-210 remove extra useless config item

2018-03-05 Thread GitBox
wujimin commented on a change in pull request #569: SCB-210 remove extra useless config item URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/569#discussion_r172390924 ## File path:

[GitHub] wujimin commented on a change in pull request #570: SCB-360 write simpler eventBus to optimize performance

2018-03-05 Thread GitBox
wujimin commented on a change in pull request #570: SCB-360 write simpler eventBus to optimize performance URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/570#discussion_r172361062 ## File path:

[GitHub] yangbor opened a new pull request #144: SCB-346 Add third party licenses

2018-03-05 Thread GitBox
yangbor opened a new pull request #144: SCB-346 Add third party licenses URL: https://github.com/apache/incubator-servicecomb-saga/pull/144 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA

[GitHub] wujimin commented on a change in pull request #570: SCB-360 write simpler eventBus to optimize performance

2018-03-05 Thread GitBox
wujimin commented on a change in pull request #570: SCB-360 write simpler eventBus to optimize performance URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/570#discussion_r172390425 ## File path: foundations/foundation-common/pom.xml ## @@ -16,65

[GitHub] coveralls commented on issue #144: SCB-346 Add third party licenses

2018-03-05 Thread GitBox
coveralls commented on issue #144: SCB-346 Add third party licenses URL: https://github.com/apache/incubator-servicecomb-saga/pull/144#issuecomment-370650512 [![Coverage Status](https://coveralls.io/builds/15822689/badge)](https://coveralls.io/builds/15822689) Coverage

[GitHub] lijasonvip commented on a change in pull request #569: SCB-210 remove extra useless config item

2018-03-05 Thread GitBox
lijasonvip commented on a change in pull request #569: SCB-210 remove extra useless config item URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/569#discussion_r172424150 ## File path:

[GitHub] liubao68 commented on a change in pull request #570: SCB-360 write simpler eventBus to optimize performance

2018-03-05 Thread GitBox
liubao68 commented on a change in pull request #570: SCB-360 write simpler eventBus to optimize performance URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/570#discussion_r172426922 ## File path:

[GitHub] liubao68 commented on a change in pull request #568: [SCB-352] Support provider operation level flow control

2018-03-05 Thread GitBox
liubao68 commented on a change in pull request #568: [SCB-352] Support provider operation level flow control URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/568#discussion_r172427781 ## File path:

Re: [Discussion] Saga API design

2018-03-05 Thread Eric Lee
Well, supposed we have such a simple scenario, A --> B If we apply forward recovery in this scenario, when sub-transaction B fails in the first time, it will return an error immediately to A. Hence, A can not be notified the results of B's retry operation and can not continue to process its later

[GitHub] liubao68 commented on issue #567: [SCB-365]when configured ssl certificates not exists, startup will hang and no error messages

2018-03-05 Thread GitBox
liubao68 commented on issue #567: [SCB-365]when configured ssl certificates not exists, startup will hang and no error messages URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/567#issuecomment-370690055 @wujimin can you provide issue link? And I think this

[GitHub] WillemJiang commented on a change in pull request #144: SCB-346 Add third party licenses

2018-03-05 Thread GitBox
WillemJiang commented on a change in pull request #144: SCB-346 Add third party licenses URL: https://github.com/apache/incubator-servicecomb-saga/pull/144#discussion_r172415647 ## File path: saga-distribution/src/release/LICENSE ## @@ -201,3 +201,283 @@ limitations

Re: [Discussion] Saga API design

2018-03-05 Thread Zheng Feng
Can you describe the details when we doing the forward recovery currently please ? 2018-03-05 19:32 GMT+08:00 Eric Lee : > Hi, all > > Currently, we encounter some problems in implementing forward recovery in > saga. If we use synchronous API, the error code will

[GitHub] liubao68 commented on a change in pull request #568: [SCB-352] Support provider operation level flow control

2018-03-05 Thread GitBox
liubao68 commented on a change in pull request #568: [SCB-352] Support provider operation level flow control URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/568#discussion_r172423155 ## File path:

[GitHub] wujimin commented on issue #567: [SCB-365]when configured ssl certificates not exists, startup will hang and no error messages

2018-03-05 Thread GitBox
wujimin commented on issue #567: [SCB-365]when configured ssl certificates not exists, startup will hang and no error messages URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/567#issuecomment-370693108 https://github.com/eclipse/vert.x/issues/2331 already

[GitHub] liubao68 commented on a change in pull request #570: SCB-360 write simpler eventBus to optimize performance

2018-03-05 Thread GitBox
liubao68 commented on a change in pull request #570: SCB-360 write simpler eventBus to optimize performance URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/570#discussion_r172427251 ## File path:

[GitHub] liubao68 commented on a change in pull request #568: [SCB-352] Support provider operation level flow control

2018-03-05 Thread GitBox
liubao68 commented on a change in pull request #568: [SCB-352] Support provider operation level flow control URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/568#discussion_r172427781 ## File path: