[GitHub] wujimin commented on a change in pull request #648: [SCB-482] Http2 support for java-chassis

wujimin commented on a change in pull request #648: [SCB-482] Http2 support for java-chassis URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/648#discussion_r186154112 ## File path:

[GitHub] wenj91 opened a new pull request #184: (#182 )update the length of field serviceName from varchar(16) to varchar(36)

wenj91 opened a new pull request #184: (#182 )update the length of field serviceName from varchar(16) to varchar(36) URL: https://github.com/apache/incubator-servicecomb-saga/pull/184 (#182 )update the length of field serviceName from varchar(16) to varchar(36) Follow this checklist

[GitHub] wujimin commented on a change in pull request #648: [SCB-482] Http2 support for java-chassis

wujimin commented on a change in pull request #648: [SCB-482] Http2 support for java-chassis URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/648#discussion_r186153321 ## File path:

[GitHub] wujimin commented on a change in pull request #678: [SCB-506]服务治理相关的需要事件上报

wujimin commented on a change in pull request #678: [SCB-506]服务治理相关的需要事件上报 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/678#discussion_r186251016 ## File path: handlers/handler-bizkeeper/src/main/java/org/apache/servicecomb/bizkeeper/BizkeeperHandler.java

[GitHub] coveralls commented on issue #690: [SCB-529] producer download file from byte[]

coveralls commented on issue #690: [SCB-529] producer download file from byte[] URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/690#issuecomment-386776381 [](https://coveralls.io/builds/16846112)

[GitHub] wujimin commented on a change in pull request #678: [SCB-506]服务治理相关的需要事件上报

wujimin commented on a change in pull request #678: [SCB-506]服务治理相关的需要事件上报 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/678#discussion_r186250923 ## File path:

[GitHub] wujimin commented on a change in pull request #678: [SCB-506]服务治理相关的需要事件上报

wujimin commented on a change in pull request #678: [SCB-506]服务治理相关的需要事件上报 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/678#discussion_r186250938 ## File path: handlers/handler-bizkeeper/src/main/java/org/apache/servicecomb/bizkeeper/BizkeeperHandler.java

[GitHub] wujimin commented on a change in pull request #678: [SCB-506]服务治理相关的需要事件上报

wujimin commented on a change in pull request #678: [SCB-506]服务治理相关的需要事件上报 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/678#discussion_r186251088 ## File path:

[GitHub] wujimin commented on a change in pull request #678: [SCB-506]服务治理相关的需要事件上报

wujimin commented on a change in pull request #678: [SCB-506]服务治理相关的需要事件上报 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/678#discussion_r186251045 ## File path:

[GitHub] wujimin commented on a change in pull request #678: [SCB-506]服务治理相关的需要事件上报

wujimin commented on a change in pull request #678: [SCB-506]服务治理相关的需要事件上报 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/678#discussion_r186251122 ## File path:

[GitHub] wenj91 closed issue #182: ERROR: value too long for type character varying(16)

wenj91 closed issue #182: ERROR: value too long for type character varying(16) URL: https://github.com/apache/incubator-servicecomb-saga/issues/182 This is an automated message from the Apache Git Service. To respond to the

[GitHub] WillemJiang commented on issue #184: SCB-545 (#182 )update the length of field serviceName from varchar(16) to varchar(36)

WillemJiang commented on issue #184: SCB-545 (#182 )update the length of field serviceName from varchar(16) to varchar(36) URL: https://github.com/apache/incubator-servicecomb-saga/pull/184#issuecomment-386762049 Thanks for the help @wenj91.

[GitHub] WillemJiang closed pull request #184: SCB-545 (#182 )update the length of field serviceName from varchar(16) to varchar(36)

WillemJiang closed pull request #184: SCB-545 (#182 )update the length of field serviceName from varchar(16) to varchar(36) URL: https://github.com/apache/incubator-servicecomb-saga/pull/184 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is

[GitHub] WillemJiang commented on issue #183: Can i use feign and saga in project ?

WillemJiang commented on issue #183: Can i use feign and saga in project ? URL: https://github.com/apache/incubator-servicecomb-saga/issues/183#issuecomment-386542714 Hi, I don't think this is a related issue, but I will try to run the demo myself.

[GitHub] wujimin opened a new pull request #689: [SCB-538] Create SwaggerToClassGenerator

wujimin opened a new pull request #689: [SCB-538] Create SwaggerToClassGenerator URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/689 preparing for create recursive dependency class javassist can create normal dynamic class to classloader but can not create

[GitHub] xuyiyun0929 commented on a change in pull request #678: [SCB-506]服务治理相关的需要事件上报

xuyiyun0929 commented on a change in pull request #678: [SCB-506]服务治理相关的需要事件上报 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/678#discussion_r186033593 ## File path:

[GitHub] WillemJiang commented on issue #182: ERROR: value too long for type character varying(16)

WillemJiang commented on issue #182: ERROR: value too long for type character varying(16) URL: https://github.com/apache/incubator-servicecomb-saga/issues/182#issuecomment-386550256 I just checked the

[GitHub] xuyiyun0929 commented on a change in pull request #678: [SCB-506]服务治理相关的需要事件上报

xuyiyun0929 commented on a change in pull request #678: [SCB-506]服务治理相关的需要事件上报 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/678#discussion_r18607 ## File path:

[GitHub] zhengyangyong commented on issue #685: 怎样平滑关闭Client？

zhengyangyong commented on issue #685: 怎样平滑关闭Client？ URL: https://github.com/apache/incubator-servicecomb-java-chassis/issues/685#issuecomment-386518420 I think you can try this step: ```java //this code will Unregister microservice instance from ServiceCenter

[GitHub] yangbor commented on a change in pull request #181: [SCB-342] Add TLS support for gRPC

yangbor commented on a change in pull request #181: [SCB-342] Add TLS support for gRPC URL: https://github.com/apache/incubator-servicecomb-saga/pull/181#discussion_r186001444 ## File path:

[GitHub] yangbor commented on a change in pull request #181: [SCB-342] Add TLS support for gRPC

yangbor commented on a change in pull request #181: [SCB-342] Add TLS support for gRPC URL: https://github.com/apache/incubator-servicecomb-saga/pull/181#discussion_r186001438 ## File path:

[GitHub] zhengyangyong opened a new pull request #77: Add Notes for providers and fix FAQ mistakes

zhengyangyong opened a new pull request #77: Add Notes for providers and fix FAQ mistakes URL: https://github.com/apache/incubator-servicecomb-website/pull/77 Signed-off-by: zhengyangyong 在编程模型文档中增加注意事项说明，并且修复FAQ中这方面错误的说法。

[GitHub] zhengyangyong opened a new pull request #76: Add Notes for providers and fix FAQ mistakes

zhengyangyong opened a new pull request #76: Add Notes for providers and fix FAQ mistakes URL: https://github.com/apache/incubator-servicecomb-website/pull/76 在编程模型文档中增加注意事项说明，并且修复FAQ中这方面错误的说法。 This is an automated message

[GitHub] wenj91 commented on issue #182: ERROR: value too long for type character varying(16)

wenj91 commented on issue #182: ERROR: value too long for type character varying(16) URL: https://github.com/apache/incubator-servicecomb-saga/issues/182#issuecomment-386572542 this file is 16

[GitHub] wenj91 commented on issue #182: ERROR: value too long for type character varying(16)

wenj91 commented on issue #182: ERROR: value too long for type character varying(16) URL: https://github.com/apache/incubator-servicecomb-saga/issues/182#issuecomment-386613188 sure, i will do it tonight This is an

[GitHub] xuyiyun0929 commented on a change in pull request #678: [SCB-506]服务治理相关的需要事件上报

xuyiyun0929 commented on a change in pull request #678: [SCB-506]服务治理相关的需要事件上报 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/678#discussion_r186032008 ## File path:

[GitHub] WillemJiang commented on a change in pull request #77: Add Notes for providers and fix FAQ mistakes

WillemJiang commented on a change in pull request #77: Add Notes for providers and fix FAQ mistakes URL: https://github.com/apache/incubator-servicecomb-website/pull/77#discussion_r186083950 ## File path: _users/cn/develop-with-transparent-rpc.md ## @@ -130,6 +137,10 @@

[GitHub] wenj91 commented on issue #179: Wenj91 saga branch test

wenj91 commented on issue #179: Wenj91 saga branch test URL: https://github.com/apache/incubator-servicecomb-saga/pull/179#issuecomment-386627170 感谢，这个分支我已经看过了，我自己也调整了自己的代码，现在测试暂时没什么大问题 This is an automated message from the

[GitHub] yangbor commented on a change in pull request #181: [SCB-342] Add TLS support for gRPC

yangbor commented on a change in pull request #181: [SCB-342] Add TLS support for gRPC URL: https://github.com/apache/incubator-servicecomb-saga/pull/181#discussion_r186001406 ## File path: alpha/alpha-server/src/main/resources/application.yaml ## @@ -17,6 +17,16 @@

[GitHub] WillemJiang commented on a change in pull request #181: [SCB-342] Add TLS support for gRPC

WillemJiang commented on a change in pull request #181: [SCB-342] Add TLS support for gRPC URL: https://github.com/apache/incubator-servicecomb-saga/pull/181#discussion_r186000533 ## File path: alpha/alpha-server/src/main/resources/application.yaml ## @@ -17,6 +17,16 @@

[GitHub] yangbor commented on a change in pull request #181: [SCB-342] Add TLS support for gRPC

yangbor commented on a change in pull request #181: [SCB-342] Add TLS support for gRPC URL: https://github.com/apache/incubator-servicecomb-saga/pull/181#discussion_r185999175 ## File path:

[GitHub] yangbor commented on a change in pull request #181: [SCB-342] Add TLS support for gRPC

yangbor commented on a change in pull request #181: [SCB-342] Add TLS support for gRPC URL: https://github.com/apache/incubator-servicecomb-saga/pull/181#discussion_r185999175 ## File path:

[GitHub] WillemJiang commented on issue #678: [SCB-506]服务治理相关的需要事件上报

WillemJiang commented on issue #678: [SCB-506]服务治理相关的需要事件上报 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/678#issuecomment-386518520 @xuyiyun0929 Could you take a look at the review messages of wujimin?

[GitHub] zhengyangyong commented on issue #685: 怎样平滑关闭Client？

zhengyangyong commented on issue #685: 怎样平滑关闭Client？ URL: https://github.com/apache/incubator-servicecomb-java-chassis/issues/685#issuecomment-386518420 I think you can try this step: ```java //this code will Unregister microservice instance from ServiceCenter

[GitHub] JokerLoveAllen commented on issue #183: Can i use feign and saga in project ?

JokerLoveAllen commented on issue #183: Can i use feign and saga in project ? URL: https://github.com/apache/incubator-servicecomb-saga/issues/183#issuecomment-386521705 The result of running saga-demo is wrong, soga is not executed correctly.The car's 'cancelled' state does not become