[
https://issues.apache.org/jira/browse/SLING-9469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17115788#comment-17115788
]
Darshan Mahor commented on SLING-9469:
--
PR:
darshanmahor24 opened a new pull request #54:
URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/54
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
saurabh-khare commented on a change in pull request #1:
URL:
https://github.com/apache/sling-org-apache-sling-superimposing/pull/1#discussion_r429750172
##
File path: pom.xml
##
@@ -43,77 +42,203 @@
-
+
-
saurabh-khare commented on pull request #1:
URL:
https://github.com/apache/sling-org-apache-sling-superimposing/pull/1#issuecomment-633403991
All suggested changes are resolved.
This is an automated message from the Apache
Carsten Ziegeler created SLING-9468:
---
Summary: Wrong artifact id for apis jars
Key: SLING-9468
URL: https://issues.apache.org/jira/browse/SLING-9468
Project: Sling
Issue Type: Bug
saurabh-khare commented on a change in pull request #1:
URL:
https://github.com/apache/sling-org-apache-sling-superimposing/pull/1#discussion_r429749856
##
File path: pom.xml
##
@@ -43,77 +42,203 @@
-
+
-
saurabh-khare commented on a change in pull request #1:
URL:
https://github.com/apache/sling-org-apache-sling-superimposing/pull/1#discussion_r429749762
##
File path: pom.xml
##
@@ -43,77 +42,203 @@
-
+
-
saurabh-khare commented on a change in pull request #1:
URL:
https://github.com/apache/sling-org-apache-sling-superimposing/pull/1#discussion_r429749926
##
File path: pom.xml
##
@@ -25,8 +25,7 @@
org.apache.sling.superimposing
-0.2.1-SNAPSHOT
-bundle
+
saurabh-khare commented on a change in pull request #1:
URL:
https://github.com/apache/sling-org-apache-sling-superimposing/pull/1#discussion_r429750090
##
File path: pom.xml
##
@@ -43,77 +42,203 @@
-
+
-
saurabh-khare commented on a change in pull request #1:
URL:
https://github.com/apache/sling-org-apache-sling-superimposing/pull/1#discussion_r429749807
##
File path: pom.xml
##
@@ -43,77 +42,203 @@
-
+
-
saurabh-khare commented on a change in pull request #1:
URL:
https://github.com/apache/sling-org-apache-sling-superimposing/pull/1#discussion_r429750055
##
File path: pom.xml
##
@@ -43,77 +42,203 @@
-
+
-
saurabh-khare commented on a change in pull request #1:
URL:
https://github.com/apache/sling-org-apache-sling-superimposing/pull/1#discussion_r429749984
##
File path: pom.xml
##
@@ -43,77 +42,203 @@
-
+
-
[
https://issues.apache.org/jira/browse/SLING-9454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17115751#comment-17115751
]
Saurabh Khare commented on SLING-9454:
--
Hi [~rombert] thanks for reviewing the pull request, all
saurabh-khare commented on a change in pull request #1:
URL:
https://github.com/apache/sling-org-apache-sling-superimposing/pull/1#discussion_r429752289
##
File path: pom.xml
##
@@ -43,77 +42,203 @@
-
+
-
[
https://issues.apache.org/jira/browse/SLING-9469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Darshan Mahor updated SLING-9469:
-
Summary: Add configuratoin to replace Manifest Properties value (was: Add
configuratoin to
[
https://issues.apache.org/jira/browse/SLING-9469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Darshan Mahor updated SLING-9469:
-
Summary: Add configuratoin to replace Manifest Properties values (was: Add
configuratoin to
Darshan Mahor created SLING-9469:
Summary: Add configuratoin to replace Manifest Properties value
Key: SLING-9469
URL: https://issues.apache.org/jira/browse/SLING-9469
Project: Sling
Issue
saurabh-khare commented on a change in pull request #1:
URL:
https://github.com/apache/sling-org-apache-sling-superimposing/pull/1#discussion_r429753211
##
File path:
src/main/java/org/apache/sling/superimposing/SuperimposingManager.java
##
@@ -38,6 +54,6 @@
*
[
https://issues.apache.org/jira/browse/SLING-9468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler resolved SLING-9468.
-
Resolution: Fixed
Fixed in
[
https://issues.apache.org/jira/browse/SLING-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17115838#comment-17115838
]
Christian Schneider commented on SLING-9465:
I created a proposal at
[
https://issues.apache.org/jira/browse/SLING-9461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17115898#comment-17115898
]
Carsten Ziegeler commented on SLING-9461:
-
[~davidb] I'm not sure if we really need a
[
https://issues.apache.org/jira/browse/SLING-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timothee Maret resolved SLING-9465.
---
Resolution: Fixed
> DiscoveryService is activated on all services
>
[
https://issues.apache.org/jira/browse/SLING-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17115968#comment-17115968
]
Timothee Maret commented on SLING-9465:
---
Done in
[
https://issues.apache.org/jira/browse/SLING-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17115966#comment-17115966
]
Timothee Maret commented on SLING-9465:
---
Thanks [~cschneider], like PR #29, the proposal will go
darshanmahor24 commented on a change in pull request #54:
URL:
https://github.com/apache/sling-slingfeature-maven-plugin/pull/54#discussion_r429810241
##
File path: src/main/java/org/apache/sling/feature/maven/mojos/ApisJarMojo.java
##
@@ -1582,6 +1589,14 @@ private File
Hi,
We solved 1 issue in this release:
https://issues.apache.org/jira/browse/SLING-9470
Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2268
You can use this UNIX script to download the release and verify the
signatures:
[
https://issues.apache.org/jira/browse/SLING-9463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17115963#comment-17115963
]
Bertrand Delacretaz commented on SLING-9463:
I'm playing with this and collecting random
Robert Munteanu created SLING-9471:
--
Summary: Onboard org.apache.sling.installer.factory to SonarCloud
Key: SLING-9471
URL: https://issues.apache.org/jira/browse/SLING-9471
Project: Sling
[
https://issues.apache.org/jira/browse/SLING-9461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert resolved SLING-9461.
---
Resolution: Fixed
> Access Feature Model Aggregates as Files during Maven
On Mon, 2020-05-25 at 12:30 +0200, Carsten Ziegeler wrote:
> Please vote to approve this release:
+1
Robert
signature.asc
Description: This is a digitally signed message part
bosschaert merged pull request #53:
URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/53
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
[
https://issues.apache.org/jira/browse/SLING-9467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timothee Maret resolved SLING-9467.
---
Resolution: Fixed
> PackageCleanupTask is enabled on all services
>
+1
[
https://issues.apache.org/jira/browse/SLING-9467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17115974#comment-17115974
]
Timothee Maret commented on SLING-9467:
---
Merged PR #34.
> PackageCleanupTask is enabled on all
cziegeler merged pull request #54:
URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/54
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
[
https://issues.apache.org/jira/browse/SLING-9463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17115963#comment-17115963
]
Bertrand Delacretaz edited comment on SLING-9463 at 5/25/20, 12:03 PM:
[
https://issues.apache.org/jira/browse/SLING-9469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu updated SLING-9469:
---
Summary: Add configuration to replace Manifest Properties value (was: Add
configuratoin to
Carsten Ziegeler created SLING-9470:
---
Summary: Variables in feature model are not replaced on
installation
Key: SLING-9470
URL: https://issues.apache.org/jira/browse/SLING-9470
Project: Sling
[
https://issues.apache.org/jira/browse/SLING-9464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timothee Maret resolved SLING-9464.
---
Resolution: Fixed
> PubQueueCache is enabled on all services
>
[
https://issues.apache.org/jira/browse/SLING-9464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17115969#comment-17115969
]
Timothee Maret commented on SLING-9464:
---
Merged
[
https://issues.apache.org/jira/browse/SLING-9469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Darshan Mahor updated SLING-9469:
-
Description: add configuration to replace/add values in the Manifest
properties. (was: add
[
https://issues.apache.org/jira/browse/SLING-9469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler updated SLING-9469:
Fix Version/s: slingfeature-maven-plugin 1.3.4
> Add configuration to replace Manifest
[
https://issues.apache.org/jira/browse/SLING-9469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler reassigned SLING-9469:
---
Assignee: Carsten Ziegeler
> Add configuration to replace Manifest Properties value
[
https://issues.apache.org/jira/browse/SLING-9469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler resolved SLING-9469.
-
Resolution: Fixed
Thanks for the PR [~darshanmahor], it's applied.
> Add configuration
[
https://issues.apache.org/jira/browse/SLING-9461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17115913#comment-17115913
]
A. J. David Bosschaert commented on SLING-9461:
---
Right that would be another option. So
sonarcloud[bot] commented on pull request #53:
URL:
https://github.com/apache/sling-slingfeature-maven-plugin/pull/53#issuecomment-633510548
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=53=false=BUG)
sonarcloud[bot] removed a comment on pull request #53:
URL:
https://github.com/apache/sling-slingfeature-maven-plugin/pull/53#issuecomment-632144757
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=53=false=BUG)
[
https://issues.apache.org/jira/browse/SLING-9461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17115925#comment-17115925
]
A. J. David Bosschaert commented on SLING-9461:
---
I have updated the PR with this.
> Access
+1
David
On Mon, 25 May 2020 at 12:40, Robert Munteanu wrote:
> On Mon, 2020-05-25 at 12:30 +0200, Carsten Ziegeler wrote:
> > Please vote to approve this release:
>
> +1
> Robert
>
cziegeler commented on a change in pull request #54:
URL:
https://github.com/apache/sling-slingfeature-maven-plugin/pull/54#discussion_r429792850
##
File path: src/main/java/org/apache/sling/feature/maven/mojos/ApisJarMojo.java
##
@@ -1582,6 +1589,14 @@ private File
cziegeler commented on a change in pull request #54:
URL:
https://github.com/apache/sling-slingfeature-maven-plugin/pull/54#discussion_r429812492
##
File path: src/main/java/org/apache/sling/feature/maven/mojos/ApisJarMojo.java
##
@@ -1582,6 +1589,14 @@ private File
[
https://issues.apache.org/jira/browse/SLING-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116023#comment-17116023
]
Timothee Maret edited comment on SLING-9465 at 5/25/20, 1:34 PM:
-
Top-posting as an attempt to sum up the next steps.
I think we are more or less in agreement over what to do, and what each
piece of the puzzle should do ( starter, ITs, feature model tooling,
kickstart, etc).
I would like to create more tasks to track the work that needs to be
done. As part of
On Mon, 2020-05-25 at 15:24 +0100, dav...@apache.org wrote:
> Please vote to approve this release:
+1
Robert
signature.asc
Description: This is a digitally signed message part
Here's my +1
David
On Mon, 25 May 2020 at 15:50, Robert Munteanu wrote:
> On Mon, 2020-05-25 at 15:24 +0100, dav...@apache.org wrote:
> > Please vote to approve this release:
>
> +1
> Robert
>
[
https://issues.apache.org/jira/browse/SLING-9454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116020#comment-17116020
]
Robert Munteanu commented on SLING-9454:
Thanks for looking into my initial comments [~skhare].
Hi all,
I would like to call the release on the Sling Feature Maven Plugin 1.3.4
Resolved issues:
https://issues.apache.org/jira/projects/SLING/versions/12348275
Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2269
You can use this UNIX script to download
[
https://issues.apache.org/jira/browse/SLING-9462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert updated SLING-9462:
--
Fix Version/s: (was: slingfeature-maven-plugin 1.3.4)
+1
Carsten
On 25.05.2020 16:24, dav...@apache.org wrote:
Hi all,
I would like to call the release on the Sling Feature Maven Plugin 1.3.4
Resolved issues:
https://issues.apache.org/jira/projects/SLING/versions/12348275
Staging repository:
[
https://issues.apache.org/jira/browse/SLING-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116023#comment-17116023
]
Timothee Maret commented on SLING-9465:
---
[~cschneider] suggested an improved version of PR #32 in
Please see
https://builds.apache.org/job/Sling/job/sling-org-apache-sling-launchpad-testing/job/master/811/
for details.
No further emails will be sent until the status of the build is changed.
-/-
On Mon, May 25, 2020, 11:04 AM Robert Munteanu (Jira)
wrote:
>
> [
> https://issues.apache.org/jira/browse/SLING-9397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116098#comment-17116098
> ]
>
> Robert Munteanu commented on SLING-9397:
>
[
https://issues.apache.org/jira/browse/SLING-9397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116098#comment-17116098
]
Robert Munteanu commented on SLING-9397:
[~cris_rockwell] - I plan to make a review pass this
+1
+1
On Mon, May 25, 2020 at 12:48 PM Stefan Seifert
wrote:
> +1
>
65 matches
Mail list logo
