[GitHub] [sling-org-apache-sling-graphql-core] stefangrimm commented on pull request #1: Feature/sling 9550 all scalars

2020-06-30 Thread GitBox
stefangrimm commented on pull request #1: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/1#issuecomment-651853634 I will see if I can come up with something along the existing implementation and check if it really works (biggest problem I see is that we can't

[GitHub] [sling-org-apache-sling-graphql-core] stefangrimm commented on pull request #1: Feature/sling 9550 all scalars

2020-06-30 Thread GitBox
stefangrimm commented on pull request #1: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/1#issuecomment-651771074 Also, in addition to my previous comment: IMHO scalars should not be defined globally, but per endpoint. Typically, they are part of the

[GitHub] [sling-org-apache-sling-graphql-core] stefangrimm commented on pull request #1: Feature/sling 9550 all scalars

2020-06-30 Thread GitBox
stefangrimm commented on pull request #1: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/1#issuecomment-651733264 @bdelacretaz We need something like the suggested alternative to decouple what we're implementing on AEM's side from the Sling Core implementation.