http://bugzilla.spamassassin.org/show_bug.cgi?id=4176
[EMAIL PROTECTED] changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|
http://bugzilla.spamassassin.org/show_bug.cgi?id=4176
--- Additional Comments From [EMAIL PROTECTED] 2005-05-09 09:21 ---
Subject: Re: [review] RFE: please add pattern for nate.com redirector
On Mon, May 09, 2005 at 12:40:22AM -0700, [EMAIL PROTECTED] wrote:
redirector_pattern
http://bugzilla.spamassassin.org/show_bug.cgi?id=4176
--- Additional Comments From [EMAIL PROTECTED] 2005-05-06 16:20 ---
Subject: Re: [review] RFE: please add pattern for nate.com redirector
On Thu, May 05, 2005 at 08:31:04PM -0700, [EMAIL PROTECTED] wrote:
There's a lot of stuff
http://bugzilla.spamassassin.org/show_bug.cgi?id=4176
--- Additional Comments From [EMAIL PROTECTED] 2005-05-06 17:14 ---
Subject: Re: [review] RFE: please add pattern for nate.com redirector
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
This may be a good time to change
http://bugzilla.spamassassin.org/show_bug.cgi?id=4176
--- Additional Comments From [EMAIL PROTECTED] 2005-05-06 19:13 ---
what's wrong with putting redirector-stripping into the existing one
As far as I know the only thing wrong is that redirector stripping is part of
the
http://bugzilla.spamassassin.org/show_bug.cgi?id=4176
--- Additional Comments From [EMAIL PROTECTED] 2005-05-06 22:06 ---
Subject: Re: [review] RFE: please add pattern for nate.com redirector
On Fri, May 06, 2005 at 07:13:26PM -0700, [EMAIL PROTECTED] wrote:
As far as I know the
http://bugzilla.spamassassin.org/show_bug.cgi?id=4176
--- Additional Comments From [EMAIL PROTECTED] 2005-05-06 23:07 ---
The deobfuscation code is in Util.pm
Yes, which makes fixing the problem easier. I meant that the deobfuscation step
haas been made part of the parsing of HTML.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4176
--- Additional Comments From [EMAIL PROTECTED] 2005-05-07 07:03 ---
I have a patch almost ready that moves the calls to uri_list_canonify from HTML
and get_parsed_uri_list into get_uri_list and changes the URIDNSBL plugin call
to
http://bugzilla.spamassassin.org/show_bug.cgi?id=4176
[EMAIL PROTECTED] changed:
What|Removed |Added
Attachment #2845 is|0 |1
obsolete|
http://bugzilla.spamassassin.org/show_bug.cgi?id=4176
--- Additional Comments From [EMAIL PROTECTED] 2005-05-05 16:51 ---
'All I had to do was have HTML.pm conditionalize its one use of the
conf parameter on $self-{main} being a ref. That assumes that when parse is
being called as a
http://bugzilla.spamassassin.org/show_bug.cgi?id=4176
--- Additional Comments From [EMAIL PROTECTED] 2005-05-05 17:41 ---
I don't like the idea of having two different behaviours depending on
how the message object is created...
That's what's bothering me about this. The issue for
http://bugzilla.spamassassin.org/show_bug.cgi?id=4176
--- Additional Comments From [EMAIL PROTECTED] 2005-05-05 18:33 ---
Some installations use multiple perl threads, each of which creates a
Mail::SpamAssassin object. Beware of breaking thread safety.
--- You are receiving
http://bugzilla.spamassassin.org/show_bug.cgi?id=4176
--- Additional Comments From [EMAIL PROTECTED] 2005-05-05 18:37 ---
Subject: Re: [review] RFE: please add pattern for nate.com redirector
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
yep, you're right --
http://bugzilla.spamassassin.org/show_bug.cgi?id=4176
[EMAIL PROTECTED] changed:
What|Removed |Added
Attachment #2846 is|0 |1
obsolete|
http://bugzilla.spamassassin.org/show_bug.cgi?id=4176
--- Additional Comments From [EMAIL PROTECTED] 2005-05-05 19:55 ---
Subject: Re: [review] RFE: please add pattern for nate.com redirector
On Thu, May 05, 2005 at 07:23:57PM -0700, [EMAIL PROTECTED] wrote:
This patch includes
http://bugzilla.spamassassin.org/show_bug.cgi?id=4176
--- Additional Comments From [EMAIL PROTECTED] 2005-05-05 20:31 ---
Theo,
There's a lot of stuff in the comments here. I want to make sure that your vote
is about what ended in the patch and not about things I only talked about
I'd be okay just adding the functionality to the URIDNSBL plugin for now.
Alternately, a separate plugin or doing it in get_uri_list().
It might be better to add a new plugin API that could be called from the
URIDNSBL plugin or any other place that wants it.
--
Daniel Quinlan
http://bugzilla.spamassassin.org/show_bug.cgi?id=4176
--- Additional Comments From [EMAIL PROTECTED] 2005-05-05 20:35 ---
Subject: Re: [review] RFE: please add pattern for nate.com redirector
I'd be okay just adding the functionality to the URIDNSBL plugin for now.
Alternately, a
http://bugzilla.spamassassin.org/show_bug.cgi?id=4176
--- Additional Comments From [EMAIL PROTECTED] 2005-05-05 20:48 ---
How would the new plugin API work? Is the idea that URIs are extracterd and
deobfuscated in HTML.pm and later the URIs can be passed to a plugin to be
checked for
http://bugzilla.spamassassin.org/show_bug.cgi?id=4176
[EMAIL PROTECTED] changed:
What|Removed |Added
AssignedTo|[EMAIL PROTECTED] |dev@spamassassin.apache.org
---
http://bugzilla.spamassassin.org/show_bug.cgi?id=4176
--- Additional Comments From [EMAIL PROTECTED] 2005-05-06 13:12 ---
I see a basic design issue here. Going all the way back to the spamassasssin
script, processing looks like this, as a rough outline:
$mail =
http://bugzilla.spamassassin.org/show_bug.cgi?id=4176
--- Additional Comments From [EMAIL PROTECTED] 2005-05-06 15:01 ---
Subject: Re: [review] RFE: please add pattern for nate.com redirector
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
OK, moving that code to a check()-time
http://bugzilla.spamassassin.org/show_bug.cgi?id=4176
--- Additional Comments From [EMAIL PROTECTED] 2005-05-06 15:12 ---
Subject: Re: [review] RFE: please add pattern for nate.com redirector
On Fri, May 06, 2005 at 12:21:07AM -0700, [EMAIL PROTECTED] wrote:
Hmm, just got back
http://bugzilla.spamassassin.org/show_bug.cgi?id=4176
[EMAIL PROTECTED] changed:
What|Removed |Added
Target Milestone|3.1.0 |3.2.0
--- Additional
http://bugzilla.spamassassin.org/show_bug.cgi?id=4176
--- Additional Comments From [EMAIL PROTECTED] 2005-05-04 23:37 ---
'Is it the case that the @ISA in HTML.pm means
that it inherits from HTML::Parser and not from Mail::SpamAssassin, and it has
no access to the conf stuff in the
http://bugzilla.spamassassin.org/show_bug.cgi?id=4176
[EMAIL PROTECTED] changed:
What|Removed |Added
Attachment #2788 is|0 |1
obsolete|
http://bugzilla.spamassassin.org/show_bug.cgi?id=4176
--- Additional Comments From [EMAIL PROTECTED] 2005-05-05 10:27 ---
Sidney --
yep, it really is that simple ;) it's unfortunate that it has to be passed
through, but given that the HTML parsing (a complex step that requires
http://bugzilla.spamassassin.org/show_bug.cgi?id=4176
--- Additional Comments From [EMAIL PROTECTED] 2005-05-05 14:25 ---
Justin said:
yep, it really is that simple ;)
Wanna bet? :-)
sa-learn calls Mail::SpamAssassin::parse which I guess is a class method, which
gets passed the
http://bugzilla.spamassassin.org/show_bug.cgi?id=4176
--- Additional Comments From [EMAIL PROTECTED] 2005-05-05 14:44 ---
It looks like in all three cases where parse is called as a class method, the
caller realy wants to do some parsing of a message for some specific information
and
http://bugzilla.spamassassin.org/show_bug.cgi?id=4176
--- Additional Comments From [EMAIL PROTECTED] 2005-05-05 14:57 ---
typo. I meant (and making what I'm wrapping explicit)
my $redirector_patterns;
$redirector_patterns =
$self-{main}-{conf}-{redirector_patterns} if ref
http://bugzilla.spamassassin.org/show_bug.cgi?id=4176
--- Additional Comments From [EMAIL PROTECTED] 2005-05-05 15:14 ---
ick. ok, if the code is run at message-parse-time without the $main object
being available easily, that certainly makes life harder.
I don't think we should
http://bugzilla.spamassassin.org/show_bug.cgi?id=4176
--- Additional Comments From [EMAIL PROTECTED] 2005-05-03 16:10 ---
Actually, when I don't mis-type the uri, it works fine in a plain text message.
Sidney, can you attach the html message you're using to the bug?
--- You
http://bugzilla.spamassassin.org/show_bug.cgi?id=4176
--- Additional Comments From [EMAIL PROTECTED] 2005-05-03 16:24 ---
Created an attachment (id=2832)
-- (http://bugzilla.spamassassin.org/attachment.cgi?id=2832action=view)
Test spam containing redirected url that is not parsed
http://bugzilla.spamassassin.org/show_bug.cgi?id=4176
--- Additional Comments From [EMAIL PROTECTED] 2005-05-03 17:01 ---
I think I see the problem.
In HTML.pm the call to uri_list_canonify passes in
$self-{conf}-{redirector_patterns} but unlike in PerMsgStatus.pm, where the
same
http://bugzilla.spamassassin.org/show_bug.cgi?id=4176
--- Additional Comments From [EMAIL PROTECTED] 2005-05-03 17:09 ---
Well, I'm wrong about the fix - I don't know much about how O-O perl works and
what the SUPER::new in HTML::new does compared to the way things are in
http://bugzilla.spamassassin.org/show_bug.cgi?id=4176
--- Additional Comments From [EMAIL PROTECTED] 2005-05-03 17:42 ---
I read up a little on perl O-O... Is it the case that the @ISA in HTML.pm means
that it inherits from HTML::Parser and not from Mail::SpamAssassin, and it has
no
http://bugzilla.spamassassin.org/show_bug.cgi?id=4176
--- Additional Comments From [EMAIL PROTECTED] 2005-05-03 17:46 ---
Subject: Re: [review] RFE: please add pattern for nate.com redirector
Yeah, I just took a look at it now. It appears that I just copied the
line over from
http://bugzilla.spamassassin.org/show_bug.cgi?id=4176
--- Additional Comments From [EMAIL PROTECTED] 2005-05-02 23:07 ---
+1 looks great to me
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4176
[EMAIL PROTECTED] changed:
What|Removed |Added
Status Whiteboard||needs 1 more vote
---
http://bugzilla.spamassassin.org/show_bug.cgi?id=4176
--- Additional Comments From [EMAIL PROTECTED] 2005-05-03 15:18 ---
What should this look like when it works? I ran spamassassin -t -D on a spam I
have that uses the nate.com redirector and all I saw in the logs that looke
http://bugzilla.spamassassin.org/show_bug.cgi?id=4176
--- Additional Comments From [EMAIL PROTECTED] 2005-05-03 15:31 ---
quinlan added nate.com to the uridnsbl_skip_domain list in r160005 so any checks
on nate.com (including the domain being redirected to) are skipped.
---
http://bugzilla.spamassassin.org/show_bug.cgi?id=4176
--- Additional Comments From [EMAIL PROTECTED] 2005-05-03 15:48 ---
Right! That was just a coincidence.
For some reason it doesn't work with the encoded url, I'll have to take a look.
--- You are receiving this mail
http://bugzilla.spamassassin.org/show_bug.cgi?id=4176
[EMAIL PROTECTED] changed:
What|Removed |Added
Summary|RFE: please add pattern for |[review] RFE: please add
43 matches
Mail list logo
