Re: [VOTE] Release Apache Spark 3.5.1 (RC2)

2024-02-23 Thread Jungtaek Lim
t; `Affects Version` and `Fix Version` of SPARK-45242 were both 4.0, and I >>>>> didn't realize that it had also been merged into branch-3.5, so I didn't >>>>> advocate for SPARK-45357 to be backported to branch-3.5. >>>>> > As far as I know,

Re: [VOTE] Release Apache Spark 3.5.1 (RC2)

2024-02-23 Thread Dongjoon Hyun
rted to branch-3.5. >>>> > As far as I know, the condition to trigger this test failure is: >>>> when using Maven to test the `connect` module, if `sparkTestRelation` in >>>> `SparkConnectProtoSuite` is not the first `DataFrame` to be initialized, >&g

Re: [VOTE] Release Apache Spark 3.5.1 (RC2)

2024-02-21 Thread Jungtaek Lim
o I didn't >>> advocate for SPARK-45357 to be backported to branch-3.5. >>> > As far as I know, the condition to trigger this test failure is: when >>> using Maven to test the `connect` module, if `sparkTestRelation` in >>> `SparkConnectProtoSuite` is not the first `DataFr

Re: [VOTE] Release Apache Spark 3.5.1 (RC2)

2024-02-20 Thread Maxim Gekk
longer be 0. So, I think this >> is indeed related to the order in which Maven executes the test cases in >> the `connect` module. >> > I have submitted a backport PR to branch-3.5, and if necessary, we can >> merge it to fix this test issue. >> > Jie Yang >&

Re: [VOTE] Release Apache Spark 3.5.1 (RC2)

2024-02-20 Thread Hyukjin Kwon
zed, > then the `id` of `sparkTestRelation` will no longer be 0. So, I think this > is indeed related to the order in which Maven executes the test cases in > the `connect` module. > > I have submitted a backport PR to branch-3.5, and if necessary, we can > merge it to fix this

Re: [VOTE] Release Apache Spark 3.5.1 (RC2)

2024-02-20 Thread Xiao Li
hen the `id` of `sparkTestRelation` will no longer be 0. So, I think this > is indeed related to the order in which Maven executes the test cases in > the `connect` module. > > I have submitted a backport PR to branch-3.5, and if necessary, we can > merge it to fix this test iss

Re: [VOTE] Release Apache Spark 3.5.1 (RC2)

2024-02-20 Thread Cheng Pan
necessary, we can merge > it to fix this test issue. > Jie Yang > 发件人: Jungtaek Lim > 日期: 2024年2月16日 星期五 22:15 > 收件人: Sean Owen , Rui Wang > 抄送: dev > 主题: Re: [VOTE] Release Apache Spark 3.5.1 (RC2) > I traced back relevant changes and got a sense of what happen

Re: [VOTE] Release Apache Spark 3.5.1 (RC2)

2024-02-19 Thread Wenchen Fan
backport PR >> <https://github.com/apache/spark/pull/45141> to branch-3.5, and if >> necessary, we can merge it to fix this test issue. >> >> >> >> Jie Yang >> >> >> >> *发件人**: *Jungtaek Lim >> *日期**: *2024年2月16日 星期五 22:15 >&g

Re: [VOTE] Release Apache Spark 3.5.1 (RC2)

2024-02-19 Thread Jungtaek Lim
he `connect` module. >> >> >> >> I have submitted a backport PR >> <https://github.com/apache/spark/pull/45141> to branch-3.5, and if >> necessary, we can merge it to fix this test issue. >> >> >> >> Jie Yang >> >> &

Re: [VOTE] Release Apache Spark 3.5.1 (RC2)

2024-02-16 Thread Sean Owen
; > *发件人**: *Jungtaek Lim > *日期**: *2024年2月16日 星期五 22:15 > *收件人**: *Sean Owen , Rui Wang > *抄送**: *dev > *主题**: *Re: [VOTE] Release Apache Spark 3.5.1 (RC2) > > > > I traced back relevant changes and got a sense

Re: [VOTE] Release Apache Spark 3.5.1 (RC2)

2024-02-16 Thread yangjie01
年2月16日 星期五 22:15 收件人: Sean Owen , Rui Wang 抄送: dev 主题: Re: [VOTE] Release Apache Spark 3.5.1 (RC2) I traced back relevant changes and got a sense of what happened. Yangjie figured out the issue via link<https://mailshield.baidu.com/check?q=8dOSfwXDF

Re: [VOTE] Release Apache Spark 3.5.1 (RC2)

2024-02-16 Thread Jungtaek Lim
I traced back relevant changes and got a sense of what happened. Yangjie figured out the issue via link . It's a tricky issue according to the comments from Yangjie - the test is dependent on ordering of execution for test suites.

Re: [VOTE] Release Apache Spark 3.5.1 (RC2)

2024-02-15 Thread Sean Owen
Is anyone seeing this Spark Connect test failure? then again, I have some weird issue with this env that always fails 1 or 2 tests that nobody else can replicate. - Test observe *** FAILED *** == FAIL: Plans do not match === !CollectMetrics my_metric, [min(id#0) AS min_val#0, max(id#0) AS