Re: Review Request 67424: SQOOP-3330 - Sqoop --append does not work with -Dmapreduce.output.basename

> On July 10, 2018, 4:05 p.m., Boglarka Egyed wrote: > > .gitignore > > Lines 39 (patched) > > > > > > Just as in https://reviews.apache.org/r/54528/ why do we need this here? > > Eric Lin wrote: > It happened to

Re: Review Request 67424: SQOOP-3330 - Sqoop --append does not work with -Dmapreduce.output.basename

> On July 12, 2018, 3:41 p.m., Szabolcs Vasas wrote: > > src/test/org/apache/sqoop/TestAppendUtils.java > > Lines 331 (patched) > > > > > > Nit: can you please use generic List here, otherwise the compiler gives > >

Re: Review Request 67424: SQOOP-3330 - Sqoop --append does not work with -Dmapreduce.output.basename

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67424/ --- (Updated July 13, 2018, 5:25 a.m.) Review request for Sqoop and Boglarka Egyed.

Re: Review Request 67424: SQOOP-3330 - Sqoop --append does not work with -Dmapreduce.output.basename

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67424/#review206012 --- Fix it, then Ship it! Hi Eric, Thank you for your patch, I hav

Re: Review Request 67424: SQOOP-3330 - Sqoop --append does not work with -Dmapreduce.output.basename

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67424/ --- (Updated July 12, 2018, 8:11 a.m.) Review request for Sqoop and Boglarka Egyed.

Re: Review Request 67424: SQOOP-3330 - Sqoop --append does not work with -Dmapreduce.output.basename

> On July 10, 2018, 4:05 p.m., Boglarka Egyed wrote: > > .gitignore > > Lines 39 (patched) > > > > > > Just as in https://reviews.apache.org/r/54528/ why do we need this here? It happened to me a few times that "out"

Re: Review Request 67424: SQOOP-3330 - Sqoop --append does not work with -Dmapreduce.output.basename

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67424/ --- (Updated July 11, 2018, 7:24 a.m.) Review request for Sqoop and Boglarka Egyed.

Re: Review Request 67424: SQOOP-3330 - Sqoop --append does not work with -Dmapreduce.output.basename

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67424/#review205902 --- Fix it, then Ship it! Hi Eric, Thank you very much for this fi