[jira] [Commented] (STORM-1674) Idle KafkaSpout consumes more bandwidth than needed

2016-05-03 Thread Robert Hastings (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15269303#comment-15269303 ] Robert Hastings commented on STORM-1674: Sure, in progress. > Idle KafkaSpout consumes more

Re: [VOTE] Release Apache Storm 1.0.1 (rc3)

2016-05-03 Thread Arun Mahadevan
+1 (binding) - Extracted all binaries. - Ran sample topologies. - Verified Stateful bolt changes added in 1.0.1 works as expected. Thanks, Arun On 5/3/16, 4:52 AM, "Harsha" wrote: >+1 (binding) > - Deployed 3-node cluster and example topologies > - Verified the binaries

[GitHub] storm pull request: [STORM-1707] Remove two minute timeout after w...

2016-05-03 Thread hustfxj
Github user hustfxj commented on the pull request: https://github.com/apache/storm/pull/1370#issuecomment-216446889 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[jira] [Commented] (STORM-1707) Improve supervisor latency by removing 2-min wait

2016-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268169#comment-15268169 ] ASF GitHub Bot commented on STORM-1707: --- Github user hustfxj commented on the pull request:

[jira] [Commented] (STORM-1757) Apache Beam Runner for Storm

2016-05-03 Thread Jungtaek Lim (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268166#comment-15268166 ] Jungtaek Lim commented on STORM-1757: - I also would like to participate in. Before that, how about

[GitHub] storm pull request: STORM-1700 Introduce 'whitelist' / 'blacklist'...

2016-05-03 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/1324#issuecomment-216452966 @unsleepy22 Addressed "dropping older metrics points when consumer can't catch up" to STORM-1698, and rebase this pull request. --- If your project is set up for

[jira] [Commented] (STORM-1700) Introduce 'whitelist' / 'blacklist' option to MetricsConsumer

2016-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268226#comment-15268226 ] ASF GitHub Bot commented on STORM-1700: --- Github user HeartSaVioR commented on the pull request:

Re: [VOTE] Release Apache Storm 0.10.1 (rc2)

2016-05-03 Thread Arun Mahadevan
+1 (binding) - Extracted binaries - Ran sample topologies - Browsed storm UI Thanks, Arun On 4/28/16, 12:01 PM, "Jungtaek Lim" wrote: >+1 (binding) > >- testing with source distribution : OK > - unzip : OK > - building from source dist : OK >- how to build: running

[GitHub] storm pull request: STORM-1756: Explicitly null KafkaServer refere...

2016-05-03 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/1387#issuecomment-216460320 Hi, @srdo Since I didn't see any OOMEs, I'm curious that it is based on assumption or you could provide scenario to reproduce. --- If your project is set up

[GitHub] storm pull request: STORM-1750: Ensure worker dies when report-err...

2016-05-03 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/1384#issuecomment-216463598 +1 @srdo Nice finding. Could you address this to 1.x-branch and 0.10.x-branch, too? Thanks in advance! --- If your project is set up for it, you can reply to

[jira] [Commented] (STORM-1745) Add partition to PartitionManager logs where it's missing

2016-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268344#comment-15268344 ] ASF GitHub Bot commented on STORM-1745: --- Github user HeartSaVioR commented on the pull request:

[jira] [Commented] (STORM-1735) Nimbus logs that replication was not reached when min-replication-count was reached exactly

2016-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268392#comment-15268392 ] ASF GitHub Bot commented on STORM-1735: --- Github user HeartSaVioR commented on the pull request:

[GitHub] storm pull request: STORM-1735: Nimbus should log that replication...

2016-05-03 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/1369#issuecomment-216472728 +1 Nice finding. @srdo I could cherry-pick into 1.x-branch since changeset is really small but then merging should wait to release 1.0.1. Could you craft pull

[jira] [Commented] (STORM-1661) Introduce a config to turn off blobstore acl validation in insecure mode

2016-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268434#comment-15268434 ] ASF GitHub Bot commented on STORM-1661: --- Github user HeartSaVioR commented on the pull request:

[jira] [Commented] (STORM-1661) Introduce a config to turn off blobstore acl validation in insecure mode

2016-05-03 Thread Jungtaek Lim (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268437#comment-15268437 ] Jungtaek Lim commented on STORM-1661: - FYI : PR for 1.x-branch is

[GitHub] storm pull request: storm-1726: use Put#addColumn to replace the d...

2016-05-03 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/1388#issuecomment-216483766 @lujinhong No you need to create your branch based on 1.x-branch in order to craft pull request against 1.x-branch. --- If your project is set up for it, you can

[GitHub] storm pull request: STORM-1756: Explicitly null KafkaServer refere...

2016-05-03 Thread srdo
Github user srdo commented on the pull request: https://github.com/apache/storm/pull/1387#issuecomment-216488648 @HeartSaVioR I saw OOME on one of my branches, because each KafkaServerStartable allocates a 130MB byte array for the log cleaner thread. A heap dump showed that there

[jira] [Commented] (STORM-1756) Storm-kafka tests leak resources due to retained references to KafkaServer

2016-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268475#comment-15268475 ] ASF GitHub Bot commented on STORM-1756: --- Github user srdo closed the pull request at:

[GitHub] storm pull request: STORM-1756: Explicitly null KafkaServer refere...

2016-05-03 Thread srdo
Github user srdo closed the pull request at: https://github.com/apache/storm/pull/1387 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (STORM-1750) Report-error-and-die may not kill the worker

2016-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268330#comment-15268330 ] ASF GitHub Bot commented on STORM-1750: --- Github user HeartSaVioR commented on the pull request:

[GitHub] storm pull request: storm-1726: use Put#addColumn to replace the d...

2016-05-03 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/1353#issuecomment-216473523 +1 @Parth-Brahmbhatt Would you have a plan to submit your patch for the improvement? --- If your project is set up for it, you can reply to this email and have

[jira] [Commented] (STORM-1756) Storm-kafka tests leak resources due to retained references to KafkaServer

2016-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268307#comment-15268307 ] ASF GitHub Bot commented on STORM-1756: --- Github user HeartSaVioR commented on the pull request:

[GitHub] storm pull request: STORM-1736. Change KafkaTestBroker.buildKafkaC...

2016-05-03 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/1376#issuecomment-216467060 I also don't encounter this through 1.0.1 RC1 to 1.0.1 RC3. Did you set the custom Kafka version while building? --- If your project is set up for it, you can

[jira] [Commented] (STORM-1715) Jedis Default Host

2016-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268402#comment-15268402 ] ASF GitHub Bot commented on STORM-1715: --- Github user HeartSaVioR commented on the pull request:

[GitHub] storm pull request: [STORM-1715] using Jedis Protocol.DEFAULT_HOST...

2016-05-03 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/1350#issuecomment-216474165 @darionyaphet Sorry it takes long to review. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] storm pull request: storm-1726: use Put#addColumn to replace the d...

2016-05-03 Thread lujinhong
GitHub user lujinhong opened a pull request: https://github.com/apache/storm/pull/1388 storm-1726: use Put#addColumn to replace the deprecated Put#add You can merge this pull request into a Git repository by running: $ git pull https://github.com/lujinhong/storm storm-hbase

[GitHub] storm pull request: [STORM-1676] Filter null executor stats from w...

2016-05-03 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/1298#issuecomment-216480852 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] storm pull request: minor: fix `storm.py` broken link

2016-05-03 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/1349#issuecomment-216474859 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[jira] [Commented] (STORM-1646) Intermittent test failures in storm-kafka unit tests

2016-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268420#comment-15268420 ] ASF GitHub Bot commented on STORM-1646: --- Github user HeartSaVioR commented on the pull request:

[GitHub] storm pull request: [STORM-1661] Introduce ACL Validation config f...

2016-05-03 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/1271#issuecomment-216481444 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] storm pull request: [YSTORM-1661] Added acl validation config 1.x ...

2016-05-03 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/1290#issuecomment-216481526 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[jira] [Commented] (STORM-1672) Stats not get class cast exception

2016-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268441#comment-15268441 ] ASF GitHub Bot commented on STORM-1672: --- Github user HeartSaVioR commented on the pull request:

[GitHub] storm pull request: STORM-1672: Stats getting class cast exception

2016-05-03 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/1286#issuecomment-216482595 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] storm pull request: STORM-1755: Revert the kafka client version to...

2016-05-03 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/1386#issuecomment-216460875 +1 This and ES case indicate that we would be better to have some strategies or policies to be compatible with non-compatible versions range of external

[jira] [Commented] (STORM-1755) Revert the kafka client version upgrade in storm-kafka module

2016-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268314#comment-15268314 ] ASF GitHub Bot commented on STORM-1755: --- Github user HeartSaVioR commented on the pull request:

[GitHub] storm pull request: minor: update command line client documentatio...

2016-05-03 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/1375#issuecomment-216467436 +1 Nice finding. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] storm pull request: storm-1726: use Put#addColumn to replace the d...

2016-05-03 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/1353#issuecomment-216474300 @lujinhong Never mind. It would be better to cherry-pick since patch is really tiny. --- If your project is set up for it, you can reply to this email and have

[GitHub] storm pull request: [STORM-1646] Fix Kafka unit tests

2016-05-03 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/1335#issuecomment-216477509 `max.block.ms` is not available for 0.8.x so IMO it would be not good to change storm-kafka module to strictly support 0.9 or higher. Users who use Kafka 0.9 or

[GitHub] storm pull request: [YSTORM-1661] Added acl validation config 1.x ...

2016-05-03 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/1290#issuecomment-216482021 Sorry I didn't indicate the compile error from the CI. Revoking +1. @redsanket Could you check the compile issue? doAclValidation should be initialized when it's

[GitHub] storm pull request: [STORM-1661] Introduce ACL Validation config f...

2016-05-03 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/1271#issuecomment-216482139 Sorry I didn't indicate the compile error from the CI. Revoking +1. @redsanket Could you check the compile issue? doAclValidation should be initialized when it's

[GitHub] storm pull request: STORM-1674: Addresses network flood from Kafka...

2016-05-03 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/1287#issuecomment-216483408 @moesol Sorry to participate too lately. Could you craft the pull request based on master, 1.x-branch, and 0.10.x-branch? If you mind to craft several pull

[jira] [Commented] (STORM-1674) Idle KafkaSpout consumes more bandwidth than needed

2016-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268443#comment-15268443 ] ASF GitHub Bot commented on STORM-1674: --- Github user HeartSaVioR commented on the pull request:

[GitHub] storm pull request: STORM-1725: Kafka Spout New Consumer API - Kaf...

2016-05-03 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/1382#issuecomment-216463802 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[jira] [Commented] (STORM-1725) Kafka Spout New Consumer API - KafkaSpoutRetryExponentialBackoff method should use HashMap instead of TreeMap not to throw Exception

2016-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268333#comment-15268333 ] ASF GitHub Bot commented on STORM-1725: --- Github user HeartSaVioR commented on the pull request:

[jira] [Commented] (STORM-1736) Change KafkaTestBroker.buildKafkaConfig to new KafkaConfig api.

2016-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268361#comment-15268361 ] ASF GitHub Bot commented on STORM-1736: --- Github user HeartSaVioR commented on the pull request:

[jira] [Commented] (STORM-1676) NullPointerException while serializing ClusterWorkerHearbeat

2016-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268428#comment-15268428 ] ASF GitHub Bot commented on STORM-1676: --- Github user HeartSaVioR commented on the pull request:

[jira] [Commented] (STORM-1745) Add partition to PartitionManager logs where it's missing

2016-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268480#comment-15268480 ] ASF GitHub Bot commented on STORM-1745: --- GitHub user srdo reopened a pull request:

[GitHub] storm pull request: STORM-1754: Correct java version in 0.10.x sto...

2016-05-03 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/1385#issuecomment-216461066 +1 Thanks for addressing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[jira] [Commented] (STORM-1754) Correct java version in 0.10.x storm-starter

2016-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268316#comment-15268316 ] ASF GitHub Bot commented on STORM-1754: --- Github user HeartSaVioR commented on the pull request:

[jira] [Commented] (STORM-1750) Report-error-and-die may not kill the worker

2016-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268334#comment-15268334 ] ASF GitHub Bot commented on STORM-1750: --- Github user srdo commented on the pull request:

[GitHub] storm pull request: STORM-1750: Ensure worker dies when report-err...

2016-05-03 Thread srdo
Github user srdo commented on the pull request: https://github.com/apache/storm/pull/1384#issuecomment-216464027 Hi @HeartSaVioR, Sure, I'll make another pair of PRs soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] storm pull request: add convenience methods for checking tuple typ...

2016-05-03 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/1378#issuecomment-216465801 +1 Could you craft pull requests for 1.x-branch and 0.10.x-branch, too? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] storm pull request: [STORM-1707] Remove two minute timeout after w...

2016-05-03 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/1370#issuecomment-216472136 +1 Nice. @ppoulosk Could you craft pull requests against 1.x-branch, too? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] storm pull request: storm-1726: use Put#addColumn to replace the d...

2016-05-03 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/1353#issuecomment-216473947 @lujinhong Would you also craft pull request for 1.x-branch? I can also cherry-pick so please submit if you really don't mind. --- If your project is set up for

[GitHub] storm pull request: STORM-1701 simple JSON mapping

2016-05-03 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/1327#issuecomment-216479478 @kristopherkane Yes, squash and push with `force` option. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[jira] [Commented] (STORM-1701) Add simple JSON mapping to storm-hbase

2016-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268422#comment-15268422 ] ASF GitHub Bot commented on STORM-1701: --- Github user HeartSaVioR commented on the pull request:

[jira] [Commented] (STORM-1661) Introduce a config to turn off blobstore acl validation in insecure mode

2016-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268439#comment-15268439 ] ASF GitHub Bot commented on STORM-1661: --- Github user HeartSaVioR commented on the pull request:

[GitHub] storm pull request: STORM-1745: Add partition to log output in Par...

2016-05-03 Thread srdo
Github user srdo closed the pull request at: https://github.com/apache/storm/pull/1380 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm pull request: STORM-1745: Add partition to log output in Par...

2016-05-03 Thread srdo
GitHub user srdo reopened a pull request: https://github.com/apache/storm/pull/1380 STORM-1745: Add partition to log output in PartitionManager Adding topic name and partition id to the log output makes it easier to debug when an issue arises. You can merge this pull request into

[jira] [Commented] (STORM-1745) Add partition to PartitionManager logs where it's missing

2016-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268479#comment-15268479 ] ASF GitHub Bot commented on STORM-1745: --- Github user srdo closed the pull request at:

[jira] [Commented] (STORM-1674) Idle KafkaSpout consumes more bandwidth than needed

2016-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15269614#comment-15269614 ] ASF GitHub Bot commented on STORM-1674: --- GitHub user moesol opened a pull request:

[jira] [Commented] (STORM-1757) Apache Beam Runner for Storm

2016-05-03 Thread Hugo Louro (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15269498#comment-15269498 ] Hugo Louro commented on STORM-1757: --- I also would like to work on this project. > Apache Beam Runner

[GitHub] storm pull request: (STORM-1674) Idle KafkaSpout consumes more ban...

2016-05-03 Thread moesol
Github user moesol commented on the pull request: https://github.com/apache/storm/pull/1391#issuecomment-21896 Without the MaxWait being set to 100, it is set to 1, which means that the bolt will waiting for 10 seconds when no messages are available. On the 1.x branch, I was

[jira] [Commented] (STORM-1674) Idle KafkaSpout consumes more bandwidth than needed

2016-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15269608#comment-15269608 ] ASF GitHub Bot commented on STORM-1674: --- Github user moesol commented on the pull request:

[GitHub] storm pull request: STORM-1760. HiveState should retire idle or ol...

2016-05-03 Thread harshach
GitHub user harshach opened a pull request: https://github.com/apache/storm/pull/1392 STORM-1760. HiveState should retire idle or old writes with flushAndClose You can merge this pull request into a Git repository by running: $ git pull

[GitHub] storm pull request: (STORM-1674) Idle KafkaSpout consumes more ban...

2016-05-03 Thread moesol
GitHub user moesol opened a pull request: https://github.com/apache/storm/pull/1391 (STORM-1674) Idle KafkaSpout consumes more bandwidth than needed * Allows minBytes in fetch request to be configured from KafkaConfig.fetchMinBytes. * Defaults new configuration

[jira] [Commented] (STORM-1674) Idle KafkaSpout consumes more bandwidth than needed

2016-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15269570#comment-15269570 ] ASF GitHub Bot commented on STORM-1674: --- GitHub user moesol opened a pull request:

[jira] [Commented] (STORM-1674) Idle KafkaSpout consumes more bandwidth than needed

2016-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15269582#comment-15269582 ] ASF GitHub Bot commented on STORM-1674: --- Github user harshach commented on the pull request:

[GitHub] storm pull request: (STORM-1674) Idle KafkaSpout consumes more ban...

2016-05-03 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/1391#issuecomment-216663883 @moesol there is patch that merged into 1.0 release https://github.com/apache/storm/pull/1309/files . Does that changes work for you. Any reason for the MaxWait to be

[GitHub] storm pull request: STORM-1756: Explicitly null KafkaServer refere...

2016-05-03 Thread srdo
Github user srdo commented on the pull request: https://github.com/apache/storm/pull/1387#issuecomment-216490426 If this turns out to be a problem later, disabling the log cleaner thread during tests is probably a better fix. The tests don't make logs long enough to be compacted

[GitHub] storm pull request: STORM-1750 (0.10.x): Ensure worker dies when r...

2016-05-03 Thread srdo
GitHub user srdo opened a pull request: https://github.com/apache/storm/pull/1390 STORM-1750 (0.10.x): Ensure worker dies when report-error-and-die is … …called. Make cluster set-data try setting data if node creation fails because the node exists. Backport of

[jira] [Resolved] (STORM-1756) Storm-kafka tests leak resources due to retained references to KafkaServer

2016-05-03 Thread JIRA
[ https://issues.apache.org/jira/browse/STORM-1756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stig Rohde Døssing resolved STORM-1756. --- Resolution: Cannot Reproduce Tried setting up some test classes with KafkaTestBroker

[jira] [Commented] (STORM-1756) Storm-kafka tests leak resources due to retained references to KafkaServer

2016-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268491#comment-15268491 ] ASF GitHub Bot commented on STORM-1756: --- Github user srdo commented on the pull request:

[jira] [Commented] (STORM-1756) Storm-kafka tests leak resources due to retained references to KafkaServer

2016-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268574#comment-15268574 ] ASF GitHub Bot commented on STORM-1756: --- Github user HeartSaVioR commented on the pull request:

[GitHub] storm pull request: STORM-1756: Explicitly null KafkaServer refere...

2016-05-03 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/1387#issuecomment-216505586 Please reopen this issue if you saw intermittent test failure. What I asked is that it's a theory or it occurred some issues. --- If your project is set up for it,

[GitHub] storm pull request: STORM-1756: Explicitly null KafkaServer refere...

2016-05-03 Thread srdo
Github user srdo commented on the pull request: https://github.com/apache/storm/pull/1387#issuecomment-216508276 I did see OOME due to KafkaServer resources. 8x 130MB byte arrays caused the VM to run out of memory. As I said, I can't reproduce it. It's probably not an issue on master

[GitHub] storm pull request: STORM-1756: Explicitly null KafkaServer refere...

2016-05-03 Thread srdo
GitHub user srdo reopened a pull request: https://github.com/apache/storm/pull/1387 STORM-1756: Explicitly null KafkaServer reference in KafkaTestBroker … …to prevent out of memory on large test classes. I'm not clear on whether JUnit keeps the reference for the

[jira] [Commented] (STORM-1735) Nimbus logs that replication was not reached when min-replication-count was reached exactly

2016-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268514#comment-15268514 ] ASF GitHub Bot commented on STORM-1735: --- Github user srdo commented on the pull request:

[jira] [Commented] (STORM-1745) Add partition to PartitionManager logs where it's missing

2016-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268528#comment-15268528 ] ASF GitHub Bot commented on STORM-1745: --- Github user srdo commented on the pull request:

[GitHub] storm pull request: STORM-1745: Add partition to log output in Par...

2016-05-03 Thread srdo
Github user srdo commented on the pull request: https://github.com/apache/storm/pull/1380#issuecomment-216496822 @HeartSaVioR Sure. The current logs look like this "Starting Kafka 10.4.5.1:0 from offset 15520", which doesn't tell you which topic it's affecting. The logs in L259 and

[GitHub] storm pull request: STORM-1750: Ensure worker dies when report-err...

2016-05-03 Thread srdo
GitHub user srdo opened a pull request: https://github.com/apache/storm/pull/1389 STORM-1750: Ensure worker dies when report-error-and-die is called. M… …ake zookeeper_state_factory set-data try setting data if node creation fails because the node exists. Backport of

[jira] [Commented] (STORM-1756) Storm-kafka tests leak resources due to retained references to KafkaServer

2016-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268593#comment-15268593 ] ASF GitHub Bot commented on STORM-1756: --- GitHub user srdo reopened a pull request:

[jira] [Commented] (STORM-1756) Storm-kafka tests leak resources due to retained references to KafkaServer

2016-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268592#comment-15268592 ] ASF GitHub Bot commented on STORM-1756: --- Github user srdo commented on the pull request:

[GitHub] storm pull request: STORM-1735: Nimbus should log that replication...

2016-05-03 Thread srdo
Github user srdo commented on the pull request: https://github.com/apache/storm/pull/1369#issuecomment-216493707 @HeartSaVioR Sure, please do :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[jira] [Commented] (STORM-1750) Report-error-and-die may not kill the worker

2016-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268575#comment-15268575 ] ASF GitHub Bot commented on STORM-1750: --- GitHub user srdo opened a pull request:

[jira] [Commented] (STORM-1758) Distributed log search doesn't work in dockerized environment

2016-05-03 Thread Elisey Zanko (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268836#comment-15268836 ] Elisey Zanko commented on STORM-1758: - It works. Thanks! > Distributed log search doesn't work in

[GitHub] storm pull request: STORM-1755: Revert the kafka client version to...

2016-05-03 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on the pull request: https://github.com/apache/storm/pull/1386#issuecomment-216558668 Yes. Good thing is storm-kafka doesn't use any api only available in kafka 0.9.x and thus can still run with kafka 0.8.x by simply excluding dependency. ---

[jira] [Commented] (STORM-1755) Revert the kafka client version upgrade in storm-kafka module

2016-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268850#comment-15268850 ] ASF GitHub Bot commented on STORM-1755: --- Github user abhishekagarwal87 commented on the pull

[jira] [Commented] (STORM-1700) Introduce 'whitelist' / 'blacklist' option to MetricsConsumer

2016-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268857#comment-15268857 ] ASF GitHub Bot commented on STORM-1700: --- Github user unsleepy22 commented on a diff in the pull

[jira] [Issue Comment Deleted] (STORM-1758) Distributed log search doesn't work in dockerized environment

2016-05-03 Thread Elisey Zanko (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elisey Zanko updated STORM-1758: Comment: was deleted (was: It works. Thanks!) > Distributed log search doesn't work in dockerized

[jira] [Commented] (STORM-1758) Distributed log search doesn't work in dockerized environment

2016-05-03 Thread Elisey Zanko (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268834#comment-15268834 ] Elisey Zanko commented on STORM-1758: - It works. Thanks! > Distributed log search doesn't work in

[GitHub] storm pull request: STORM-1736. Change KafkaTestBroker.buildKafkaC...

2016-05-03 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on the pull request: https://github.com/apache/storm/pull/1376#issuecomment-216560931 This would also break the compatibility of storm 1.0.0 with 0.8.x kafka client API. --- If your project is set up for it, you can reply to this email and

[jira] [Commented] (STORM-1736) Change KafkaTestBroker.buildKafkaConfig to new KafkaConfig api.

2016-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268861#comment-15268861 ] ASF GitHub Bot commented on STORM-1736: --- Github user abhishekagarwal87 commented on the pull

[GitHub] storm pull request: STORM-1745: Add partition to log output in Par...

2016-05-03 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/1380#issuecomment-216465299 @srdo Could you give an example of actual changes in logs? --- If your project is set up for it, you can reply to this email and have your reply appear on

[jira] [Commented] (STORM-1707) Improve supervisor latency by removing 2-min wait

2016-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268385#comment-15268385 ] ASF GitHub Bot commented on STORM-1707: --- Github user HeartSaVioR commented on the pull request:

[jira] [Commented] (STORM-1758) Distributed log search doesn't work in dockerized environment

2016-05-03 Thread Elisey Zanko (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268852#comment-15268852 ] Elisey Zanko commented on STORM-1758: - Actually it's only necessary to add this into the nimbus and

[GitHub] storm pull request: STORM-1700 Introduce 'whitelist' / 'blacklist'...

2016-05-03 Thread unsleepy22
Github user unsleepy22 commented on a diff in the pull request: https://github.com/apache/storm/pull/1324#discussion_r61898673 --- Diff: storm-core/src/jvm/org/apache/storm/metric/filter/FilterByMetricName.java --- @@ -0,0 +1,93 @@ +/** + * Licensed to the Apache Software

[jira] [Issue Comment Deleted] (STORM-1758) Distributed log search doesn't work in dockerized environment

2016-05-03 Thread Elisey Zanko (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elisey Zanko updated STORM-1758: Comment: was deleted (was: That would work.) > Distributed log search doesn't work in dockerized

[jira] [Commented] (STORM-1761) Storm-Solr Example Throws ArrayIndexOutOfBoundsException in Remote Cluster Mode

2016-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15269948#comment-15269948 ] ASF GitHub Bot commented on STORM-1761: --- Github user HeartSaVioR commented on the pull request:

[GitHub] storm pull request: STORM-1761: Storm-Solr Example Throws ArrayInd...

2016-05-03 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/1394#issuecomment-216712023 +1 Nice finding. Btw, I guess it's due to inconsistencies between sample / test topologies, one argument for only specifying topology name, or two arguments

  1   2   >