[GitHub] storm issue #2283: Quick fix confusing exception message in ObjectReader.jav...

Github user srdo commented on the issue: https://github.com/apache/storm/pull/2283 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm issue #2279: Nitpicky cosmetic change - use "Uptime" instead of "UpTim...

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2279 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] storm issue #2278: Quick fix: remove duplicated IStormClusterState object in...

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2278 +1 Nice finding. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] storm issue #2284: [STORM-2695] Fix in docs: BlobStore uncompress argument s...

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2284 +1 Nice finding. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] storm issue #2278: Quick fix: remove duplicated IStormClusterState object in...

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2278 Thanks @Ethanlm, I merged into master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] storm pull request #2279: Nitpicky cosmetic change - use "Uptime" instead of...

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2279 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm pull request #2280: STORM-2500: remove call to waitUntilReady

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2280 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm issue #2283: Quick fix confusing exception message in ObjectReader.jav...

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2283 +1 Nice finding. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] storm issue #2268: STORM-2689: Simplify dependency configuration for storm-k...

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2268 @srdo +1 to remove DRPC demo in other examples rather than storm-starter. Please go ahead. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] storm pull request #2276: Fix typos in Worker.java

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2276 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm issue #2276: Fix typos in Worker.java

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2276 Thanks @ruili-kekeke merged into master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] storm issue #2279: Nitpicky cosmetic change - use "Uptime" instead of "UpTim...

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2279 Thanks @vitaliyf I merged into master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] storm pull request #2275: STORM-2692: Load only configs specific to the topo...

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2275 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm issue #2280: STORM-2500: remove call to waitUntilReady

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2280 +1 This fixes what #2142 already fixed, but no activity is seen on #2142 I'll just merge this. Travis CI fails on all JDK7 builds, hence not related to this. --- If your project is set

[GitHub] storm pull request #2285: Change OracleJDK7 to OpenJDK7 in Travis CI build

GitHub user HeartSaVioR opened a pull request: https://github.com/apache/storm/pull/2285 Change OracleJDK7 to OpenJDK7 in Travis CI build We've running issue on build failures on all PRs against 1.x version, due to using Oracle JDK 7 as JDK, which Oracle withdraws it. Same

[GitHub] storm pull request #2278: Quick fix: remove duplicated IStormClusterState ob...

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2278 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm pull request #2266: STORM-2682: Fixed issues with null owner

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2266 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm pull request #2267: STORM-2682: Fix issues with null owner on rolling ...

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2267 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm issue #2280: STORM-2500: remove call to waitUntilReady

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2280 @ZacharyThomas Thanks for the patch. I merged this but can't update assignee on issue (https://issues.apache.org/jira/browse/STORM-2500). Could you let me know your Apache JIRA ID?

[GitHub] storm issue #2280: STORM-2500: remove call to waitUntilReady

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2280 @ZacharyThomas Just updated. Thanks again for contributing! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] storm pull request #2286: fix not poll bug when use manual commit

GitHub user pczb opened a pull request: https://github.com/apache/storm/pull/2286 fix not poll bug when use manual commit You can merge this pull request into a Git repository by running: $ git pull https://github.com/pczb/storm master Alternatively you can review and apply

[GitHub] storm issue #2280: STORM-2500: remove call to waitUntilReady

Github user ZacharyThomas commented on the issue: https://github.com/apache/storm/pull/2280 @HeartSaVioR Thanks for the merge. My username on jira should be actking. Sorry I couldn't find anywhere to set assignee on Jira. --- If your project is set up for it, you can reply to this

[GitHub] storm issue #2280: STORM-2500: remove call to waitUntilReady

Github user ZacharyThomas commented on the issue: https://github.com/apache/storm/pull/2280 @HeartSaVioR It was fun. Encountered this while trying to debug the exclamation topology dying on a new cluster (see:

[GitHub] storm issue #2285: Change OracleJDK7 to OpenJDK7 in Travis CI build

Github user srdo commented on the issue: https://github.com/apache/storm/pull/2285 +1, good find --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] storm pull request #2284: [STORM-2695] Fix in docs: BlobStore uncompress arg...

GitHub user Ethanlm opened a pull request: https://github.com/apache/storm/pull/2284 [STORM-2695] Fix in docs: BlobStore uncompress argument should be Boolean See: https://issues.apache.org/jira/browse/STORM-2695 We need to update the doc for "uncompress" argument from

[GitHub] storm pull request #2282: STORM-2694: Add KafkaTupleListener to storm-kafka-...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2282#discussion_r133973452 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/EmptyKafkaTupleListener.java --- @@ -0,0 +1,35 @@ +package

[GitHub] storm pull request #2282: STORM-2694: Add KafkaTupleListener to storm-kafka-...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2282#discussion_r133971254 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaTupleListener.java --- @@ -0,0 +1,48 @@ +package

[GitHub] storm pull request #2282: STORM-2694: Add KafkaTupleListener to storm-kafka-...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2282#discussion_r133974197 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -73,7 +73,9 @@ // Strategy to determine the

[GitHub] storm pull request #2282: STORM-2694: Add KafkaTupleListener to storm-kafka-...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2282#discussion_r133973275 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaTupleListener.java --- @@ -0,0 +1,48 @@ +package

[GitHub] storm pull request #2283: Quick fix confusing exception message in ObjectRea...

GitHub user Ethanlm opened a pull request: https://github.com/apache/storm/pull/2283 Quick fix confusing exception message in ObjectReader.java The exception message like `Don't know how to convert false + to boolean` can be confusing. I deleted `+` You can merge this pull

[GitHub] storm pull request #2233: Storm 2258: Streams api - support CoGroupByKey

Github user arunmahadevan commented on a diff in the pull request: https://github.com/apache/storm/pull/2233#discussion_r133946658 --- Diff: docs/Stream-API.md --- @@ -276,6 +276,21 @@ PairStream scores = ... // list of scores per user in the last window, e.g.

[GitHub] storm pull request #2233: Storm 2258: Streams api - support CoGroupByKey

Github user arunmahadevan commented on a diff in the pull request: https://github.com/apache/storm/pull/2233#discussion_r133946510 --- Diff: docs/Stream-API.md --- @@ -276,6 +276,21 @@ PairStream scores = ... // list of scores per user in the last window, e.g.

[GitHub] storm pull request #2233: Storm 2258: Streams api - support CoGroupByKey

Github user arunmahadevan commented on a diff in the pull request: https://github.com/apache/storm/pull/2233#discussion_r133946525 --- Diff: docs/Stream-API.md --- @@ -276,6 +276,21 @@ PairStream scores = ... // list of scores per user in the last window, e.g.

[GitHub] storm pull request #2233: Storm 2258: Streams api - support CoGroupByKey

Github user arunmahadevan commented on a diff in the pull request: https://github.com/apache/storm/pull/2233#discussion_r133947663 --- Diff: storm-client/src/jvm/org/apache/storm/streams/processors/CoGroupByKeyProcessor.java --- @@ -0,0 +1,78 @@ +/** + * Licensed to the

[GitHub] storm pull request #2233: Storm 2258: Streams api - support CoGroupByKey

Github user arunmahadevan commented on a diff in the pull request: https://github.com/apache/storm/pull/2233#discussion_r133947083 --- Diff: storm-client/src/jvm/org/apache/storm/streams/PairStream.java --- @@ -380,6 +382,26 @@ return

[GitHub] storm pull request #2233: Storm 2258: Streams api - support CoGroupByKey

Github user arunmahadevan commented on a diff in the pull request: https://github.com/apache/storm/pull/2233#discussion_r133948483 --- Diff: storm-client/test/jvm/org/apache/storm/streams/processors/CoGroupByKeyProcessorTest.java --- @@ -0,0 +1,112 @@ +/** + * Licensed to

[GitHub] storm pull request #2233: Storm 2258: Streams api - support CoGroupByKey

Github user arunmahadevan commented on a diff in the pull request: https://github.com/apache/storm/pull/2233#discussion_r133947567 --- Diff: storm-client/src/jvm/org/apache/storm/streams/processors/CoGroupByKeyProcessor.java --- @@ -0,0 +1,78 @@ +/** + * Licensed to the