[GitHub] storm pull request #2345: STORM-2438: added in rebalance changes to support ...

Github user kishorvpatil commented on a diff in the pull request: https://github.com/apache/storm/pull/2345#discussion_r143501314 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/supervisor/Slot.java --- @@ -263,7 +314,41 @@ public String toString() {

[GitHub] storm pull request #2345: STORM-2438: added in rebalance changes to support ...

Github user kishorvpatil commented on a diff in the pull request: https://github.com/apache/storm/pull/2345#discussion_r143499778 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/supervisor/Slot.java --- @@ -104,9 +111,12 @@ this.port = port;

[GitHub] storm issue #2345: STORM-2438: added in rebalance changes to support RAS

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2345 For anyone interested I just rebased to fix a very minor merge conflict. ---

[GitHub] storm pull request #2361: STORM-2698: Upgrade to latest Mockito and Hamcrest

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2361 ---

[GitHub] storm issue #2361: STORM-2698: Upgrade to latest Mockito and Hamcrest

Github user srdo commented on the issue: https://github.com/apache/storm/pull/2361 Thanks for review @HeartSaVioR. Merged to master. ---

[GitHub] storm pull request #2363: STORM-2759: Let users indicate if a blob should re...

GitHub user revans2 opened a pull request: https://github.com/apache/storm/pull/2363 STORM-2759: Let users indicate if a blob should restart a worker This is based off of the changes in #2345. They are all in the first commit. The second commit has all of the newer changes for

[GitHub] storm pull request #2345: STORM-2438: added in rebalance changes to support ...

Github user kishorvpatil commented on a diff in the pull request: https://github.com/apache/storm/pull/2345#discussion_r143559023 --- Diff: storm-server/src/main/java/org/apache/storm/localizer/LocallyCachedBlob.java --- @@ -0,0 +1,220 @@ +/** + * Licensed to the Apache

[GitHub] storm issue #2362: Improve mention of aggregate() in the partitionAggregate(...

Github user srdo commented on the issue: https://github.com/apache/storm/pull/2362 Merged to master, 1.x and 1.1.x. ---

Re: [DISCUSS] Release Storm 1.0.5 / 1.1.2

Maybe we would be better off releasing 1.1.2 as is, and postponing the other issues to 1.2.0? I don't think we should delay the fix for https://issues.apache.org/jira/browse/STORM-2682 for much longer. 2017-09-22 14:50 GMT+02:00 Alexandre Vermeerbergen : > Hello, > > I

[GitHub] storm issue #2362: Improve mention of aggregate() in the partitionAggregate(...

Github user srdo commented on the issue: https://github.com/apache/storm/pull/2362 Thanks, +1 ---

[GitHub] storm issue #2203: STORM-2153: New Metrics Reporting API

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2203 This patch adds new types of metrics on top of current metrics, so performance hit is expected. (20% drop looks like not small indeed.) We may want to consider not supporting smooth transition

Storm pubsub spout? does one exist?

I asked this on the user list, but maybe it's a better question for the dev list. Has anyone built one to work with the Google cloud pubsub service? Not seeing one here: https://github.com/apache/storm/tree/master/external There is a raw beta java pubsub client here:

[GitHub] storm pull request #2345: STORM-2438: added in rebalance changes to support ...

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2345#discussion_r143575205 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/supervisor/Slot.java --- @@ -104,9 +111,12 @@ this.port = port;

[GitHub] storm issue #2345: STORM-2438: added in rebalance changes to support RAS

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2345 @kishorvpatil I think I addressed your review comments. If you really want the log message to be info I can do it. ---

[GitHub] storm issue #2356: STORM-2666 (1.x)

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2356 +1 The build ran fine locally with JDK 7. The Travis build failure came from stuck on AvroGenericRecordBoltTest in storm-hdfs with JDK 7, not in local but often in Travis CI build. ---

[GitHub] storm pull request #2356: STORM-2666 (1.x)

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2356 ---

[GitHub] storm pull request #2357: STORM-2666 (1.1.x)

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2357 ---

[GitHub] storm issue #2357: STORM-2666 (1.1.x)

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2357 +1 The build ran fine locally with JDK 7. The Travis build failure came from stuck on AvroGenericRecordBoltTest in storm-hdfs with JDK 7, not in local but often in Travis CI build. ---

Re: [DISCUSS] Release Storm 1.0.5 / 1.1.2

Stig, Let's just handle all the issues pending Storm 1.1.2. For pending issues on Storm 1.2.0, I already handled all the things. For STORM-2607, could you just take over and craft a new pull request? We are waiting more than 2 months after requesting simple rebase (sadly it is not done yet),

[GitHub] storm pull request #2364: [STORM-2772] In the DRPCSpout class, when the fetc...

GitHub user httfighter opened a pull request: https://github.com/apache/storm/pull/2364 [STORM-2772] In the DRPCSpout class, when the fetch from the DRPC server fails,the log should return to get the DRPC request failed instead of getting the DRPC result failed

[GitHub] storm pull request #2365: [STORM-2773]If a drpcserver node in cluster is dow...

GitHub user liu-zhaokun opened a pull request: https://github.com/apache/storm/pull/2365 [STORM-2773]If a drpcserver node in cluster is down,drpc cluster won't work if we don't modify the drpc.server configuration and restart the cluster

[GitHub] storm pull request #2362: Improve mention of aggregate() in the partitionAgg...

Github user F30 commented on a diff in the pull request: https://github.com/apache/storm/pull/2362#discussion_r143400447 --- Diff: docs/Trident-API-Overview.md --- @@ -484,7 +484,7 @@ public class Count implements CombinerAggregator { } ``` -The benefits of