Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2312
@govind-menon
Looks like duplicated PR and #2385 covers this. If I'm right let's close
this.
---
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2397
Looks like supporting 0.10.x in Storm 2.0.0 brings unnecessary pain. I'm
not sure we only missed this place. Maybe more, and finding more looks against
the intention for what we dropped
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2399
Looks like the patch addresses a bit different point rather than issue
description in STORM-2793.
Below is the issue description in STORM-2793:
> Existing Storm metrics track
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2399
And please change the title to 'STORM-2793 Track network data metrics' to
conform to
https://github.com/apache/storm/blob/master/DEVELOPER.md#create-a-pull-request
---
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2385
Just a curious: Does this patch address only STORM-2727, or all the things
in STORM-2725? The prefix of title of PR is STORM-2727, but the content is
STORM-2725 (more clear, just a epic name).
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/2398
STORM-2795: Fix race
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/revans2/incubator-storm STORM-2795
Alternatively you can review and apply
Github user satishd commented on the issue:
https://github.com/apache/storm/pull/2398
@revans2 You may want to change commit message with JIRA description.
---
Github user Ethanlm commented on the issue:
https://github.com/apache/storm/pull/2397
The build passed on my VM. Will try to build it on travis one more time.
---
Github user jmartell7 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2399#discussion_r148328791
--- Diff:
storm-client/src/jvm/org/apache/storm/messaging/DeserializingConnectionCallback.java
---
@@ -17,44 +17,102 @@
*/
package
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2399#discussion_r148330545
--- Diff: storm-client/src/jvm/org/apache/storm/messaging/netty/Server.java
---
@@ -249,6 +250,15 @@ public Object getState() {
}
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2399#discussion_r148327252
--- Diff: storm-client/src/jvm/org/apache/storm/Config.java ---
@@ -451,6 +451,12 @@
public static final String TOPOLOGY_METRICS_CONSUMER_REGISTER =
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2399#discussion_r148328186
--- Diff:
storm-client/src/jvm/org/apache/storm/messaging/DeserializingConnectionCallback.java
---
@@ -17,44 +17,102 @@
*/
package
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2399#discussion_r148328743
--- Diff:
storm-client/src/jvm/org/apache/storm/messaging/DeserializingConnectionCallback.java
---
@@ -17,44 +17,102 @@
*/
package
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2399#discussion_r148330213
--- Diff: storm-client/src/jvm/org/apache/storm/messaging/netty/Server.java
---
@@ -249,6 +250,15 @@ public Object getState() {
}
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2399#discussion_r148327705
--- Diff:
storm-client/src/jvm/org/apache/storm/messaging/DeserializingConnectionCallback.java
---
@@ -17,44 +17,102 @@
*/
package
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2399#discussion_r148328916
--- Diff:
storm-client/src/jvm/org/apache/storm/messaging/DeserializingConnectionCallback.java
---
@@ -17,44 +17,102 @@
*/
package
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2399#discussion_r148328987
--- Diff:
storm-client/src/jvm/org/apache/storm/messaging/DeserializingConnectionCallback.java
---
@@ -17,44 +17,102 @@
*/
package
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2399#discussion_r148329501
--- Diff:
storm-client/src/jvm/org/apache/storm/messaging/DeserializingConnectionCallback.java
---
@@ -17,44 +17,102 @@
*/
package
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2399#discussion_r148330111
--- Diff:
storm-client/src/jvm/org/apache/storm/messaging/DeserializingConnectionCallback.java
---
@@ -17,44 +17,102 @@
*/
package
19 matches
Mail list logo
