[GitHub] storm pull request #2411: STORM-2525 1.x

2017-11-11 Thread srdo
GitHub user srdo opened a pull request: https://github.com/apache/storm/pull/2411 STORM-2525 1.x Forgot to pull https://github.com/apache/storm/pull/2127 back to 1.x. Will squash when reviewed. You can merge this pull request into a Git repository by running: $ git

[GitHub] storm pull request #2414: Fixing Java unit tests in storm-core to run under ...

2017-11-11 Thread lawrencecraft
GitHub user lawrencecraft opened a pull request: https://github.com/apache/storm/pull/2414 Fixing Java unit tests in storm-core to run under Windows (1.x branch) While fixing STORM-2797 I noticed a bunch of the storm-core tests didn't run under Windows. I've fixed them up

[GitHub] storm pull request #2413: STORM-2810: Fix resource leaks in storm-hdfs tests

2017-11-11 Thread srdo
GitHub user srdo opened a pull request: https://github.com/apache/storm/pull/2413 STORM-2810: Fix resource leaks in storm-hdfs tests https://issues.apache.org/jira/browse/STORM-2810 The tests are leaking at least threads and HDFS file locks. Instead of cleaning up

[GitHub] storm issue #2413: STORM-2810: Fix resource leaks in storm-hdfs tests

2017-11-11 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2413 Reviewers might want to add ?w=1 to the diff url to disable whitespace diffing, some of the modified files were autoformatted from 2-space indentation to 4-space. ---

[GitHub] storm pull request #2414: Fixing Java unit tests in storm-core to run under ...

2017-11-11 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2414#discussion_r150402445 --- Diff: storm-core/test/jvm/org/apache/storm/daemon/supervisor/BasicContainerTest.java --- @@ -370,7 +370,7 @@ public void testLaunch() throws Exception {

[GitHub] storm pull request #2414: Fixing Java unit tests in storm-core to run under ...

2017-11-11 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2414#discussion_r150402295 --- Diff: storm-core/test/jvm/org/apache/storm/localizer/AsyncLocalizerTest.java --- @@ -62,15 +62,15 @@ public void testRequestDownloadBaseTopologyBlobs()

[GitHub] storm issue #2363: STORM-2759: Let users indicate if a blob should restart a...

2017-11-11 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2363 @revans2 Thanks. I opened https://issues.apache.org/jira/browse/STORM-2809. When I have some time I'll probably look at this too, to see if I can figure out what's going on. Regarding the 3

[GitHub] storm pull request #2412: STORM-2535: Replace test-reset-timeout with a more...

2017-11-11 Thread srdo
GitHub user srdo opened a pull request: https://github.com/apache/storm/pull/2412 STORM-2535: Replace test-reset-timeout with a more reliable test Pull https://github.com/apache/storm/pull/2141 to 1.x You can merge this pull request into a Git repository by running: $ git pull

[GitHub] storm pull request #2406: STORM-2807: Shut down integration test topologies ...

2017-11-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2406 ---