www.storm.incubator.apache.org

2018-03-19 Thread Derek Dagit
It seems there are still DNS records resolving this name. The page does not exist, and the server is presenting a TLS certificate that will not validate anyway. This site was the third hit for "apache storm" on one of my recent searches. It would be good to clean this up. -- Derek

[GitHub] storm issue #2599: [STORM-2996] Inaccurate description about offset and kafk...

2018-03-19 Thread liu-zhaokun
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2599 @HeartSaVioR Could you help me review this PR? ---

[GitHub] storm issue #2600: [STORM-2997] Add logviewer ssl module in SECURITY.md

2018-03-19 Thread liu-zhaokun
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2600 @HeartSaVioR Could you help me review this PR? ---

[GitHub] storm pull request #2587: [STORM-2987] PaceMakerStateStorage should deal wit...

2018-03-19 Thread Ethanlm
Github user Ethanlm commented on a diff in the pull request: https://github.com/apache/storm/pull/2587#discussion_r175557578 --- Diff: storm-client/src/jvm/org/apache/storm/cluster/PaceMakerStateStorage.java --- @@ -123,12 +124,15 @@ public void set_worker_hb(String path, byte[]

[GitHub] storm issue #460: [STORM-3000] added missing @Override annotations

2018-03-19 Thread krichter722
Github user krichter722 commented on the issue: https://github.com/apache/storm/pull/460 @d2r I rebased the branch, removed changes in classes generated by the Thrift compiler and included all subprojects. Since checkstyle is now in place I reviewed all `maxAllowedViolations` in POMs

[GitHub] storm pull request #2587: [STORM-2987] PaceMakerStateStorage should deal wit...

2018-03-19 Thread Ethanlm
Github user Ethanlm commented on a diff in the pull request: https://github.com/apache/storm/pull/2587#discussion_r175556789 --- Diff: storm-client/src/jvm/org/apache/storm/pacemaker/PacemakerClientPool.java --- @@ -54,25 +54,17 @@ public PacemakerClientPool(Map

[GitHub] storm issue #2577: [STORM-2977] BlowfishTupleSerializer tries to use zookeep...

2018-03-19 Thread Ethanlm
Github user Ethanlm commented on the issue: https://github.com/apache/storm/pull/2577 @HeartSaVioR @kishorvpatil Could you please review it when you get a chance? Thanks very much! ---

[GitHub] storm issue #459: avoiding rawtypes in IBold.prepare in order to allow usage...

2018-03-19 Thread krichter722
Github user krichter722 commented on the issue: https://github.com/apache/storm/pull/459 > I would either rename that Jira and update the description a bit, or open a new one. Once you've done that, add the jira number into the PR title - look at other Storm PRs for examples. >

[GitHub] storm pull request #2587: [STORM-2987] PaceMakerStateStorage should deal wit...

2018-03-19 Thread Ethanlm
Github user Ethanlm commented on a diff in the pull request: https://github.com/apache/storm/pull/2587#discussion_r175579245 --- Diff: storm-client/src/jvm/org/apache/storm/pacemaker/PacemakerClientPool.java --- @@ -54,25 +54,17 @@ public PacemakerClientPool(Map

[GitHub] storm issue #459: [STORM-2999] Add generics to static type of method paramet...

2018-03-19 Thread krichter722
Github user krichter722 commented on the issue: https://github.com/apache/storm/pull/459 > we can hold off if you want to clean up these unnecessary annotations. Done. ---

[GitHub] storm issue #459: [STORM-2999] Add generics to static type of method paramet...

2018-03-19 Thread krichter722
Github user krichter722 commented on the issue: https://github.com/apache/storm/pull/459 I just realized that this PR makes a lot of `@SuppressWarning("rawtypes")` unnecessary. What do you think about adding that as a second commit to this PR? ---

[GitHub] storm issue #459: [STORM-2999] Add generics to static type of method paramet...

2018-03-19 Thread d2r
Github user d2r commented on the issue: https://github.com/apache/storm/pull/459 > I just realized that this PR makes a lot of @SuppressWarning("rawtypes") unnecessary. What do you think about adding that as a second commit to this PR? @krichter722 Sorry for the delay; yes we

[GitHub] storm pull request #2587: [STORM-2987] PaceMakerStateStorage should deal wit...

2018-03-19 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2587#discussion_r175575089 --- Diff: storm-client/src/jvm/org/apache/storm/cluster/PaceMakerStateStorage.java --- @@ -123,12 +124,15 @@ public void set_worker_hb(String path, byte[]

[GitHub] storm pull request #2587: [STORM-2987] PaceMakerStateStorage should deal wit...

2018-03-19 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2587#discussion_r175576651 --- Diff: storm-client/src/jvm/org/apache/storm/pacemaker/PacemakerClientPool.java --- @@ -54,25 +54,17 @@ public PacemakerClientPool(Map

[GitHub] storm issue #459: [STORM-2999] Add generics to static type of method paramet...

2018-03-19 Thread knusbaum
Github user knusbaum commented on the issue: https://github.com/apache/storm/pull/459 +1 ---

[GitHub] storm issue #459: [STORM-2999] Add generics to static type of method paramet...

2018-03-19 Thread roshannaik
Github user roshannaik commented on the issue: https://github.com/apache/storm/pull/459 @krichter722 thanks for this! ---

[GitHub] storm pull request #2602: Update CuratorUtils.java

2018-03-19 Thread sagitta20
GitHub user sagitta20 opened a pull request: https://github.com/apache/storm/pull/2602 Update CuratorUtils.java If root isn't empty, there need a ',' before root You can merge this pull request into a Git repository by running: $ git pull https://github.com/sagitta20/storm

[GitHub] storm pull request #2599: [STORM-2996] Inaccurate description about offset a...

2018-03-19 Thread liu-zhaokun
GitHub user liu-zhaokun opened a pull request: https://github.com/apache/storm/pull/2599 [STORM-2996] Inaccurate description about offset and kafkaspout will make users confused [https://issues.apache.org/jira/browse/STORM-2996](https://issues.apache.org/jira/browse/STORM-2996)

[GitHub] storm pull request #2600: [STORM-2997] Add logviewer ssl module in SECURITY....

2018-03-19 Thread liu-zhaokun
GitHub user liu-zhaokun opened a pull request: https://github.com/apache/storm/pull/2600 [STORM-2997] Add logviewer ssl module in SECURITY.md [https://issues.apache.org/jira/browse/STORM-2997](https://issues.apache.org/jira/browse/STORM-2997) Add logviewer ssl module in

[GitHub] storm pull request #2598: storm-kafka: added ExponentialBackoffMsgRetryManag...

2018-03-19 Thread krichter722
GitHub user krichter722 opened a pull request: https://github.com/apache/storm/pull/2598 storm-kafka: added ExponentialBackoffMsgRetryManagerSpoutConfig Only `ExponentialBackoffMsgRetryManager` uses `SpoutConfig.retryInitialDelayMs`, `retryDelayMultiplier`, `retryDelayMaxMs` and

[GitHub] storm pull request #2601: [STORM-2998]Wrong className in LoggerFactory.getLo...

2018-03-19 Thread liu-zhaokun
GitHub user liu-zhaokun opened a pull request: https://github.com/apache/storm/pull/2601 [STORM-2998]Wrong className in LoggerFactory.getLogger method [https://issues.apache.org/jira/browse/STORM-2998](https://issues.apache.org/jira/browse/STORM-2998) If we use