[GitHub] [storm] krichter722 commented on a change in pull request #3037: STORM-3420: Fix checkstyle violations in storm-mqtt

2019-06-27 Thread GitBox
krichter722 commented on a change in pull request #3037: STORM-3420: Fix checkstyle violations in storm-mqtt URL: https://github.com/apache/storm/pull/3037#discussion_r298338698 ## File path: external/storm-mqtt/src/main/java/org/apache/storm/mqtt/common/MqttOptions.java

[GitHub] [storm] srdo commented on issue #3036: STORM-3421: Fix checkstyle violations in storm-kinesis

2019-06-27 Thread GitBox
srdo commented on issue #3036: STORM-3421: Fix checkstyle violations in storm-kinesis URL: https://github.com/apache/storm/pull/3036#issuecomment-506443257 +1 This is an automated message from the Apache Git Service. To

[GitHub] [storm] krichter722 opened a new pull request #3044: STORM-3426: Remove AbbreviationAsWordInName from checkstyle setup

2019-06-27 Thread GitBox
krichter722 opened a new pull request #3044: STORM-3426: Remove AbbreviationAsWordInName from checkstyle setup URL: https://github.com/apache/storm/pull/3044 This rule requires a lot of unconstructive renamings and doesn't have a huge impact on code quality.

[GitHub] [storm] krichter722 opened a new pull request #3045: STORM-3429: closure: fix all checkstyle warnings

2019-06-27 Thread GitBox
krichter722 opened a new pull request #3045: STORM-3429: closure: fix all checkstyle warnings URL: https://github.com/apache/storm/pull/3045 This is an automated message from the Apache Git Service. To respond to the

Re: Intellij can't resolve shaded dependencies

2019-06-27 Thread Stig Rohde Døssing
There's an intellij profile in the root pom. Does it no longer work? https://github.com/apache/storm/blob/fb76dd1c7dc39c4979f9cc921cf4a5930dfaa760/pom.xml#L377 Den tor. 27. jun. 2019 kl. 17.29 skrev Ethan Li : > Hi, > > If you checked out the latest community master branch code and your >

[GitHub] [storm] srdo commented on issue #3016: [STORM-3404]KafkaOffsetLagUtil cant pull the offset correctly

2019-06-27 Thread GitBox
srdo commented on issue #3016: [STORM-3404]KafkaOffsetLagUtil cant pull the offset correctly URL: https://github.com/apache/storm/pull/3016#issuecomment-506448397 Thanks for the fix @wxy929629, it's much appreciated. The fix only helps if the user is using PLAIN SASL, and won't

[GitHub] [storm] krichter722 opened a new pull request #3042: STORM-3418: Fix checkstyle violations in storm-hdfs-blobstore

2019-06-27 Thread GitBox
krichter722 opened a new pull request #3042: STORM-3418: Fix checkstyle violations in storm-hdfs-blobstore URL: https://github.com/apache/storm/pull/3042 This is an automated message from the Apache Git Service. To respond

[GitHub] [storm] krichter722 opened a new pull request #3046: STORM-3430: flux-wrappers: fix all checkstyle warnings

2019-06-27 Thread GitBox
krichter722 opened a new pull request #3046: STORM-3430: flux-wrappers: fix all checkstyle warnings URL: https://github.com/apache/storm/pull/3046 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [storm] srdo merged pull request #3036: STORM-3421: Fix checkstyle violations in storm-kinesis

2019-06-27 Thread GitBox
srdo merged pull request #3036: STORM-3421: Fix checkstyle violations in storm-kinesis URL: https://github.com/apache/storm/pull/3036 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [storm] srdo commented on a change in pull request #3037: STORM-3420: Fix checkstyle violations in storm-mqtt

2019-06-27 Thread GitBox
srdo commented on a change in pull request #3037: STORM-3420: Fix checkstyle violations in storm-mqtt URL: https://github.com/apache/storm/pull/3037#discussion_r298293950 ## File path: external/storm-mqtt/src/main/java/org/apache/storm/mqtt/common/MqttOptions.java ## @@

[GitHub] [storm] srdo commented on issue #3041: STORM-3427: integration-test: fix all checkstyle warnings

2019-06-27 Thread GitBox
srdo commented on issue #3041: STORM-3427: integration-test: fix all checkstyle warnings URL: https://github.com/apache/storm/pull/3041#issuecomment-506445277 +1 This is an automated message from the Apache Git Service. To

[GitHub] [storm] srdo merged pull request #3041: STORM-3427: integration-test: fix all checkstyle warnings

2019-06-27 Thread GitBox
srdo merged pull request #3041: STORM-3427: integration-test: fix all checkstyle warnings URL: https://github.com/apache/storm/pull/3041 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [storm] krichter722 opened a new pull request #3047: STORM-3431: rocketmq-examples: fix all checkstyle warnings

2019-06-27 Thread GitBox
krichter722 opened a new pull request #3047: STORM-3431: rocketmq-examples: fix all checkstyle warnings URL: https://github.com/apache/storm/pull/3047 This is an automated message from the Apache Git Service. To respond to

[GitHub] [storm] srdo merged pull request #3035: STORM-3417: Fix checkstyle violations in sql-core

2019-06-27 Thread GitBox
srdo merged pull request #3035: STORM-3417: Fix checkstyle violations in sql-core URL: https://github.com/apache/storm/pull/3035 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [storm] srdo merged pull request #3039: STORM-3424: storm-submit-tools: fix all checkstyle warnings

2019-06-27 Thread GitBox
srdo merged pull request #3039: STORM-3424: storm-submit-tools: fix all checkstyle warnings URL: https://github.com/apache/storm/pull/3039 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [storm] srdo commented on issue #3039: STORM-3424: storm-submit-tools: fix all checkstyle warnings

2019-06-27 Thread GitBox
srdo commented on issue #3039: STORM-3424: storm-submit-tools: fix all checkstyle warnings URL: https://github.com/apache/storm/pull/3039#issuecomment-506444715 +1 This is an automated message from the Apache Git Service. To

[GitHub] [storm] krichter722 opened a new pull request #3043: STORM-3428: kafka-monitor: fix all checkstyle warnings

2019-06-27 Thread GitBox
krichter722 opened a new pull request #3043: STORM-3428: kafka-monitor: fix all checkstyle warnings URL: https://github.com/apache/storm/pull/3043 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [storm] krichter722 opened a new pull request #3048: STORM-3432: solr-examples: fix all checkstyle warnings

2019-06-27 Thread GitBox
krichter722 opened a new pull request #3048: STORM-3432: solr-examples: fix all checkstyle warnings URL: https://github.com/apache/storm/pull/3048 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [storm] srdo merged pull request #3038: STORM-3419: Fix checkstyle violations in storm-opentsdb

2019-06-27 Thread GitBox
srdo merged pull request #3038: STORM-3419: Fix checkstyle violations in storm-opentsdb URL: https://github.com/apache/storm/pull/3038 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [storm] srdo commented on issue #3038: STORM-3419: Fix checkstyle violations in storm-opentsdb

2019-06-27 Thread GitBox
srdo commented on issue #3038: STORM-3419: Fix checkstyle violations in storm-opentsdb URL: https://github.com/apache/storm/pull/3038#issuecomment-506446071 +1, the test failure is unrelated. This is an automated message

[GitHub] [storm] srdo commented on issue #3037: STORM-3420: Fix checkstyle violations in storm-mqtt

2019-06-27 Thread GitBox
srdo commented on issue #3037: STORM-3420: Fix checkstyle violations in storm-mqtt URL: https://github.com/apache/storm/pull/3037#issuecomment-506503008 +1 once test passes This is an automated message from the Apache Git

Re: Intellij can't resolve shaded dependencies

2019-06-27 Thread Ethan Li
I tried but it doesn’t work for me > On Jun 27, 2019, at 12:20 PM, Stig Rohde Døssing > wrote: > > There's an intellij profile in the root pom. Does it no longer work? > https://github.com/apache/storm/blob/fb76dd1c7dc39c4979f9cc921cf4a5930dfaa760/pom.xml#L377 > > Den tor. 27. jun. 2019 kl.

Intellij can't resolve shaded dependencies

2019-06-27 Thread Ethan Li
Hi, If you checked out the latest community master branch code and your intellij can’t resolve the shaded dependencies, you could probably try this work around: https://youtrack.jetbrains.com/issue/IDEA-126596#focus=streamItem-27-757181.0-0

Re: [Discuss] ARM CI for Storm

2019-06-27 Thread Roshan Naik
Thanks for volunteering.  Sent from Yahoo Mail for iPhone On Wednesday, June 26, 2019, 7:08 PM, Yikun Jiang wrote: Yes, we will definitely help to fix ARM test failures in PRs, and the OpenLab CI will tell us which PR perhaps has ARM compatible problem, if it's an easy fix problem, I think