[GitHub] [storm] kishorvpatil commented on a change in pull request #3194: [STORM-3565] add support for adding dimensions to metric data points

2020-01-16 Thread GitBox
kishorvpatil commented on a change in pull request #3194: [STORM-3565] add support for adding dimensions to metric data points URL: https://github.com/apache/storm/pull/3194#discussion_r367405335 ## File path:

[GitHub] [storm] RuiLi8080 commented on a change in pull request #3194: [STORM-3565] add support for adding dimensions to metric data points

2020-01-16 Thread GitBox
RuiLi8080 commented on a change in pull request #3194: [STORM-3565] add support for adding dimensions to metric data points URL: https://github.com/apache/storm/pull/3194#discussion_r367519577 ## File path: storm-client/src/jvm/org/apache/storm/metric/api/IDimensionalMetric.java

[GitHub] [storm] kishorvpatil commented on issue #3150: STORM-3528: Allow users to provide their own custom TriggerPolicy/EvictionPolicy in BaseWindowBolt

2020-01-16 Thread GitBox
kishorvpatil commented on issue #3150: STORM-3528: Allow users to provide their own custom TriggerPolicy/EvictionPolicy in BaseWindowBolt URL: https://github.com/apache/storm/pull/3150#issuecomment-575318377 @joshi-aparna Could you please update the PR?

[GitHub] [storm] RuiLi8080 opened a new pull request #3195: [STORM-3567] fix UI showing wrong resource info when topo is not sche…

2020-01-16 Thread GitBox
RuiLi8080 opened a new pull request #3195: [STORM-3567] fix UI showing wrong resource info when topo is not sche… URL: https://github.com/apache/storm/pull/3195 …duled Currently topology UI page is showing wrong resource request info if the topo is not scheduled. This PR: 1.

[GitHub] [storm] kishorvpatil commented on issue #3180: 2.1.x branch

2020-01-16 Thread GitBox
kishorvpatil commented on issue #3180: 2.1.x branch URL: https://github.com/apache/storm/pull/3180#issuecomment-575317084 This is not patch for a PR. This should be STORM jira or issue. Closing this PR This is an automated

[GitHub] [storm] kishorvpatil closed pull request #3180: 2.1.x branch

2020-01-16 Thread GitBox
kishorvpatil closed pull request #3180: 2.1.x branch URL: https://github.com/apache/storm/pull/3180 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [storm] kishorvpatil closed pull request #3147: [STORM-3526]: Always override Login Config from System Property

2020-01-16 Thread GitBox
kishorvpatil closed pull request #3147: [STORM-3526]: Always override Login Config from System Property URL: https://github.com/apache/storm/pull/3147 This is an automated message from the Apache Git Service. To respond to

[GitHub] [storm] kishorvpatil commented on issue #3147: [STORM-3526]: Always override Login Config from System Property

2020-01-16 Thread GitBox
kishorvpatil commented on issue #3147: [STORM-3526]: Always override Login Config from System Property URL: https://github.com/apache/storm/pull/3147#issuecomment-575319236 Closing this as #3176 is merged. This is an

[GitHub] [storm] kishorvpatil commented on issue #3187: Add s390x support for Travis

2020-01-16 Thread GitBox
kishorvpatil commented on issue #3187: Add s390x support for Travis URL: https://github.com/apache/storm/pull/3187#issuecomment-575316237 Can you please prefix the title and commit with MINOR to suggest this is a minor change.