Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1591
@hsun-cnnxty
Sorry I lost tracking this.
From the last time I tested on my local machine (via ThroughputVsLatency),
before patching this works better than after patching this. My test
Github user hsun-cnnxty commented on the issue:
https://github.com/apache/storm/pull/1591
Tests are done to compare following two code bases:
- baseline: current head of 1.x-branch
(62476f5237a72938c1f0d3fe65dbcdc446a2bd12)
- netty 4.1.x: 1.x-branch-netty4
Github user hsun-cnnxty commented on the issue:
https://github.com/apache/storm/pull/1591
@HeartSaVioR
I rebased to 1.x-branch and also squashed the commits. Will attached the
performance test results soon.
---
If your project is set up for it, you can reply to this email and
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1591
Please rebase and force push accordingly. Your PR now has all of the
commits from other side.
You can give it an another try: 1) create new branch based on recent master
or 1.x 2)
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1591
Since Netty made 3.x version line EOL, I'd like to bump Netty to 4.0.x or
even 4.1.x if there's no performance / resource usage issue.
@hsun-cnnxty
Please upmerge this. If you
Github user hsun-cnnxty commented on the issue:
https://github.com/apache/storm/pull/1591
@satishd nett 4.x has removed auto-flush in write() and it requires user to
explicitly call flush() or writeAndFlush(), so we need to flush for the last
message in the logic flow. Fortunately,
Github user satishd commented on the issue:
https://github.com/apache/storm/pull/1591
@hsun-cnnxty `Channel#write` is modified to `Channel#writeAndFlush` at
multiple places. Does not that flush to the underlying stream without buffering
and flush it when buffers are full?
---
If
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1591
You can close and reopen this PR to retrigger. Btw, apache repository seems
to be unstable recent days. I saw other build failures due to repository
connectivity issue.
---
If your project is
Github user hsun-cnnxty commented on the issue:
https://github.com/apache/storm/pull/1591
Seems the Travis CI build will fail at random places which are not related
to this PR.
For example the last build failed due to
`[ERROR] Failed to execute goal
Github user hsun-cnnxty commented on the issue:
https://github.com/apache/storm/pull/1591
Performance test results are attached here.
[perf_compare_netty_3vs4_1.x-branch.zip](https://github.com/apache/storm/files/392165/perf_compare_netty_3vs4_1.x-branch.zip)
Baseline:
10 matches
Mail list logo
