Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1674
I've crafted rebased version of this patch to #2343. I've pinged to @nilday
for some period but didn't receive feedback so I thought it's OK to take it
over with preserving the credit.
---
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1674
@nilday Sure, please take your time. Thanks for keeping interest of
contributing. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user nilday commented on the issue:
https://github.com/apache/storm/pull/1674
@HeartSaVioR I'll rebase it as soon as I can. As the storm-core has been
restructured, it may take a while.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1674
This feature looks like good thing to adopt. If @nilday is still willing to
adopt this to the Storm codebase, I'd like to spend some time to review this as
well.
@nilday Could you rebase
Github user nilday commented on the issue:
https://github.com/apache/storm/pull/1674
As soon as I find out that nimbus has been transferred to Java, I start to
work on this again. The blacklist scheduler has been working on our production
environment(Storm v1.0.1) for several months
Github user nilday commented on the issue:
https://github.com/apache/storm/pull/1674
Thanks for you all guys. I will consider seriously all your suggestions.
But currently I'll be still working on 1.0.x branch ,since my company has
just update to 1.0 version and master branch is
Github user nilday commented on the issue:
https://github.com/apache/storm/pull/1674
@HeartSaVioR not yet, busy with something else. Will do it as soon as I
have some time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1674
@nilday Do you have any updates?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/1674
In addition to the ones @vesense noted, there are many other operators
without spaces around them. Adding space around `=`, `+`, `:`, `<`, etc, will
make the code more readable.
---
If your
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1674
Thanks @revans2 for the details. get it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/1674
@revans2 +1 for that. That's simpler to understand and implement.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1674
For me either the supervisor works or it does not. If it doesn't work
don't use it. If it is slightly better then another supervisor does not tell
me much. If too many don't work let someone know
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/1674
We could just have some "relative badness" heuristic. I would expect the
supervisors would be in a bell curve of "goodness/badness" and we can just
blacklist the ones in the bad part of the tail,
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1674
Agree with @revans2 's opinion. Especially, make this feature as a part of
nimbus and show the blacklist nodes on the UI.
For the third point, I feel we can add a task(eg: `ping` the standby
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1674
Overall I like the concept here, and if a supervisor is
appearing/disappearing a lot we probably do want to blacklist that supervisor.
That said I have a few system concerns.
1) I would
15 matches
Mail list logo
