Github user clockfly closed the pull request at:
https://github.com/apache/storm/pull/120
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user clockfly commented on the pull request:
https://github.com/apache/storm/pull/120#issuecomment-146773478
Sure.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user d2r commented on the pull request:
https://github.com/apache/storm/pull/120#issuecomment-146644953
@clockfly , It seems this pull request was superseded by #495, and
STORM-188 has been resolved. Would you close this pull request?
---
If your project is set up for it,
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/495
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/495#issuecomment-89409291
I think overall it is good and I am +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user lazyval commented on a diff in the pull request:
https://github.com/apache/storm/pull/495#discussion_r27562061
--- Diff: storm-core/src/jvm/backtype/storm/utils/Utils.java ---
@@ -135,35 +137,68 @@ public static void sleep(long millis) {
}
public
Github user lazyval commented on a diff in the pull request:
https://github.com/apache/storm/pull/495#discussion_r27561516
--- Diff: storm-core/src/jvm/backtype/storm/utils/Utils.java ---
@@ -135,35 +137,68 @@ public static void sleep(long millis) {
}
public
Github user lazyval commented on a diff in the pull request:
https://github.com/apache/storm/pull/495#discussion_r27562802
--- Diff: storm-core/src/jvm/backtype/storm/utils/Utils.java ---
@@ -135,35 +137,68 @@ public static void sleep(long millis) {
}
public
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/storm/pull/495#discussion_r27561927
--- Diff: storm-core/src/jvm/backtype/storm/utils/Utils.java ---
@@ -135,35 +137,68 @@ public static void sleep(long millis) {
}
Github user lazyval commented on a diff in the pull request:
https://github.com/apache/storm/pull/495#discussion_r27571878
--- Diff: storm-core/src/jvm/backtype/storm/utils/Utils.java ---
@@ -135,35 +137,68 @@ public static void sleep(long millis) {
}
public
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/495#discussion_r27571219
--- Diff: storm-core/src/jvm/backtype/storm/utils/Utils.java ---
@@ -135,35 +137,68 @@ public static void sleep(long millis) {
}
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/495#discussion_r27572921
--- Diff: storm-core/src/jvm/backtype/storm/utils/Utils.java ---
@@ -135,35 +137,68 @@ public static void sleep(long millis) {
}
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/495#issuecomment-88537973
@clockfly @lazyval updated the patch for fixing the last comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/495#discussion_r27584483
--- Diff: storm-core/src/jvm/backtype/storm/utils/Utils.java ---
@@ -135,35 +137,68 @@ public static void sleep(long millis) {
}
Github user lazyval commented on the pull request:
https://github.com/apache/storm/pull/495#issuecomment-88550651
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user manuzhang commented on the pull request:
https://github.com/apache/storm/pull/120#issuecomment-88018456
guys, any updates on issue ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/495#issuecomment-88204014
This PR is taken from
https://github.com/apache/storm/pull/120#issuecomment-69435220
@clockfly @revans2 can you please take a look.
---
If your project is set
GitHub user harshach opened a pull request:
https://github.com/apache/storm/pull/495
STORM-188. Allow user to specifiy full configuration path when running
storm command
You can merge this pull request into a Git repository by running:
$ git pull
Github user clockfly commented on the pull request:
https://github.com/apache/storm/pull/495#issuecomment-88295467
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user clockfly commented on the pull request:
https://github.com/apache/storm/pull/120#issuecomment-69435220
@revans,
Feel free to do what you want, change it, or replace it.:)
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/120#discussion_r20513760
--- Diff: storm-core/src/jvm/backtype/storm/utils/Utils.java ---
@@ -122,36 +124,64 @@ public static void sleep(long millis) {
}
}
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/120#issuecomment-63492543
I just had one comment, to avoid YAML doing some potentially unsafe things,
but it is not that critical, because placing a --config on the command line is
going to use a
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/120#discussion_r20514725
--- Diff: storm-core/src/jvm/backtype/storm/utils/Utils.java ---
@@ -122,36 +124,64 @@ public static void sleep(long millis) {
}
}
Github user clockfly commented on the pull request:
https://github.com/apache/storm/pull/120#issuecomment-63431309
The original behavior of findAndReadConfigFile() is to locate config file
on classpath.
findResources(name) will not be empty when name exists on classpath.
Github user clockfly commented on the pull request:
https://github.com/apache/storm/pull/120#issuecomment-61599764
@d2r , sorry it takes so long.
Now, the patch is synced with upstream.
---
If your project is set up for it, you can reply to this email and have your
25 matches
Mail list logo
