Re: Portlet 2.0 Plugin was moved to trunk

2011-06-24 Thread Lukasz Lenart
2011/6/23 Johannes Geppert jo...@apache.org: I have copied the latest version of the Portlet 1.0 Plugin to the archive and replaced the version in trunk with the sandbox version. Also i have made same small changes on the Portlet Sample App which is running fine in jetspeed for me with the new

Re: Portlet 2.0 Plugin was moved to trunk

2011-06-24 Thread Nils-Helge Garli Hegvik
Just did an update from trunk, and the tests ran fine with me (Java 1.6.0, Maven 2.2.1). Nils-H On Thu, Jun 23, 2011 at 11:24 PM, Johannes Geppert jo...@apache.org wrote: Hi Guys, I have copied the latest version of the Portlet 1.0 Plugin to the archive and replaced the version in trunk with

Re: Portlet 2.0 Plugin was moved to trunk

2011-06-24 Thread Lukasz Lenart
There is a new key [1] in PortletRequest and what I've read it was introduced in Portlet 2.0 spec. It's ok, just change the test, right ? [1] javax.portlet.lifecycle_phase Regards -- Łukasz + 48 606 323 122 http://www.lenart.org.pl/ Warszawa JUG conference - Confitura http://confitura.pl/

Re: Portlet 2.0 Plugin was moved to trunk

2011-06-24 Thread Johannes Geppert
@Nils I have temporary commented out this part. @Lukasz You are right the third attribute is the javax.portlet.lifecycle_phase, but I am a little bit confused about it because this Test runs fine in the Sandbox Version. Johannes - web: http://www.jgeppert.com twitter:

Re: Portlet 2.0 Plugin was moved to trunk

2011-06-24 Thread Johannes Geppert
@Nils I have temporary commented out this part. @Lukasz You are right the third attribute is the javax.portlet.lifecycle_phase, but I am a little bit confused about it because this Test runs fine in the Sandbox Version. Johannes - web: http://www.jgeppert.com twitter:

Re: Portlet 2.0 Plugin was moved to trunk

2011-06-24 Thread Lukasz Lenart
2011/6/24 Johannes Geppert jo...@apache.org: @Lukasz You are right the third attribute is the javax.portlet.lifecycle_phase, but I am a little bit confused about it because this Test runs fine in the Sandbox Version. What version of Spring is used in sandbox ? Regards -- Łukasz + 48 606

Re: Portlet 2.0 Plugin was moved to trunk

2011-06-24 Thread Johannes Geppert
Lukasz you are right changing the Spring Version in the Sandbox raises also the Failure. I have modified the Test like your suggestion. Johannes - web: http://www.jgeppert.com twitter: http://twitter.com/jogep -- View this message in context:

Re: Portlet 2.0 Plugin was moved to trunk

2011-06-24 Thread Rene Gielen
Great work, Johannes! The only thing that concerns me a bit is that we seem to have lost the commit history of the new plugin, since you have applied the sandbox sources as patch to the current plugin. The history how p1 mutated to p2 is imo important ... How do others feel about this? It's not

Build failed in Jenkins: Struts2 » Struts 2 GXP Plugin #324

2011-06-24 Thread Apache Jenkins Server
See https://builds.apache.org/job/Struts2/org.apache.struts$struts2-gxp-plugin/324/ -- [JENKINS] Archiving /home/hudson/hudson-slave/workspace/Struts2/struts2/plugins/embeddedjsp/pom.xml to

Build failed in Jenkins: Struts2 » Struts 2 Embedded JSP Plugin #324

2011-06-24 Thread Apache Jenkins Server
See https://builds.apache.org/job/Struts2/org.apache.struts$struts2-embeddedjsp-plugin/324/ -- [JENKINS] Archiving /home/hudson/hudson-slave/workspace/Struts2/struts2/plugins/json/pom.xml to

Build failed in Jenkins: Struts2 #324

2011-06-24 Thread Apache Jenkins Server
See https://builds.apache.org/job/Struts2/324/changes Changes: [jogep] WW-3620: Bring Portlet 2.0 (JSR286) plugin from sandbox to trunk -- [...truncated 6907 lines...] [INFO] --- maven-bundle-plugin:2.1.0:manifest (bundle-manifest) @

Re: Portlet 2.0 Plugin was moved to trunk

2011-06-24 Thread Nils-Helge Garli Hegvik
It's probably because of an updated spring mock dependency. The MockPortletRequest object has this line of code: attributes.put(javax.portlet.lifecycle_phase, getLifecyclePhase()); So the test should be rewritten to not be dependent on the number of elements in the entry set, but rather that the

Re: Portlet 2.0 Plugin was moved to trunk

2011-06-24 Thread Martin Cooper
On Fri, Jun 24, 2011 at 12:44 AM, Rene Gielen gie...@it-neering.net wrote: Great work, Johannes! The only thing that concerns me a bit is that we seem to have lost the commit history of the new plugin, since you have applied the sandbox sources as patch to the current plugin. The history how