Re: svn_wc_translated_file3

On Sat, 2010-08-07, Stefan Küng wrote: > On 07.08.2010 12:52, Daniel Shahaf wrote: > > What's the solution? > > I'm using svn_wc_get_pristine_copy_path() and disable the deprecated > warnings for that API call. I won't get a translated file that way, but > most if not all UI diff tools have opti

RE: svn_wc_translated_file3

On Mon, 2010-08-09, Bert Huijben wrote: > Stefan Küng wrote: > > This leads me to another request: would it be possible to 'un-deprecate' > > the svn_wc_get_pristine_copy_path() API? > One of the ideas of WC-NG (which will most likely not be part of 1.7, but > can be added later without really upd

RE: svn_wc_translated_file3

On Mon, 2010-08-09, Julian Foad wrote: > On Mon, 2010-08-09, Bert Huijben wrote: > > Stefan Küng wrote: > > > This leads me to another request: would it be possible to 'un-deprecate' > > > the svn_wc_get_pristine_copy_path() API? > > > One of the idea

Re: svn commit: r983807 - in /subversion/branches/atomic-revprop/subversion: include/svn_error.h libsvn_subr/error.c

On Mon, 2010-08-09, danie...@apache.org wrote: > > +/** Return TRUE if @a err's chain contains the error code @a apr_err. > + * > + * @since New in 1.7. > + */ > +svn_boolean_t > +svn_error_has_cause(svn_error_t *err, apr_status_t apr_err); This looks like it could be a useful API. I would expe

Re: svn commit: r983720 - in /subversion/trunk/subversion: libsvn_client/repos_diff.c tests/cmdline/diff_tests.py

On Mon, 2010-08-09, sbut...@apache.org wrote: > Fix issue 2333 "diff URL1 URL2 not reverse of diff URL2 URL1". When > the repository reports a deleted directory, recursively walk the > directory (in the repository) and report files as deleted. > > TODO: Handle non-infinite depth correctly. > > R

Re: svn commit: r983807 - in /subversion/branches/atomic-revprop/subversion: include/svn_error.h libsvn_subr/error.c

On Tue, 2010-08-10 at 15:04 +0300, Daniel Shahaf wrote: > (I intended to commit that to trunk) > > Julian Foad wrote on Tue, Aug 10, 2010 at 12:17:24 +0100: > > On Mon, 2010-08-09, danie...@apache.org wrote: > > > > > > +/** Return TRUE if @a err's ch

Re: svn commit: r983807 - in /subversion/branches/atomic-revprop/subversion: include/svn_error.h libsvn_subr/error.c

On Tue, 2010-08-10, Daniel Shahaf wrote: > Julian Foad wrote on Tue, Aug 10, 2010 at 13:48:20 +0100: > > On Tue, 2010-08-10 at 15:04 +0300, Daniel Shahaf wrote: > > > I can see several options: > > > > > > * forbid passing SVN_NO_ERROR > > > * return

Upgrade to single-DB: problem locking an empty DB

Upgrading a WC to single-DB: upgrade_to_wcng() calls svn_wc__db_upgrade_begin() to create a new DB, and then svn_wc__db_wclock_obtain() and then svn_wc__write_upgraded_entries() The _wclock_obtain() fails because it checks that the node with relpath "" exists. Normally in libsvn_wc a new

Re: Upgrade to single-DB: problem locking an empty DB

On Tue, 2010-08-10 at 15:31 +0100, Julian Foad wrote: > Upgrading a WC to single-DB: > > upgrade_to_wcng() calls > > svn_wc__db_upgrade_begin() to create a new DB, and then > svn_wc__db_wclock_obtain() and then > svn_wc__write_upgraded_entries() > > The _wcloc

Re: Upgrade to single-DB: problem locking an empty DB

On Tue, 2010-08-10 at 16:26 +0100, Julian Foad wrote: > On Tue, 2010-08-10 at 15:31 +0100, Julian Foad wrote: > > Upgrading a WC to single-DB: > > > > upgrade_to_wcng() calls > > > > svn_wc__db_upgrade_begin() to create a new DB, and then > >

RE: Bikeshed: configuration override order

On Tue, 2010-08-10 at 17:12 +0100, Bolstridge, Andrew wrote: > > Summary... > > > > There are two issues here... > > > > 1. The repo admin wants to enforce what is commited to their repo. > This > > exists with scripts but common request can be made inherient repo > settings > > (probably need to

Re: NODE_DATA (2nd iteration)

Any responses would be greatly appreciated. - Julian On Tue, 2010-08-03, Julian Foad wrote: > On Mon, 2010-07-12, Erik Huelsmann wrote: > > After lots of discussion regarding the way NODE_DATA/4th tree should > > be working, I'm now ready to post a summary of the progress. I

Re: Bikeshed: configuration override order

On Tue, 2010-08-10, C. Michael Pilato wrote: > On 08/10/2010 01:10 PM, C. Michael Pilato wrote: > > On 08/10/2010 12:15 PM, Julian Foad wrote: > >> On Tue, 2010-08-10 at 17:12 +0100, Bolstridge, Andrew wrote: > >>>> Summary... > >>>> > >>

Re: Bikeshed: configuration override order

On Tue, 2010-08-10, C. Michael Pilato wrote: > On 08/10/2010 01:25 PM, Julian Foad wrote: > > Oh? All I know about Andrew's particular requirements related to this > > query is what's quoted above - "If I ... accidentally leave the banned > > buildlog.htm file

Re: svn commit: r984208 - /subversion/branches/ignore-mergeinfo/subversion/libsvn_client/status.c

On Tue, 2010-08-10, hwri...@apache.org wrote: > Author: hwright > Date: Tue Aug 10 20:59:29 2010 > New Revision: 984208 > > URL: http://svn.apache.org/viewvc?rev=984208&view=rev > Log: > On the ignore-mergeinfo branch: > Fix a cast which was causing a segfault in stat test 32 as a result of the >

Re: svn commit: r984007 - /subversion/trunk/subversion/libsvn_wc/update_editor.c

On Tue, 2010-08-10, rhuij...@apache.org wrote: > Author: rhuijben > Date: Tue Aug 10 13:46:57 2010 > New Revision: 984007 > > URL: http://svn.apache.org/viewvc?rev=984007&view=rev > Log: > * subversion/libsvn_wc/update_editor.c > (cleanup_dir_baton): When calling wq_run() from pool cleanup, don'

Re: Looking to improve performance of svn annotate

On Wed, 2010-08-11, Johan Corveleyn wrote: > Hi all, > > Other priorities have unfortunately kept me from focusing on the > project of speeding up blame. But recently I've spent some time > thinking about it, reading the other mail threads, studying the code > and profiling a little bit. I hope I

Re: [atomic-revprops] status update

On Wed, 2010-08-11, Stefan Sperling wrote: > The BRANCH-README suggest that we add an interface like > 'svn propedit --revprop pname pval2 --old-value=pval'. > I don't think there is a valid use case for non-atomic revprop changes. > Why not just make all revprop changes atomic by default if the

Re: NOTICE: Testing over ra-dav has changed in trunk!!

On Tue, 2010-08-10, C. Michael Pilato wrote: > Per the commit's log message: > > On 08/10/2010 09:38 PM, cmpil...@apache.org wrote: > > Author: cmpilato > > Date: Wed Aug 11 01:38:40 2010 > > New Revision: 984280 > > [...] > > > NOTE: The test suite changes brought in by this merge require > >

RE: NOTICE: Testing over ra-dav has changed in trunk!!

Bert Huijben wrote: > From: Julian Foad [mailto:julian.f...@wandisco.com] > > > > NOTE: The test suite changes brought in by this merge require > > > > modifications to developers' httpd.conf files. So if you see the > > > > redirect_tests.py all f

Re: svn_wc_translated_file3

On Mon, 2010-08-09, Stefan Küng wrote: > On 09.08.2010 16:44, Hyrum K. Wright wrote: > > On Mon, Aug 9, 2010 at 7:46 AM, Julian Foad > > wrote: > >> On Mon, 2010-08-09, Julian Foad wrote: > >>> On Mon, 2010-08-09, Bert Huijben wrote: > >>>>

[RFC] Change svn_wc_add_repos_file4(copyfrom_url) to (_root, _relpath)

svn_wc_add_repos_file4(..., copyfrom_url, ...) has a check that says, "If copyfrom_url isn't in the same repository as the WC target parent dir, then SVN_ERR_UNSUPPORTED_FEATURE." Semantically, yes, copying from another repos isn't yet supported. But the check for that should be at a higher an

Re: Looking to improve performance of svn annotate

On Thu, 2010-08-12, C. Michael Pilato wrote: > In times past, I've wondered if the server couldn't just store line-delta > information -- as a comparison between each FS DAG node and its immediate > predecessor -- similar to the way that CVS does (and in addition to the > stuff it already stores, o

[PATCH] Tweak description of BASE_NODE table

Can someone check this before I commit? [[[ Index: subversion/libsvn_wc/wc_db.h === --- subversion/libsvn_wc/wc_db.h(revision 984862) +++ subversion/libsvn_wc/wc_db.h(working copy) @@ -438,14 +438,19 @@ svn_wc__db_get_

Re: svn commit: r966822 - in /subversion/trunk/subversion: libsvn_client/repos_diff.c tests/cmdline/merge_tests.py

On Thu, 2010-08-12, Paul Burba wrote: > I'm working on that approach, but in the meantime I have a question > about the behavior of svn diff --summarize when describing the > addition of paths with properties. > > ### Let's take a vanilla greek tree, add a file and directory, > ### set a prop on e

Re: svn commit: r985514 - stream_move_mark()

On Sat, 2010-08-14, stef...@apache.org wrote: > Log: > Extend the stream API by three functions: > svn_stream_move_mark() to move an existing mark by some delta Hi Stefan. Unfortunately this is not a logical extension to the stream API. Subversion's svn_stream_t streams support arbitrary "filteri

Re: svn commit: r985514 - stream_move_mark()

On Mon, 2010-08-16 at 09:55 +0100, Julian Foad wrote: > On Sat, 2010-08-14, stef...@apache.org wrote: > > Log: > > Extend the stream API by three functions: > > svn_stream_move_mark() to move an existing mark by some delta > > Hi Stefan. > > Unfortunately this

Re: svn commit: r966822 - in /subversion/trunk/subversion: libsvn_client/repos_diff.c tests/cmdline/merge_tests.py

Stephen Butler wrote: > On Aug 16, 2010, at 10:40 , Julian Foad wrote: > > I would suggest that the output of "svn diff --summarize" should be > > consistent with the likes of "svn add" (no 'M'), "svn status" (no 'M') > > and

Re: Returning revprops through commit info

On Thu, 2010-08-12, Hyrum K. Wright wrote: > Recently, we've updated the various client APIs which do commits to > return commit info back through a callback[1], since they may be > extended to perform multiple commits (see issue #1199 for instance). > In doing so, I've had the opportunity to take

Re: [PATCH] Tweak description of BASE_NODE table

On Thu, 2010-08-12, Greg Stein wrote: > Looks good! Committed. Now I'm trying to understand and document BASE_NODE (first) in more detail. Then I/we can tackle the other tables, and especially it should give me (and anyone else who may be struggling to follow) a starting point for understanding

Re: svn commit: r985514 - stream_move_mark()

On Wed, 2010-08-18, Stefan Sperling wrote: > On Tue, Aug 17, 2010 at 11:57:11PM +0200, Stefan Fuhrmann wrote: > > I overgeneralized my use-case here: I actually needed "move forward" only. > > The concept of "skip N bytes", however, is perfectly in line with > > the general > > stream semantics. Be

Re: 1.7 and obliterate

On Wed, 2010-08-18, C. Michael Pilato wrote: > What's the status of obliterate? Heh. I started down a path that looked promising initially but became ever more difficult. The parts that are checked in are the easy parts - hook script support and some ability to remove node-revs from the reposito

NODE_DATA discussions

Hyrum, Eric H., Philip M. and I met up at WANdisco's office in Sheffield (England) yeterday and today. One of the things we discussed was NODE_DATA. We discussed several sub-topics, of which here are two. I've written these up including my further thoughts which weren't part of the discussion, s

Re: [PATCH] add docstrings to libsvn_ra_neon's 207 XML parser

On Fri, 2010-08-20, Daniel Shahaf wrote: > I arrived at these docstrings by reverse-engineering the implementation > and some guesses. Could someone confirm my understanding? > > [[[ > * subversion/libsvn_ra_neon/util.c > (multistatus_elements, multistatus_nesting_table, validate_element): >

Upgrade from 1.6 must use the same incremental steps? [was: svn commit: r987526 - ...]

On Fri, 2010-08-20, Greg Stein wrote: > On Fri, Aug 20, 2010 at 10:31, wrote: > > +++ subversion/trunk/subversion/libsvn_wc/upgrade.c Fri Aug 20 14:31:27 2010 > > @@ -1420,9 +1420,7 @@ svn_wc__upgrade_sdb(int *result_format, > > /* ### TODO: Either upgrade to single-DB format here, or qu

[RFC] 'External' and 'Switched': common ground

What's the idea? External means Switched === Well, not quite! But at the WC layer they have a lot in common. Let's take advantage of it. In both cases: * An 'external' or 'switched' WC node is a file or a directory (tree). * An 'external' or 'switched' WC node is an

Re: Performance branch - svnserve crash in fs_history_prev

On Mon, 2010-08-23, Lieven Govaerts wrote: > Either you forgot the attachments, or they were dropped by our mailing > sw. Try adding a .txt extension. AFAIK, the mailing list strips attachments of MIME type 'application/octet-stream' and a bunch of other types - see

Re: svn commit: r987592 - /subversion/trunk/subversion/libsvn_ra_neon/util.c

On Fri, 2010-08-20, Greg Stein wrote: > On Fri, Aug 20, 2010 at 13:58, wrote: > >... > > +++ subversion/trunk/subversion/libsvn_ra_neon/util.c Fri Aug 20 17:58:10 > > 2010 > >... > > -static ne_xml_parser * > > +/* Create a status parser attached to the request REQ. Detected errors > > + will

Re: [RFC] 'External' and 'Switched': common ground

On Fri, 2010-08-20 at 20:01 +0200, Stefan Küng wrote: > On 20.08.2010 19:54, Julian Foad wrote: > >* An 'external' or 'switched' WC node is an immediate child of a > > versioned WC directory. [3] > > Don't forget that an external does not

Re: [RFC/PATCH] Create a fresh svn_repos_parse_fns3_t

On Thu, 2010-08-19 at 10:25 +0300, Daniel Shahaf wrote: > Ramkumar Ramachandra wrote on Thu, Aug 19, 2010 at 11:12:14 +0530: > > Hi, > > > > I sent a patch a while ago for svn_repos_parse_dumpstream3. While I > > wait for approval, this is an RFC patch describing my future plan once > > that patch

RE: [RFC] 'External' and 'Switched': common ground

ent behavioural differences, but in re-implementing file externals handling, it's unquestionably the "directory externals" behaviour that we need to be heading for. On Fri, 2010-08-20, Bert Huijben wrote: > > -Original Message- > > From: Julian Foad [mailto:julian.f

Re: merging into locally added files

On Mon, 2010-08-23 at 18:43 +0200, Stefan Sperling wrote: > On Wed, Aug 04, 2010 at 12:32:06PM -0400, Paul Burba wrote: > > On Wed, Aug 4, 2010 at 12:14 PM, Julian Foad > > wrote: > > > On Wed, 2010-08-04 at 11:23 -0400, Paul Burba wrote: > > >> On Wed,

Re: merging into locally added files

On Mon, 2010-08-23 at 18:40 +0100, Julian Foad wrote: > On Mon, 2010-08-23 at 18:43 +0200, Stefan Sperling wrote: > > On Wed, Aug 04, 2010 at 12:32:06PM -0400, Paul Burba wrote: > > > On Wed, Aug 4, 2010 at 12:14 PM, Julian Foad > > > wrote: > > > > On Wed

Re: merging into locally added files

On Tue, 2010-08-24, Stefan Sperling wrote: > On Mon, Aug 23, 2010 at 06:40:39PM +0100, Julian Foad wrote: > > You seem to be talking only about the case where the (locally added) > > target is the root of the whole merge, and saying that lack of ancestral > > relationship be

RE: svn commit: r988074 - in /subversion/trunk/subversion/tests/cmdline: svntest/wc.py upgrade_tests.py

Bert Huijben wrote: > Philip Martin wrote: > > "Bert Huijben" writes: > > > > >> * subversion/tests/cmdline/upgrade_tests.py > > >> (text_base_path): Restore MD5 support removed in r960036. > > > > > > I think the real fix would be to upgrade to SHA1 (and add the > > > mapping in the pristines

Re: RFC: How should Subversion handle OS-deleted paths?

On Fri, 2010-08-20, Paul Burba wrote: > I think we can all agree that when a user deletes part of their WC via > the OS they have made a mistake of some sort. But which mistake > exactly? The obvious answer is that they really intended 'svn del > dirX/foo.c'. But possibly they intended somethin

Re: Disable diff-cmd

anatoly techtonik wrote: > On Tue, Aug 24, 2010 at 2:29 PM, Stefan Sperling wrote: > >> > > >> > --internal-diff seems to be new in 1.7 so i guess the only option is > >> > using > >> > --config-dir to override it. > >> > >> Why not to stop proliferation of options by allowing an empty value > >>

Re: Commiting, tree conflicts and keep-local

I'm looking at the tree_conflict_tests.py 17 failure in single-DB. FAIL: tree_conflict_tests.py 17: --keep-local del on dir with TCs inside Neels, you might be able to shed some light on this. What's the test for? The test says: if you have a directory with tree conflict

Re: RFC: How should Subversion handle OS-deleted paths?

On Tue, 2010-08-24 at 20:50 +0200, Alan Barrett wrote: > On Tue, 24 Aug 2010, Julian Foad wrote: > > the as-yet-unavailable "svn mv --retrospectively" command [1], > > Is this is just a special case of the as-yet-unavailable > "--metadata-only" option, which

Re: svn commit: r988627 - in /subversion/trunk/subversion: bindings/javahl/native/ include/ libsvn_client/ svn/

On Tue, 2010-08-24, hwri...@apache.org wrote: > Log: > Move the commit callback out of the client context and into the individual > APIs > which require it. Hurrah! Reviewed and looks good. - Julian > * subversion/bindings/javahl/native/SVNClient.cpp > (remove, commit, copy, move, mkdir, do

Re: Commiting, tree conflicts and keep-local

y conflict, and "svn commit" should not allow a commit that contains a conflict, so there's no reason to think "svn delete" followed by "svn commit" should succeed if there was a conflict. On Tue, 2010-08-24, Julian Foad wrote: [...] > What should happen? &

Re: RFC: How should Subversion handle OS-deleted paths?

On Wed, 2010-08-25, Paul Burba wrote: > On Tue, Aug 24, 2010 at 7:25 AM, Julian Foad wrote: [...] > Agreed, we simply can't be sure what the user's intention was...I'm > beginning to be swayed to the idea that restoring the missing subtrees > may not be the ideal

Re: svn commit: r989824 - in /subversion/trunk: configure.ac get-deps.sh

On Thu, 2010-08-26, hwri...@apache.org wrote: > Log: > Bump the recommended SQLite version, due to a potential database corruption > bug in previous versions. That sounds more serious than it is to us. We don't appear to be using "incremental vacuum" anywhere (there's no mention in our trunk sour

Re: Single-DB: should "status -u" recurse into missing dir? (merge_tests 16 failure)

> On Aug 27, 2010 11:33 AM, "Julian Foad" wrote: > > In single-DB world, the WC generated in merge_tests.py 16, a directory > > 'A/B/F/Q' has been deleted from disk without informing Subversion, so > > its status is 'missing'. > > > >

Re: Single-DB: should "status -u" recurse into missing dir? (merge_tests 16 failure)

I (Julian Foad) wrote: > > On Aug 27, 2010 11:33 AM, "Julian Foad" wrote: > > > In single-DB world, the WC generated in merge_tests.py 16, a directory > > > 'A/B/F/Q' has been deleted from disk without informing Subversion, so > > > its st

Re: Two svn_wc__db_t for single-db upgrade

On Fri, 2010-08-27 at 12:46 -0400, Hyrum K. Wright wrote: > On Fri, Aug 27, 2010 at 12:32 PM, Stefan Sperling wrote: > > On Fri, Aug 27, 2010 at 12:03:04PM -0400, Bob Archer wrote: > >> I'm just talking as a user here... and not an svn dev... but do you > >> really need to spend time on a 1.6 to 1

Single-DB: should "status -u" recurse into missing dir? (merge_tests 16 failure)

In single-DB world, the WC generated in merge_tests.py 16, a directory 'A/B/F/Q' has been deleted from disk without informing Subversion, so its status is 'missing'. Look at the difference between these two "svn status" runs on it: $ svn st A/B/F -vu !22 jrandom A/B/F

is_wclocked() walks upwards out of a WC root

I just noticed that the "entries-dump" test helper program can abort with /home/julianfoad/src/subversion-p/subversion/libsvn_subr/io.c:1933: (apr_err=235000) svn: In file '/home/julianfoad/src/subversion-p/subversion/libsvn_wc/wc_db.c' line 522: assertion failed ((pdh)->wcroot != NULL && (pdh)->w

Re: FSFS error in DAV MERGE - Can't open file 'db/transactions/props'

I have opened issue #3696, <http://subversion.tigris.org/issues/show_bug.cgi?id=3696>, to track this. - Julian On Fri, 2010-07-30 at 16:17 +0100, Julian Foad wrote: > On Tue, 2010-06-22 at 13:57 +0100, Julian Foad wrote: > > I am investigating the following DAV + FSFS server erro

Re: svn commit: r980046 - /subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c

On Wed, 2010-07-28, Julian Foad wrote: > On Wed, 2010-07-28 at 10:13 -0700, Blair Zajac wrote: > > On 07/28/2010 06:18 AM, julianf...@apache.org wrote: > > > Author: julianfoad > > > Date: Wed Jul 28 13:18:28 2010 > > > New Revision: 980046 > > > >

Enabling Single-DB mode today

We want to get to single-DB mode ASAP. Is anything still blocking us from enabling it today? * One or two test failures? - I see stat_tests 5 and 6 failing at r991181. * Upgrade from 1.6? - I don't think this should block it. * Upgrade from 1.7-dev? - The Py script seems suffi

Re: Enabling Single-DB mode today

Bindings: swig-py, swig-pl, swig-rb all pass their tests. ctypes-python fails to build for me. Java: Philip said "I've run javahl tests in single-db, 3 FAILs compared to 1 in multi-db." Upgrading from a dev version: When the switch is made, after updating and re-compiling, each dev using a trunk

Re: Enabling Single-DB mode today

On Tue, 2010-08-31 at 10:41 -0400, C. Michael Pilato wrote: > On 08/31/2010 10:36 AM, Julian Foad wrote: > > Bindings: swig-py, swig-pl, swig-rb all pass their tests. ctypes-python > > fails to build for me. Java: Philip said "I've run javahl tests in > > sing

Re: Enabling Single-DB mode today

Enabled in r991236. We can leave the #defines in for a little while (like a few days, stsp and I suggest) to facilitate review and comparative testing. - Julian

WARNING: WC format bumped to 19: single-DB enabled: TAKE CARE

BACK UP YOUR WC before proceeding. When you upgrade to r991236 or later, single-DB (format 19) is enabled. If you're running trunk and using it for your WCs, you'll need to upgrade those WCs before svn will let you continue to use them. Currently the upgrade from format 18 is performed by tools/d

Re: WARNING: WC format bumped to 19: single-DB enabled: TAKE CARE

t one of course.) - Julian On Tue, 2010-08-31 at 18:02 +0100, Julian Foad wrote: > BACK UP YOUR WC before proceeding. > > When you upgrade to r991236 or later, single-DB (format 19) is enabled. > If you're running trunk and using it for your WCs, you'll need to > upgrade those WCs

Re: WARNING: WC format bumped to 19: single-DB enabled: TAKE CARE

Philip Martin wrote: > Julian Foad writes: > > > CAUTION: It's just a hacky script and it has some very rough edges. In > > particular, it will assimilate any versioned directory, *including > > things like externals that it shouldn't touch*. If you have any &

Re: WARNING: WC format bumped to 19: single-DB enabled: TAKE CARE

Greg Stein wrote: > You mean the note sent three whole hours before this > thread's original post? Hi Greg. We were on a roll! But I don't like it when people do things like that to me, and I especially don't like it if someone gives me a lousy upgrade script and expects me to deal with the co

Re: Do we want 'svn patch' to be able to add empty files?

Daniel Näslund wrote: > Hi! > > (This started out as me trying to apply added paths using the information > from a patch file in the git diff format. The only that I could come up > with where an add could not be detected by just looking at the regular > unidiff headers was adding an empty file (

Obsoleting svn_wc__db_kind_subdir and db_status_obstructed

I've disabled svn_wc__db_kind_subdir (#ifdef'd out, except - oops - that #define isn't active during processing of wc_db.h ...) and some temp APIs that use it. Now it looks like db_status_obstructed{,_*} are totally unref'd and can go too. Bert, Greg, sanity check please. Nothing you still want

RE: svn commit: r991619 - in /subversion/trunk/subversion: include/private/svn_wc_private.h libsvn_client/commit.c libsvn_client/commit_util.c libsvn_client/merge.c libsvn_wc/entries.c libsvn_wc/node.

Bert Huijben wrote: > From: Greg Stein: > > On Wed, Sep 1, 2010 at 13:44, wrote: > > > +#if 0 /* not required with SINGLE_DB */ > > > > Shouldn't this be #ifdef SVN_WC__SINGLE_DB ? I thought the idea was > > to keep using that define for a while so that developers can compile > > multi-db for

Re: Do we want 'svn patch' to be able to add empty files?

On Thu, 2010-09-02 at 14:03 +0200, Stefan Sperling wrote: > On Thu, Sep 02, 2010 at 01:57:49PM +0200, Stefan Sperling wrote: > > Right now, svn patch will always add an empty file if something is added > > that only has props. But the patch might want to create a directory instead. > > Is there a 1

Commit error: "database is locked"

When I committed r992004, "svn" reported that the commit failed, but in fact it succeeded on the server. The command and output were: [[[ $ svn ci -m "* subversion/libsvn_wc/tree_conflicts.c^M (svn_wc__write_tree_conflicts): Remove an obsolete comment." subversion/libsvn_wc/tree_conflicts.c Se

Re: Pascal bindings

C. Michael Pilato wrote: > On 09/02/2010 01:38 PM, Philip Martin wrote: > > dmitry boyarintsev writes: > > > >> Hello Subversion-dev, > >> > >> I can see, that there's no much of interest in Pascal bindings. > >> Well, that's quite understandable because of Pascal language not > >> being popular.

Re: svn commit: r992042 - in /subversion/trunk/subversion: libsvn_client/merge.c tests/cmdline/merge_authz_tests.py tests/cmdline/merge_tests.py tests/cmdline/merge_tree_conflict_tests.py tests/cmdlin

pbu...@apache.org wrote: > Fix issue #2915 'Handle mergeinfo for subtrees missing due to removal by > non-svn command'. > > With this change, if you attempt a merge-tracking aware merge to a WC > which is missing subtrees due to an OS-level deletion, then an error is > raised before any editor dri

Re: [PROPOSAL] WC-NG: merge NODE_DATA, WORKING_NODE and BASE_NODE into a single table (NODES)

Erik Huelsmann wrote: > As described by Julian earlier this month, Julian, Philip and I observed > that the BASE_NODE, WORKING_NODE and NODE_DATA tables have many fields in > common. Notably, by introducing the NODE_DATA table, most fields from > BASE_NODE and WORKING_NODE already moved to a common

Re: Some overlooked single-db-isms?

Thanks for catching this. I'll cook up a test and fix it. - Julian On Fri, 2010-09-03 at 01:22 -0400, C. Michael Pilato wrote: > Tonight I ran into a codepath which triggers and assertion. > > $ svn up > subversion/libsvn_wc/wc_db.c:383: (apr_err=235000) > svn: In file 'subversion/libsvn_wc/wc

Re: Some overlooked single-db-isms?

I (Julian Foad) wrote: > Thanks for catching this. I'll cook up a test and fix it. Fixed in r992276, with a new test. - Julian > On Fri, 2010-09-03 at 01:22 -0400, C. Michael Pilato wrote: > > Tonight I ran into a codepath which triggers and assertion. > > >

Re: svn commit: r996581 - in /subversion/trunk/subversion: libsvn_diff/parse-diff.c tests/cmdline/patch_tests.py

On Mon, 2010-09-13, s...@apache.org wrote: > * subversion/libsvn_diff/parse-diff.c > (svn_diff_parse_next_patch): When generating a reverse diff, do not swap >the old and new filenames of the patch. The old filename in a unidiff >is often useless (e.g. it contains a ".orig" extension), bu

Re: [Issue 3474] making a new subdir, moving files into it and then renaming the subdir, breaks history of the moved files

On Tue, 2010-09-14, Daniel Shahaf wrote: > Johan Corveleyn wrote on Sat, Sep 11, 2010 at 00:02:16 +0200: > > On Fri, Sep 10, 2010 at 11:45 PM, wrote: > > > http://subversion.tigris.org/issues/show_bug.cgi?id=3474 > > > > > > --- Additional comments from joha...@tigris.org Fri Sep 10 14:45:17

Re: svn commit: r996581 - in /subversion/trunk/subversion: libsvn_diff/parse-diff.c tests/cmdline/patch_tests.py

On Mon, 2010-09-13, Stefan Sperling wrote: > On Mon, Sep 13, 2010 at 05:50:05PM +0100, Julian Foad wrote: > > On Mon, 2010-09-13, s...@apache.org wrote: > > > * subversion/libsvn_diff/parse-diff.c > > > (svn_diff_parse_next_patch): When generating a reverse diff, do no

Re: Copies via update -- net win or net loss? (Was: svn commit: r996914 ...)

On Tue, 2010-09-14 at 10:58 -0400, C. Michael Pilato wrote: > On 09/14/2010 10:25 AM, rhuij...@apache.org wrote: > > Author: rhuijben > > Date: Tue Sep 14 14:25:52 2010 > > New Revision: 996914 > > > > URL: http://svn.apache.org/viewvc?rev=996914&view=rev > > Log: > > When mixing the two major hac

Re: Public API documentation

Hyrum K. Wright wrote: > I've been thinking about ways that our API documentation could be made > a bit cleaner. > > Currently, we use a lot of prose to describe APIs, their parameters, > and other nuances. I find this approach rather unique, and in some > ways obfuscating. We have great documen

Re: svn commit: r993183 - in /subversion/trunk/subversion: include/ libsvn_diff/ libsvn_ra_serf/ libsvn_subr/ mod_dav_svn/reports/

On Tue, 2010-09-07, s...@apache.org wrote: > Author: stsp > Date: Tue Sep 7 00:09:46 2010 > New Revision: 993183 > > URL: http://svn.apache.org/viewvc?rev=993183&view=rev > Log: > Introduce a new family of functions to parse numbers from strings. Looks useful. Thanks. > The goal is to replace d

Re: svn commit: r993183 - in /subversion/trunk/subversion: include/ libsvn_diff/ libsvn_ra_serf/ libsvn_subr/ mod_dav_svn/reports/

Also printf formatting type mismatches: subversion/libsvn_subr/svn_string.c: In function 'svn_cstring_strtoui64': subversion/libsvn_subr/svn_string.c:662: format '%lu' expects type 'long unsigned int', but argument 5 has type 'apr_uint64_t' subversion/libsvn_subr/svn_string.c:662: format '%lu' exp

Re: svn commit: r993183 - in /subversion/trunk/subversion: include/ libsvn_diff/ libsvn_ra_serf/ libsvn_subr/ mod_dav_svn/reports/

Stefan Sperling wrote: > On Wed, Sep 15, 2010 at 02:14:36PM +0100, Julian Foad wrote: > > On Tue, 2010-09-07, s...@apache.org wrote: > > > * subversion/include/svn_string.h > > > (svn_cstring_strtoi64, svn_cstring_atoi64, svn_cstring_atoi, > > >svn_cs

[PATCH] NODES table presence values

Bert, Erik, Greg... I think the schema should not disallow the 'excluded' presence in NODES table where op_depth > 0 (which corresponds roughly to old WORKING_NODE). There are already 'copy' cases where it is used, and seems useful and right. I also think the schema should not disallow 'absent'.

Re: [PATCH] NODES table presence values

Greg Stein wrote: > On Wed, Sep 15, 2010 at 13:29, Julian Foad wrote: > > Bert, Erik, Greg... > > > > I think the schema should not disallow the 'excluded' presence in NODES > > table where op_depth > 0 (which corresponds roughly to old > > WORKING_N

Re: svn commit: r996581 - in /subversion/trunk/subversion: libsvn_diff/parse-diff.c tests/cmdline/patch_tests.py

Stefan Sperling wrote: > Looking at the patch(1) man page, it sounds like we don't really need > to reinvent the wheel here: Phew! - wheels are complex, and the ones we make too often seem to have nails sticking out of them. > patch will choose the file name by performing the following steps

Re: svn commit: r993183 - in /subversion/trunk/subversion: include/ libsvn_diff/ libsvn_ra_serf/ libsvn_subr/ mod_dav_svn/reports/

On Wed, 2010-09-15 at 20:59 +0200, Stefan Sperling wrote: > On Wed, Sep 15, 2010 at 05:12:43PM +0100, Julian Foad wrote: > > > > > + * @since New in 1.7. > > > > > + */ > > > > > +svn_error_t * > > >

Re: svn commit: r997403 - /subversion/trunk/subversion/libsvn_wc/wc-metadata.sql

On Wed, 2010-09-15 at 16:17 -0400, Greg Stein wrote: > On Wed, Sep 15, 2010 at 13:19, wrote: > >... > > -- ### A comment on 'repos_id' and 'repos_relpath' says they may be > > null; > > - is this true and wanted? > > Yes. That meant "use the parent's information, and extend it to > com

Re: [PATCH] NODES table presence values

On Mon, 2010-09-20 at 13:17 -0400, Greg Stein wrote: > On Thu, Sep 16, 2010 at 09:21, Julian Foad wrote: > > Greg Stein wrote: > >... > >> Also, please note that I want to expand the presence values > >> dramatically with this move to NODES. I suggest the follo

Re: [PATCH] NODES table presence values

On Mon, 2010-09-20 at 18:45 +0100, Julian Foad wrote: > On Mon, 2010-09-20 at 13:17 -0400, Greg Stein wrote: > > On Thu, Sep 16, 2010 at 09:21, Julian Foad wrote: > > > Greg Stein wrote: > > >... > > >> Also, please note that I want to expand the presence va

Re: add NODES.prior_deleted boolean column

Greg Stein wrote: > After working through the several email messages, and discussion, I > believe we're now down to a simple change: > > * add a "prior_deleted" flag to NODES > > The flag simply means that a node exists prior to this layer and has > been deleted or moved-away. The 'presence' colu

Re: add NODES.prior_deleted boolean column

Pish, only the OpenOffice attachment was preserved. Here's a PDF copy, temporarily: <http://filebin.ca/fobqtm/nodes-states-2.pdf>. - Julian On Tue, 2010-09-21 at 18:41 +0100, Julian Foad wrote: > Greg Stein wrote: > > After working through the several email message

Re: svn commit: r998296 - /subversion/trunk/subversion/include/svn_client.h

Hyrum Wright wrote: > On Tue, Sep 21, 2010 at 10:25 PM, Daniel Shahaf > wrote: > > hwri...@apache.org wrote on Fri, Sep 17, 2010 at 20:04:53 -: > >> * subversion/include/svn_client.h > >> (svn_client_cat2): Rewrite docstring (see r997639). [...] > >> * > >> * A brief word on operative a

Re: svn commit: r999785 - /subversion/trunk/subversion/libsvn_subr/svn_string.c

Daniel Shahaf wrote: > Philip Martin wrote on Wed, Sep 22, 2010 at 11:47:19 +0100: > > Daniel Shahaf writes: > > > minval is an apr_uint64_t, so shouldn't the format string use > > > APR_UINT64_FMT? > > > > See this thread > > > > http://svn.haxx.se/dev/archive-2010-09/0295.shtml > > and subve

Re: svn commit: r999785 - /subversion/trunk/subversion/libsvn_subr/svn_string.c

Philip Martin wrote: > Daniel Shahaf writes: > > > Philip Martin wrote on Wed, Sep 22, 2010 at 11:47:19 +0100: > >> Daniel Shahaf writes: > >> > minval is an apr_uint64_t, so shouldn't the format string use > >> > APR_UINT64_FMT? > >> > >> See this thread > >> > >> http://svn.haxx.se/dev/arch

Re: add NODES.prior_deleted boolean column

On Wed, 2010-09-22, Greg Stein wrote: > On Tue, Sep 21, 2010 at 13:41, Julian Foad wrote: > > Greg Stein wrote: > >> After working through the several email messages, and discussion, I > >> believe we're now down to a simple change: > >> > >> *

Re: more benchmarks: comparing runtime of 1.6.x vs. trunk aka 1.7 / wc-ng

Hi Neels. The "svn --version" ratio shows wild variation in the "max" and "avg" columns across different data sets, while its ratio in the "min" column stays around 1.0 as expected. There isn't any explanation for this apart from timing errors is there? - Julian On Thu, 2010-09-23 at 15:09 +02

  1   2   3   4   5   6   7   8   9   10   >