[GitHub] davelpz commented on issue #4335: Not quoting column name when doing a time series

2018-02-05 Thread GitBox
davelpz commented on issue #4335: Not quoting column name when doing a time series URL: https://github.com/apache/incubator-superset/issues/4335#issuecomment-363219266 Issued pull request #4343 This is an automated messa

[GitHub] davelpz commented on issue #4335: Not quoting column name when doing a time series

2018-02-02 Thread GitBox
davelpz commented on issue #4335: Not quoting column name when doing a time series URL: https://github.com/apache/incubator-superset/issues/4335#issuecomment-362709093 I'd be happy to submit a pull request of people think this is correct. thanks! ---

[GitHub] davelpz commented on issue #4335: Not quoting column name when doing a time series

2018-02-02 Thread GitBox
davelpz commented on issue #4335: Not quoting column name when doing a time series URL: https://github.com/apache/incubator-superset/issues/4335#issuecomment-362708686 Upon further debugging I think this is the correct fix (below) I changed `if not self.expression and not time_grain:` t