[GitHub] lxzhangchao commented on issue #3220: Js translation

2017-08-13 Thread git
lxzhangchao commented on issue #3220: Js translation URL: https://github.com/apache/incubator-superset/pull/3220#issuecomment-322079967 Hope you can accept this code? @xrmx This is an automated message from the Apache Git S

[GitHub] lxzhangchao commented on issue #3220: Js translation

2017-08-10 Thread git
lxzhangchao commented on issue #3220: Js translation URL: https://github.com/apache/incubator-superset/pull/3220#issuecomment-320504299 Is there any way to get Superset current language in the JS file, to be able to compile it?

[GitHub] lxzhangchao commented on issue #3220: Js translation

2017-08-10 Thread git
lxzhangchao commented on issue #3220: Js translation URL: https://github.com/apache/incubator-superset/pull/3220#issuecomment-319585917 I am very difficult to get the ajax request in getLanguage and can?t get the current language. Do you have any Suggestions?

[GitHub] lxzhangchao commented on issue #3220: Js translation

2017-08-10 Thread git
lxzhangchao commented on issue #3220: Js translation URL: https://github.com/apache/incubator-superset/pull/3220#issuecomment-320146120 You can see the code for only translating a page in 'https://github.com/apache/incubator-superset/compare/master...lxzhangchao:js_trans?expand=1?? -

[GitHub] lxzhangchao commented on issue #3220: Js translation

2017-08-10 Thread git
lxzhangchao commented on issue #3220: Js translation URL: https://github.com/apache/incubator-superset/pull/3220#issuecomment-319366240 I saw in the 'superset/assets/javascripts/ explore/actions/exploreActions js' in' $= window. $= the require (' jquery ') 'can be used, why can't use in '

[GitHub] lxzhangchao commented on issue #3220: Js translation

2017-08-10 Thread git
lxzhangchao commented on issue #3220: Js translation URL: https://github.com/apache/incubator-superset/pull/3220#issuecomment-319373076 I want to create a new PR to remove excess commit, so I just open a branch and submit a new PR, think excess commit will disappear, the results still exi

[GitHub] lxzhangchao commented on issue #3220: Js translation

2017-08-10 Thread git
lxzhangchao commented on issue #3220: Js translation URL: https://github.com/apache/incubator-superset/pull/3220#issuecomment-321526793 when execute to 'npm run sync-backend' command, it can't ajax request or window, the following error occurs: ![qq 20170802140837](https://user-image

[GitHub] lxzhangchao commented on issue #3220: Js translation

2017-08-06 Thread git
lxzhangchao commented on issue #3220: Js translation URL: https://github.com/apache/incubator-superset/pull/3220#issuecomment-320504299 Is there any way to get Superset current language in the JS file, to be able to compile it?

[GitHub] lxzhangchao commented on issue #3220: Js translation

2017-08-03 Thread git
lxzhangchao commented on issue #3220: Js translation URL: https://github.com/apache/incubator-superset/pull/3220#issuecomment-320146120 You can see the code for only translating a page in 'https://github.com/apache/incubator-superset/compare/master...lxzhangchao:js_trans?expand=1?? -

[GitHub] lxzhangchao commented on issue #3220: Js translation

2017-08-02 Thread git
lxzhangchao commented on issue #3220: Js translation URL: https://github.com/apache/incubator-superset/pull/3220#issuecomment-319585917 I am very difficult to get the ajax request in getLanguage and can?t get the current language. Do you have any Suggestions?

[GitHub] lxzhangchao commented on issue #3220: Js translation

2017-08-01 Thread git
lxzhangchao commented on issue #3220: Js translation URL: https://github.com/apache/incubator-superset/pull/3220#issuecomment-319578992 How to solve it? ![qq 20170802140837](https://user-images.githubusercontent.com/20981441/28860104-a703478e-778d-11e7-9fc2-30aa0e3b5069.png) or ![

[GitHub] lxzhangchao commented on issue #3220: Js translation

2017-08-01 Thread git
lxzhangchao commented on issue #3220: Js translation URL: https://github.com/apache/incubator-superset/pull/3220#issuecomment-319578992 How to solve it? ![qq 20170802140837](https://user-images.githubusercontent.com/20981441/28860104-a703478e-778d-11e7-9fc2-30aa0e3b5069.png) -

[GitHub] lxzhangchao commented on issue #3220: Js translation

2017-08-01 Thread git
lxzhangchao commented on issue #3220: Js translation URL: https://github.com/apache/incubator-superset/pull/3220#issuecomment-319366240 I saw in the 'superset/assets/javascripts/ explore/actions/exploreActions js' in' $= window. $= the require (' jquery ') 'can be used, why can't use in '

[GitHub] lxzhangchao commented on issue #3220: Js translation

2017-08-01 Thread git
lxzhangchao commented on issue #3220: Js translation URL: https://github.com/apache/incubator-superset/pull/3220#issuecomment-319373076 I want to create a new PR to remove excess commit, so I just open a branch and submit a new PR, think excess commit will disappear, the results still exi

[GitHub] lxzhangchao commented on issue #3220: Js translation

2017-08-01 Thread git
lxzhangchao commented on issue #3220: Js translation URL: https://github.com/apache/incubator-superset/pull/3220#issuecomment-319366240 I saw in the 'superset/assets/javascripts/ explore/actions/exploreActions js' in' $= window. $= the require (' jquery ') 'can be used, why can't use in '