[GitHub] [syncope] ilgrosso commented on a change in pull request #176: SYNCOPE-1553: Translate AuthModuleConfs to WA

2020-04-21 Thread GitBox
ilgrosso commented on a change in pull request #176: URL: https://github.com/apache/syncope/pull/176#discussion_r411940454 ## File path: core/am/logic/src/main/java/org/apache/syncope/core/logic/AuthModuleLogic.java ## @@ -60,7 +59,8 @@ public AuthModuleTO update(final

[GitHub] [syncope] ilgrosso commented on a change in pull request #176: SYNCOPE-1553: Translate AuthModuleConfs to WA

2020-04-21 Thread GitBox
ilgrosso commented on a change in pull request #176: URL: https://github.com/apache/syncope/pull/176#discussion_r411946603 ## File path: core/am/logic/src/main/java/org/apache/syncope/core/logic/AuthModuleLogic.java ## @@ -60,7 +59,8 @@ public AuthModuleTO update(final

[GitHub] [syncope] mmoayyed commented on a change in pull request #176: SYNCOPE-1553: Translate AuthModuleConfs to WA

2020-04-21 Thread GitBox
mmoayyed commented on a change in pull request #176: URL: https://github.com/apache/syncope/pull/176#discussion_r411943268 ## File path: core/am/logic/src/main/java/org/apache/syncope/core/logic/AuthModuleLogic.java ## @@ -60,7 +59,8 @@ public AuthModuleTO update(final

[GitHub] [syncope] mmoayyed opened a new pull request #176: SYNCOPE-1553: Translate AuthModuleConfs to WA

2020-04-21 Thread GitBox
mmoayyed opened a new pull request #176: URL: https://github.com/apache/syncope/pull/176 TODO: - Translate profile item mappings for attributes, etc. - Fix configuration data and tests for AuthModuleITs to not bootstrap the context with invalid state/configuration.

[GitHub] [syncope] ilgrosso commented on pull request #177: Updating Log4j to 2.13.2 due to CVE-2020-9488

2020-04-27 Thread GitBox
ilgrosso commented on pull request #177: URL: https://github.com/apache/syncope/pull/177#issuecomment-619849853 @coheigea done, thx This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [syncope] ilgrosso commented on pull request #177: Updating Log4j to 2.13.2 due to CVE-2020-9488

2020-04-27 Thread GitBox
ilgrosso commented on pull request #177: URL: https://github.com/apache/syncope/pull/177#issuecomment-619840505 @coheigea Travis CI has passed, AppVeyor is quite unstable; please, go ahead and merge. This is an automated

[GitHub] [syncope] coheigea commented on pull request #177: Updating Log4j to 2.13.2 due to CVE-2020-9488

2020-04-27 Thread GitBox
coheigea commented on pull request #177: URL: https://github.com/apache/syncope/pull/177#issuecomment-619841955 @ilgrosso Done. Can you backmerge it? This is an automated message from the Apache Git Service. To respond

[GitHub] [syncope] ilgrosso commented on a change in pull request #178: [SYNCOPE-1555] Allow WA as SAMLs IdP to fetch metadata over REST

2020-04-28 Thread GitBox
ilgrosso commented on a change in pull request #178: URL: https://github.com/apache/syncope/pull/178#discussion_r416602771 ## File path: common/am/lib/src/main/java/org/apache/syncope/common/lib/to/SAML2IdPMetadataTO.java ## @@ -0,0 +1,180 @@ +/* + * Licensed to the Apache

[GitHub] [syncope] ilgrosso commented on a change in pull request #178: [SYNCOPE-1555] Allow WA as SAMLs IdP to fetch metadata over REST

2020-04-28 Thread GitBox
ilgrosso commented on a change in pull request #178: URL: https://github.com/apache/syncope/pull/178#discussion_r416604234 ## File path: core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/dao/auth/JPASAML2IdPMetadataDAO.java ## @@ -0,0 +1,61 @@ +/* + *

[GitHub] [syncope] mat-ale commented on a change in pull request #178: [SYNCOPE-1555] Allow WA as SAMLs IdP to fetch metadata over REST

2020-04-28 Thread GitBox
mat-ale commented on a change in pull request #178: URL: https://github.com/apache/syncope/pull/178#discussion_r416608586 ## File path: wa/starter/src/main/java/org/apache/syncope/wa/SyncopeCoreNotReadyException.java ## @@ -0,0 +1,25 @@ +/* Review comment: I think

[GitHub] [syncope] ilgrosso commented on a change in pull request #178: [SYNCOPE-1555] Allow WA as SAMLs IdP to fetch metadata over REST

2020-04-28 Thread GitBox
ilgrosso commented on a change in pull request #178: URL: https://github.com/apache/syncope/pull/178#discussion_r416605070 ## File path: fit/core-reference/pom.xml ## @@ -222,6 +222,30 @@ under the License. bcpkix-jdk15on test + Review comment:

[GitHub] [syncope] mat-ale commented on a change in pull request #178: [SYNCOPE-1555] Allow WA as SAMLs IdP to fetch metadata over REST

2020-04-28 Thread GitBox
mat-ale commented on a change in pull request #178: URL: https://github.com/apache/syncope/pull/178#discussion_r416618050 ## File path: wa/starter/src/main/java/org/apache/syncope/wa/SyncopeCoreNotReadyException.java ## @@ -0,0 +1,25 @@ +/* Review comment: ATM in the

[GitHub] [syncope] ilgrosso commented on a change in pull request #178: [SYNCOPE-1555] Allow WA as SAMLs IdP to fetch metadata over REST

2020-04-28 Thread GitBox
ilgrosso commented on a change in pull request #178: URL: https://github.com/apache/syncope/pull/178#discussion_r416606552 ## File path: wa/starter/src/main/java/org/apache/syncope/wa/SyncopeCoreNotReadyException.java ## @@ -0,0 +1,25 @@ +/* Review comment: Is this

[GitHub] [syncope] mat-ale commented on a change in pull request #178: [SYNCOPE-1555] Allow WA as SAMLs IdP to fetch metadata over REST

2020-04-28 Thread GitBox
mat-ale commented on a change in pull request #178: URL: https://github.com/apache/syncope/pull/178#discussion_r416607578 ## File path: fit/core-reference/pom.xml ## @@ -222,6 +222,30 @@ under the License. bcpkix-jdk15on test + Review comment:

[GitHub] [syncope] mat-ale opened a new pull request #178: [SYNCOPE-1555] Allow WA as SAMLs IdP to fetch metadata over REST

2020-04-28 Thread GitBox
mat-ale opened a new pull request #178: URL: https://github.com/apache/syncope/pull/178 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [syncope] mmoayyed commented on issue #176: SYNCOPE-1553: Translate AuthModuleConfs to WA

2020-04-22 Thread GitBox
mmoayyed commented on issue #176: URL: https://github.com/apache/syncope/pull/176#issuecomment-617707225 PS Just a note for public's and archive's sake that the saml stuff likely will be revised shortly to handle mappings better with richer pac4j support.

[GitHub] [syncope] mat-ale commented on a change in pull request #178: [SYNCOPE-1555] Allow WA as SAMLs IdP to fetch metadata over REST

2020-04-29 Thread GitBox
mat-ale commented on a change in pull request #178: URL: https://github.com/apache/syncope/pull/178#discussion_r417332912 ## File path: wa/starter/src/main/java/org/apache/syncope/wa/SyncopeCoreNotReadyException.java ## @@ -0,0 +1,25 @@ +/* Review comment: @mmoayyed

[GitHub] [syncope] mat-ale commented on a change in pull request #178: [SYNCOPE-1555] Allow WA as SAMLs IdP to fetch metadata over REST

2020-04-29 Thread GitBox
mat-ale commented on a change in pull request #178: URL: https://github.com/apache/syncope/pull/178#discussion_r417332912 ## File path: wa/starter/src/main/java/org/apache/syncope/wa/SyncopeCoreNotReadyException.java ## @@ -0,0 +1,25 @@ +/* Review comment: @mmoayyed

[GitHub] [syncope] mat-ale commented on a change in pull request #178: [SYNCOPE-1555] Allow WA as SAMLs IdP to fetch metadata over REST

2020-04-29 Thread GitBox
mat-ale commented on a change in pull request #178: URL: https://github.com/apache/syncope/pull/178#discussion_r417332912 ## File path: wa/starter/src/main/java/org/apache/syncope/wa/SyncopeCoreNotReadyException.java ## @@ -0,0 +1,25 @@ +/* Review comment: @mmoayyed

[GitHub] [syncope] coheigea commented on pull request #179: Bumping year to 2020

2020-05-01 Thread GitBox
coheigea commented on pull request #179: URL: https://github.com/apache/syncope/pull/179#issuecomment-622277669 @ilgrosso Done! Could you backport to the older branches? This is an automated message from the Apache Git

[GitHub] [syncope] ilgrosso edited a comment on pull request #179: Bumping year to 2020

2020-05-01 Thread GitBox
ilgrosso edited a comment on pull request #179: URL: https://github.com/apache/syncope/pull/179#issuecomment-622273782 @coheigea by looking at other years' similar commits I found the following file should be updated as well: `src/site/site.xml`

[GitHub] [syncope] ilgrosso commented on pull request #179: Bumping year to 2020

2020-05-01 Thread GitBox
ilgrosso commented on pull request #179: URL: https://github.com/apache/syncope/pull/179#issuecomment-622273782 @coheigea by looking at other years' similar commits I found the following file should be updated as well: 'src/site/site.xml`

[GitHub] [syncope] ilgrosso commented on pull request #179: Bumping year to 2020

2020-05-01 Thread GitBox
ilgrosso commented on pull request #179: URL: https://github.com/apache/syncope/pull/179#issuecomment-622272317 @coheigea thanks for reporting this! There are, however, several `NOTICE` files in the source tree that should be amended as well. Moreover, we'll need to do the

[GitHub] [syncope] coheigea commented on pull request #179: Bumping year to 2020

2020-05-01 Thread GitBox
coheigea commented on pull request #179: URL: https://github.com/apache/syncope/pull/179#issuecomment-622272979 @ilgrosso I updated the PR to pick up the other NOTICE files This is an automated message from the Apache Git

[GitHub] [syncope] ilgrosso commented on pull request #179: Bumping year to 2020

2020-05-01 Thread GitBox
ilgrosso commented on pull request #179: URL: https://github.com/apache/syncope/pull/179#issuecomment-622287076 @coheigea sure This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [syncope] ilgrosso opened a new pull request #180: Replacing OpenJDK 13 with 15

2020-05-01 Thread GitBox
ilgrosso opened a new pull request #180: URL: https://github.com/apache/syncope/pull/180 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [syncope] mmoayyed opened a new pull request #181: SYNCOPE-1545: restful SAML SP metadata/keystore for WA authN delegation

2020-05-01 Thread GitBox
mmoayyed opened a new pull request #181: URL: https://github.com/apache/syncope/pull/181 JIRA: https://issues.apache.org/jira/browse/SYNCOPE-1558 - [ ] Publish CAS SNAPSHOT to utilize latest enhancements - [ ] Design REST API endpoints to handle keystore/metadata - [ ] Provide

[GitHub] [syncope] mat-ale commented on a change in pull request #178: [SYNCOPE-1555] Allow WA as SAMLs IdP to fetch metadata over REST

2020-04-30 Thread GitBox
mat-ale commented on a change in pull request #178: URL: https://github.com/apache/syncope/pull/178#discussion_r418057236 ## File path: core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/SAML2IdPMetadataBinderImpl.java ## @@ -0,0 +1,84 @@ +/*

[GitHub] [syncope] mat-ale commented on a change in pull request #178: [SYNCOPE-1555] Allow WA as SAMLs IdP to fetch metadata over REST

2020-04-30 Thread GitBox
mat-ale commented on a change in pull request #178: URL: https://github.com/apache/syncope/pull/178#discussion_r418057236 ## File path: core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/SAML2IdPMetadataBinderImpl.java ## @@ -0,0 +1,84 @@ +/*

[GitHub] [syncope] mmoayyed commented on a change in pull request #178: [SYNCOPE-1555] Allow WA as SAMLs IdP to fetch metadata over REST

2020-04-30 Thread GitBox
mmoayyed commented on a change in pull request #178: URL: https://github.com/apache/syncope/pull/178#discussion_r418033535 ## File path: core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/dao/auth/JPASAML2IdPMetadataDAO.java ## @@ -0,0 +1,61 @@ +/* + *

[GitHub] [syncope] mat-ale commented on a change in pull request #178: [SYNCOPE-1555] Allow WA as SAMLs IdP to fetch metadata over REST

2020-04-30 Thread GitBox
mat-ale commented on a change in pull request #178: URL: https://github.com/apache/syncope/pull/178#discussion_r418057236 ## File path: core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/SAML2IdPMetadataBinderImpl.java ## @@ -0,0 +1,84 @@ +/*

[GitHub] [syncope] mmoayyed commented on a change in pull request #178: [SYNCOPE-1555] Allow WA as SAMLs IdP to fetch metadata over REST

2020-04-30 Thread GitBox
mmoayyed commented on a change in pull request #178: URL: https://github.com/apache/syncope/pull/178#discussion_r418035474 ## File path: core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/SAML2IdPMetadataBinderImpl.java ## @@ -0,0 +1,84 @@ +/*

[GitHub] [syncope] mat-ale commented on a change in pull request #178: [SYNCOPE-1555] Allow WA as SAMLs IdP to fetch metadata over REST

2020-04-30 Thread GitBox
mat-ale commented on a change in pull request #178: URL: https://github.com/apache/syncope/pull/178#discussion_r418055736 ## File path: core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/SAML2IdPMetadataBinderImpl.java ## @@ -0,0 +1,84 @@ +/*

[GitHub] [syncope] mat-ale commented on a change in pull request #178: [SYNCOPE-1555] Allow WA as SAMLs IdP to fetch metadata over REST

2020-04-30 Thread GitBox
mat-ale commented on a change in pull request #178: URL: https://github.com/apache/syncope/pull/178#discussion_r418052728 ## File path: core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/dao/auth/JPASAML2IdPMetadataDAO.java ## @@ -0,0 +1,61 @@ +/* + *

[GitHub] [syncope] mmoayyed commented on a change in pull request #178: [SYNCOPE-1555] Allow WA as SAMLs IdP to fetch metadata over REST

2020-04-30 Thread GitBox
mmoayyed commented on a change in pull request #178: URL: https://github.com/apache/syncope/pull/178#discussion_r418034429 ## File path: core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/SAML2IdPMetadataBinderImpl.java ## @@ -0,0 +1,84 @@ +/*

[GitHub] [syncope] mat-ale commented on a change in pull request #178: [SYNCOPE-1555] Allow WA as SAMLs IdP to fetch metadata over REST

2020-04-30 Thread GitBox
mat-ale commented on a change in pull request #178: URL: https://github.com/apache/syncope/pull/178#discussion_r418053849 ## File path: core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/SAML2IdPMetadataBinderImpl.java ## @@ -0,0 +1,84 @@ +/*

[GitHub] [syncope] ilgrosso commented on a change in pull request #178: [SYNCOPE-1555] Allow WA as SAMLs IdP to fetch metadata over REST

2020-04-30 Thread GitBox
ilgrosso commented on a change in pull request #178: URL: https://github.com/apache/syncope/pull/178#discussion_r418083335 ## File path: core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/SAML2IdPMetadataBinderImpl.java ## @@ -0,0 +1,84 @@ +/*

[GitHub] [syncope] mmoayyed commented on a change in pull request #182: NOJIRA - Switch Travis CI to AMD64 Bionic Distro

2020-05-04 Thread GitBox
mmoayyed commented on a change in pull request #182: URL: https://github.com/apache/syncope/pull/182#discussion_r419509630 ## File path: pom.xml ## @@ -2530,6 +2530,7 @@ under the License. **/*.json **/banner.txt **/target/** +

[GitHub] [syncope] ilgrosso commented on a change in pull request #182: NOJIRA - Switch Travis CI to AMD64 Bionic Distro

2020-05-04 Thread GitBox
ilgrosso commented on a change in pull request #182: URL: https://github.com/apache/syncope/pull/182#discussion_r419514983 ## File path: pom.xml ## @@ -2530,6 +2530,7 @@ under the License. **/*.json **/banner.txt **/target/** +

[GitHub] [syncope] ilgrosso commented on pull request #182: NOJIRA - Switch Travis CI to AMD64 Bionic Distro

2020-05-04 Thread GitBox
ilgrosso commented on pull request #182: URL: https://github.com/apache/syncope/pull/182#issuecomment-623469331 @mmoayyed it seems that installing other JDKs is failing, I tried to restart the related steps several times, no luck. Any idea?

[GitHub] [syncope] mmoayyed opened a new pull request #182: NOJIRA - Switch Travis CI to AMD64 Bionic Distro

2020-05-04 Thread GitBox
mmoayyed opened a new pull request #182: URL: https://github.com/apache/syncope/pull/182 The Travis CI trusty image is deprecated. This change switches the distro to Bionic which builds against Ubuntu 18. PS. I also experimented with arm-based builds which are super fast to startup

[GitHub] [syncope] ilgrosso commented on a change in pull request #182: NOJIRA - Switch Travis CI to AMD64 Bionic Distro

2020-05-04 Thread GitBox
ilgrosso commented on a change in pull request #182: URL: https://github.com/apache/syncope/pull/182#discussion_r419503248 ## File path: pom.xml ## @@ -2530,6 +2530,7 @@ under the License. **/*.json **/banner.txt **/target/** +

[GitHub] [syncope] coheigea opened a new pull request #177: Updating Log4j to 2.13.2 due to CVE-2020-9488

2020-04-27 Thread GitBox
coheigea opened a new pull request #177: URL: https://github.com/apache/syncope/pull/177 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [syncope] mmoayyed commented on a change in pull request #178: [SYNCOPE-1555] Allow WA as SAMLs IdP to fetch metadata over REST

2020-04-29 Thread GitBox
mmoayyed commented on a change in pull request #178: URL: https://github.com/apache/syncope/pull/178#discussion_r417290694 ## File path: wa/starter/src/main/java/org/apache/syncope/wa/SyncopeCoreNotReadyException.java ## @@ -0,0 +1,25 @@ +/* Review comment: Strictly

[GitHub] [syncope] ilgrosso commented on a change in pull request #181: SYNCOPE-1558: restful SAML SP metadata/keystore for WA authN delegation

2020-05-11 Thread GitBox
ilgrosso commented on a change in pull request #181: URL: https://github.com/apache/syncope/pull/181#discussion_r422834916 ## File path: wa/starter/pom.xml ## @@ -237,12 +241,14 @@ under the License. org.springframework.boot spring-boot-starter-security - +

[GitHub] [syncope] mmoayyed commented on a change in pull request #181: SYNCOPE-1558: restful SAML SP metadata/keystore for WA authN delegation

2020-05-11 Thread GitBox
mmoayyed commented on a change in pull request #181: URL: https://github.com/apache/syncope/pull/181#discussion_r422892659 ## File path: common/am/rest-api/src/main/java/org/apache/syncope/common/rest/api/service/SAML2SPKeystoreService.java ## @@ -0,0 +1,96 @@ +/* + *

[GitHub] [syncope] mmoayyed commented on a change in pull request #181: SYNCOPE-1558: restful SAML SP metadata/keystore for WA authN delegation

2020-05-11 Thread GitBox
mmoayyed commented on a change in pull request #181: URL: https://github.com/apache/syncope/pull/181#discussion_r422891596 ## File path: common/am/rest-api/src/main/java/org/apache/syncope/common/rest/api/service/SAML2SPMetadataConfService.java ## @@ -0,0 +1,64 @@ +/* + *

[GitHub] [syncope] mmoayyed commented on a change in pull request #181: SYNCOPE-1558: restful SAML SP metadata/keystore for WA authN delegation

2020-05-11 Thread GitBox
mmoayyed commented on a change in pull request #181: URL: https://github.com/apache/syncope/pull/181#discussion_r422891977 ## File path: common/am/lib/src/main/java/org/apache/syncope/common/lib/types/AMEntitlement.java ## @@ -60,6 +60,18 @@ public static final String

[GitHub] [syncope] ilgrosso commented on a change in pull request #181: SYNCOPE-1558: restful SAML SP metadata/keystore for WA authN delegation

2020-05-11 Thread GitBox
ilgrosso commented on a change in pull request #181: URL: https://github.com/apache/syncope/pull/181#discussion_r422898068 ## File path: common/am/rest-api/src/main/java/org/apache/syncope/common/rest/api/service/SAML2SPMetadataConfService.java ## @@ -0,0 +1,64 @@ +/* + *

[GitHub] [syncope] mmoayyed commented on a change in pull request #181: SYNCOPE-1558: restful SAML SP metadata/keystore for WA authN delegation

2020-05-11 Thread GitBox
mmoayyed commented on a change in pull request #181: URL: https://github.com/apache/syncope/pull/181#discussion_r422898741 ## File path: common/am/rest-api/src/main/java/org/apache/syncope/common/rest/api/service/SAML2SPKeystoreService.java ## @@ -0,0 +1,96 @@ +/* + *

[GitHub] [syncope] ilgrosso commented on a change in pull request #181: SYNCOPE-1558: restful SAML SP metadata/keystore for WA authN delegation

2020-05-11 Thread GitBox
ilgrosso commented on a change in pull request #181: URL: https://github.com/apache/syncope/pull/181#discussion_r422904090 ## File path: common/am/rest-api/src/main/java/org/apache/syncope/common/rest/api/service/wa/SAML2SPKeystoreService.java ## @@ -7,7 +7,7 @@ *

[GitHub] [syncope] ilgrosso commented on a change in pull request #181: SYNCOPE-1558: restful SAML SP metadata/keystore for WA authN delegation

2020-05-11 Thread GitBox
ilgrosso commented on a change in pull request #181: URL: https://github.com/apache/syncope/pull/181#discussion_r422904324 ## File path: common/am/rest-api/src/main/java/org/apache/syncope/common/rest/api/service/wa/SAML2SPMetadataService.java ## @@ -7,7 +7,7 @@ *

[GitHub] [syncope] ilgrosso commented on a change in pull request #181: SYNCOPE-1558: restful SAML SP metadata/keystore for WA authN delegation

2020-05-11 Thread GitBox
ilgrosso commented on a change in pull request #181: URL: https://github.com/apache/syncope/pull/181#discussion_r422903491 ## File path: common/am/rest-api/src/main/java/org/apache/syncope/common/rest/api/service/wa/SAML2IdPMetadataService.java ## @@ -7,7 +7,7 @@ *

[GitHub] [syncope] mmoayyed commented on a change in pull request #181: SYNCOPE-1558: restful SAML SP metadata/keystore for WA authN delegation

2020-05-11 Thread GitBox
mmoayyed commented on a change in pull request #181: URL: https://github.com/apache/syncope/pull/181#discussion_r422901084 ## File path: common/am/rest-api/src/main/java/org/apache/syncope/common/rest/api/service/SAML2SPKeystoreConfService.java ## @@ -0,0 +1,64 @@ +/* + *

[GitHub] [syncope] ilgrosso commented on a change in pull request #181: SYNCOPE-1558: restful SAML SP metadata/keystore for WA authN delegation

2020-05-11 Thread GitBox
ilgrosso commented on a change in pull request #181: URL: https://github.com/apache/syncope/pull/181#discussion_r422950476 ## File path: common/am/rest-api/src/main/java/org/apache/syncope/common/rest/api/service/wa/SAML2IdPMetadataService.java ## @@ -7,7 +7,7 @@ *

[GitHub] [syncope] ilgrosso commented on a change in pull request #181: SYNCOPE-1558: restful SAML SP metadata/keystore for WA authN delegation

2020-05-11 Thread GitBox
ilgrosso commented on a change in pull request #181: URL: https://github.com/apache/syncope/pull/181#discussion_r422895396 ## File path: common/am/rest-api/src/main/java/org/apache/syncope/common/rest/api/service/SAML2SPKeystoreService.java ## @@ -0,0 +1,96 @@ +/* + *

[GitHub] [syncope] ilgrosso commented on a change in pull request #181: SYNCOPE-1558: restful SAML SP metadata/keystore for WA authN delegation

2020-05-11 Thread GitBox
ilgrosso commented on a change in pull request #181: URL: https://github.com/apache/syncope/pull/181#discussion_r422899478 ## File path: common/am/rest-api/src/main/java/org/apache/syncope/common/rest/api/service/SAML2SPKeystoreService.java ## @@ -0,0 +1,96 @@ +/* + *

[GitHub] [syncope] mmoayyed commented on a change in pull request #181: SYNCOPE-1558: restful SAML SP metadata/keystore for WA authN delegation

2020-05-11 Thread GitBox
mmoayyed commented on a change in pull request #181: URL: https://github.com/apache/syncope/pull/181#discussion_r422891304 ## File path: common/am/rest-api/src/main/java/org/apache/syncope/common/rest/api/service/SAML2SPKeystoreConfService.java ## @@ -0,0 +1,64 @@ +/* + *

[GitHub] [syncope] ilgrosso commented on a change in pull request #181: SYNCOPE-1558: restful SAML SP metadata/keystore for WA authN delegation

2020-05-11 Thread GitBox
ilgrosso commented on a change in pull request #181: URL: https://github.com/apache/syncope/pull/181#discussion_r422897775 ## File path: common/am/rest-api/src/main/java/org/apache/syncope/common/rest/api/service/SAML2SPKeystoreConfService.java ## @@ -0,0 +1,64 @@ +/* + *

[GitHub] [syncope] ilgrosso commented on a change in pull request #181: SYNCOPE-1558: restful SAML SP metadata/keystore for WA authN delegation

2020-05-11 Thread GitBox
ilgrosso commented on a change in pull request #181: URL: https://github.com/apache/syncope/pull/181#discussion_r422897775 ## File path: common/am/rest-api/src/main/java/org/apache/syncope/common/rest/api/service/SAML2SPKeystoreConfService.java ## @@ -0,0 +1,64 @@ +/* + *

[GitHub] [syncope] mmoayyed commented on a change in pull request #181: SYNCOPE-1558: restful SAML SP metadata/keystore for WA authN delegation

2020-05-11 Thread GitBox
mmoayyed commented on a change in pull request #181: URL: https://github.com/apache/syncope/pull/181#discussion_r422975856 ## File path: common/am/rest-api/src/main/java/org/apache/syncope/common/rest/api/service/wa/SAML2SPKeystoreService.java ## @@ -7,7 +7,7 @@ *

[GitHub] [syncope] mmoayyed commented on a change in pull request #181: SYNCOPE-1558: restful SAML SP metadata/keystore for WA authN delegation

2020-05-11 Thread GitBox
mmoayyed commented on a change in pull request #181: URL: https://github.com/apache/syncope/pull/181#discussion_r422979018 ## File path: common/am/rest-api/src/main/java/org/apache/syncope/common/rest/api/service/wa/SAML2SPKeystoreService.java ## @@ -7,7 +7,7 @@ *

[GitHub] [syncope] DimaAy opened a new pull request #186: [SYNCOPE-1557] complete policies manipulating

2020-05-08 Thread GitBox
DimaAy opened a new pull request #186: URL: https://github.com/apache/syncope/pull/186 remove ITCase attempt Cleanup + sample working test for ClientApp SyncopeServiceRegistry tests [SYNCOPE-1557] authModules manipulating [SYNCOPE-1557] complete policies

[GitHub] [syncope] ilgrosso commented on a change in pull request #181: SYNCOPE-1558: restful SAML SP metadata/keystore for WA authN delegation

2020-05-08 Thread GitBox
ilgrosso commented on a change in pull request #181: URL: https://github.com/apache/syncope/pull/181#discussion_r422142011 ## File path: core/persistence-jpa/src/test/resources/domains/MasterContent.xml ## @@ -68,9 +68,10 @@ under the License.

[GitHub] [syncope] mmoayyed commented on pull request #186: [SYNCOPE-1557] complete policies manipulating

2020-05-08 Thread GitBox
mmoayyed commented on pull request #186: URL: https://github.com/apache/syncope/pull/186#issuecomment-625821354 Sure. I'll do a sanity check. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [syncope] DimaAy commented on a change in pull request #186: [SYNCOPE-1557] complete policies manipulating

2020-05-08 Thread GitBox
DimaAy commented on a change in pull request #186: URL: https://github.com/apache/syncope/pull/186#discussion_r422100077 ## File path: core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/wa/WAClientAppBinderImpl.java ## @@ -35,15 +39,21 @@

[GitHub] [syncope] DimaAy commented on a change in pull request #186: [SYNCOPE-1557] complete policies manipulating

2020-05-08 Thread GitBox
DimaAy commented on a change in pull request #186: URL: https://github.com/apache/syncope/pull/186#discussion_r422100077 ## File path: core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/wa/WAClientAppBinderImpl.java ## @@ -35,15 +39,21 @@

[GitHub] [syncope] ilgrosso commented on a change in pull request #186: [SYNCOPE-1557] complete policies manipulating

2020-05-08 Thread GitBox
ilgrosso commented on a change in pull request #186: URL: https://github.com/apache/syncope/pull/186#discussion_r422119688 ## File path: core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/wa/WAClientAppBinderImpl.java ## @@ -53,7 +53,7 @@

[GitHub] [syncope] ilgrosso opened a new pull request #185: [SYNCOPE-1496] Adding tests for all DBMS including JSON variants + Wi…

2020-05-08 Thread GitBox
ilgrosso opened a new pull request #185: URL: https://github.com/apache/syncope/pull/185 …ldfly This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [syncope] ilgrosso commented on a change in pull request #186: [SYNCOPE-1557] complete policies manipulating

2020-05-08 Thread GitBox
ilgrosso commented on a change in pull request #186: URL: https://github.com/apache/syncope/pull/186#discussion_r422092397 ## File path: common/am/lib/src/main/java/org/apache/syncope/common/lib/wa/WAClientApp.java ## @@ -36,6 +38,8 @@ private AttrReleasePolicyConf

[GitHub] [syncope] ilgrosso commented on a change in pull request #188: [SYNCOPE-1563] Fixed password mangement in user approval form

2020-05-15 Thread GitBox
ilgrosso commented on a change in pull request #188: URL: https://github.com/apache/syncope/pull/188#discussion_r425745228 ## File path: ext/flowable/client-console/src/main/java/org/apache/syncope/client/console/panels/UserRequestFormDirectoryPanel.java ## @@ -226,8 +226,10

[GitHub] [syncope] andrea-patricelli merged pull request #188: [SYNCOPE-1563] Fixed password mangement in user approval form

2020-05-15 Thread GitBox
andrea-patricelli merged pull request #188: URL: https://github.com/apache/syncope/pull/188 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [syncope] mmoayyed merged pull request #187: SYNCOPE-1559: Support GoogleAuth MFA configuration

2020-05-14 Thread GitBox
mmoayyed merged pull request #187: URL: https://github.com/apache/syncope/pull/187 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [syncope] mmoayyed opened a new pull request #189: SYNCOPE-1562: Manage tokens for WA GoogleAuth MFA

2020-05-18 Thread GitBox
mmoayyed opened a new pull request #189: URL: https://github.com/apache/syncope/pull/189 - Presents APIs and components to manage tokens for Google Authenticator MFA. - Managing user registered devices will be done in a separate pull request to minimize changes. - TODO: Integrate and

[GitHub] [syncope] mmoayyed commented on pull request #183: NOJIRA: skipTests maven profile should also apply to ITs

2020-05-06 Thread GitBox
mmoayyed commented on pull request #183: URL: https://github.com/apache/syncope/pull/183#issuecomment-624546691 I would like `clean install -PskipTests`s to complete as quickly as possible, skipping as many tests as possible. It also seems strange that I can specify skipping tests, but in

[GitHub] [syncope] mmoayyed commented on pull request #183: NOJIRA: skipTests maven profile should also apply to ITs

2020-05-06 Thread GitBox
mmoayyed commented on pull request #183: URL: https://github.com/apache/syncope/pull/183#issuecomment-624551455 hmmm, that's odd. I wonder if this may be caused by a conflict between the build and my local maven settings. I do see ITs run when I run with that profile, using

[GitHub] [syncope] mmoayyed opened a new pull request #183: NOJIRA: skipTests profile should also apply to ITs

2020-05-06 Thread GitBox
mmoayyed opened a new pull request #183: URL: https://github.com/apache/syncope/pull/183 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [syncope] ilgrosso commented on pull request #183: NOJIRA: skipTests maven profile should also apply to ITs

2020-05-06 Thread GitBox
ilgrosso commented on pull request #183: URL: https://github.com/apache/syncope/pull/183#issuecomment-624545678 @mmoayyed any reason why you need this? This is an automated message from the Apache Git Service. To respond to

[GitHub] [syncope] ilgrosso commented on pull request #183: NOJIRA: skipTests maven profile should also apply to ITs

2020-05-06 Thread GitBox
ilgrosso commented on pull request #183: URL: https://github.com/apache/syncope/pull/183#issuecomment-624548048 I see, but when using `-PskipTests` IT Cases are already not executed, even without the change proposed in this PR.

[GitHub] [syncope] ilgrosso opened a new pull request #184: Allowing for flexing Auth, Access, AttrRelease and ClientApp translation

2020-05-06 Thread GitBox
ilgrosso opened a new pull request #184: URL: https://github.com/apache/syncope/pull/184 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [syncope] mmoayyed commented on a change in pull request #184: [SYNCOPE-1557] Allowing for flexing Auth, Access, AttrRelease and ClientApp translation

2020-05-06 Thread GitBox
mmoayyed commented on a change in pull request #184: URL: https://github.com/apache/syncope/pull/184#discussion_r420685720 ## File path: wa/starter/src/main/java/org/apache/syncope/wa/starter/mapping/AllowedAttrReleaseMapper.java ## @@ -0,0 +1,55 @@ +/* + * Licensed to the

[GitHub] [syncope] mmoayyed commented on pull request #183: NOJIRA: skipTests maven profile should also apply to ITs

2020-05-06 Thread GitBox
mmoayyed commented on pull request #183: URL: https://github.com/apache/syncope/pull/183#issuecomment-624567229 Tested again; Seems like I might have had some local profile changes messing up the build. Change is unnecessary as was pointed out. Closing. Thanks!

[GitHub] [syncope] ilgrosso commented on pull request #182: NOJIRA - Switch Travis CI to AMD64 Bionic Distro

2020-05-05 Thread GitBox
ilgrosso commented on pull request #182: URL: https://github.com/apache/syncope/pull/182#issuecomment-624039868 @mmoayyed I'd say it works, please go ahead, squash and merge, thanks. This is an automated message from the

[GitHub] [syncope] ilgrosso merged pull request #190: Enabling YAML-based IT run

2020-05-19 Thread GitBox
ilgrosso merged pull request #190: URL: https://github.com/apache/syncope/pull/190 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [syncope] ilgrosso opened a new pull request #190: Enabling YAML-based IT run

2020-05-19 Thread GitBox
ilgrosso opened a new pull request #190: URL: https://github.com/apache/syncope/pull/190 After fixing [SYNCOPE-1564](https://issues.apache.org/jira/browse/SYNCOPE-1564) we are ready to add YAML-based integration tests to the collection run by Travis CI.

[GitHub] [syncope] ilgrosso commented on a change in pull request #189: SYNCOPE-1562: Manage tokens for WA GoogleAuth MFA

2020-05-19 Thread GitBox
ilgrosso commented on a change in pull request #189: URL: https://github.com/apache/syncope/pull/189#discussion_r427355325 ## File path: core/persistence-api/src/main/java/org/apache/syncope/core/persistence/api/dao/auth/GoogleMfaAuthTokenDAO.java ## @@ -0,0 +1,49 @@ +/* + *

[GitHub] [syncope] ilgrosso commented on pull request #214: SYNCOPE-1587: WA Web AuthN MFA support

2020-09-11 Thread GitBox
ilgrosso commented on pull request #214: URL: https://github.com/apache/syncope/pull/214#issuecomment-691062278 @mmoayyed this PR looks good, but it seems there are issues with downloading transitive deps: https://travis-ci.org/github/apache/syncope/jobs/726236247#L433

[GitHub] [syncope] mmoayyed opened a new pull request #214: SYNCOPE-1587: WA Web AuthN MFA support

2020-09-11 Thread GitBox
mmoayyed opened a new pull request #214: URL: https://github.com/apache/syncope/pull/214 https://issues.apache.org/jira/browse/SYNCOPE-1587 Adds baseline support for WA. Device registration and management APIs may be done in a separate pull request.

[GitHub] [syncope] andrea-patricelli opened a new pull request #213: Fog catcher: Propagation task executions and no-SQL persistence

2020-09-08 Thread GitBox
andrea-patricelli opened a new pull request #213: URL: https://github.com/apache/syncope/pull/213 This is the fog-catcher implementation for "Propagation task executions and no-SQL persistence", that includes: - Refactoring of persistence layer to have a table for each task type

[GitHub] [syncope] ilgrosso commented on pull request #214: SYNCOPE-1587: WA Web AuthN MFA support

2020-09-12 Thread GitBox
ilgrosso commented on pull request #214: URL: https://github.com/apache/syncope/pull/214#issuecomment-691062278 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [syncope] mmoayyed commented on pull request #214: SYNCOPE-1587: WA Web AuthN MFA support

2020-09-12 Thread GitBox
mmoayyed commented on pull request #214: URL: https://github.com/apache/syncope/pull/214#issuecomment-691188147 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [syncope] mmoayyed commented on pull request #214: SYNCOPE-1587: WA Web AuthN MFA support

2020-09-12 Thread GitBox
mmoayyed commented on pull request #214: URL: https://github.com/apache/syncope/pull/214#issuecomment-691188147 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [syncope] ilgrosso commented on pull request #214: SYNCOPE-1587: WA Web AuthN MFA support

2020-09-14 Thread GitBox
ilgrosso commented on pull request #214: URL: https://github.com/apache/syncope/pull/214#issuecomment-691916300 @mmoayyed agree about CI This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [syncope] mmoayyed merged pull request #214: SYNCOPE-1587: WA Web AuthN MFA support

2020-09-14 Thread GitBox
mmoayyed merged pull request #214: URL: https://github.com/apache/syncope/pull/214 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [syncope] mmoayyed commented on pull request #214: SYNCOPE-1587: WA Web AuthN MFA support

2020-09-14 Thread GitBox
mmoayyed commented on pull request #214: URL: https://github.com/apache/syncope/pull/214#issuecomment-691917455 Sure. I'll make the adjustment shortly. This is an automated message from the Apache Git Service. To respond to

[GitHub] [syncope] mmoayyed commented on pull request #214: SYNCOPE-1587: WA Web AuthN MFA support

2020-09-14 Thread GitBox
mmoayyed commented on pull request #214: URL: https://github.com/apache/syncope/pull/214#issuecomment-691915205 This looks to be passing. CI failures seem random/phantom to me. This is an automated message from the Apache

[GitHub] [syncope] ilgrosso commented on a change in pull request #215: [SYNCOPE-1588] Consent Policy

2020-09-14 Thread GitBox
ilgrosso commented on a change in pull request #215: URL: https://github.com/apache/syncope/pull/215#discussion_r487823095 ## File path: common/am/lib/src/main/java/org/apache/syncope/common/lib/policy/AllowedAttrReleasePolicyConf.java ## @@ -29,9 +34,63 @@ * Specify

[GitHub] [syncope] DimaAy merged pull request #215: [SYNCOPE-1588] Consent Policy

2020-09-14 Thread GitBox
DimaAy merged pull request #215: URL: https://github.com/apache/syncope/pull/215 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [syncope] ilgrosso commented on a change in pull request #213: Fog catcher: Propagation task executions and no-SQL persistence

2020-09-09 Thread GitBox
ilgrosso commented on a change in pull request #213: URL: https://github.com/apache/syncope/pull/213#discussion_r485375660 ## File path: client/console/src/main/resources/org/apache/syncope/client/console/panels/GroupDirectoryPanel_fr_CA.properties ## @@ -16,3 +16,4 @@ #

[GitHub] [syncope] ilgrosso merged pull request #217: Fixing CodeQL analysis

2020-10-07 Thread GitBox
ilgrosso merged pull request #217: URL: https://github.com/apache/syncope/pull/217 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

  1   2   3   4   5   6   7   8   9   >