[GitHub] thrift pull request #1218: export thrift::mem::TBufferTransport

2017-03-20 Thread flier
GitHub user flier opened a pull request: https://github.com/apache/thrift/pull/1218 export thrift::mem::TBufferTransport We need export `thrift::mem::TBufferTransport` to serialize record to a memory based buffer, then send the buffer through other transport like Kafka You can mer

[GitHub] thrift issue #1214: THRIFT-2026: Eliminate some undefined behavior in C/C++

2017-03-20 Thread jbapple-cloudera
Github user jbapple-cloudera commented on the issue: https://github.com/apache/thrift/pull/1214 Can this be on hold for a bit? I would like to add the UBSan checks to .travis.yml first, which may take a couple of days for me to have time for. --- If your project is set up for it, you

[jira] [Commented] (THRIFT-2026) Fix TCompactProtocol 64 bit builds

2017-03-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932755#comment-15932755 ] ASF GitHub Bot commented on THRIFT-2026: Github user jbapple-cloudera commented o

[GitHub] thrift issue #1218: export thrift::mem::TBufferTransport

2017-03-20 Thread sunchao
Github user sunchao commented on the issue: https://github.com/apache/thrift/pull/1218 I created a ticket for this: THRIFT-4113. However, a easy workaround is to just create a wrapper around the memory buffer, and implement Read + Write yourself. --- If your project is set up for it

[jira] [Commented] (THRIFT-4113) Provide a buffer transport for reading/writing in memory byte stream

2017-03-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15933035#comment-15933035 ] ASF GitHub Bot commented on THRIFT-4113: Github user sunchao commented on the iss

[GitHub] thrift pull request #1214: THRIFT-2026: Eliminate some undefined behavior in...

2017-03-20 Thread jeking3
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1214#discussion_r106959992 --- Diff: compiler/cpp/src/thrift/parse/t_field.h --- @@ -68,7 +68,7 @@ class t_field : public t_doc { int32_t get_key() const { return key_; }

[jira] [Commented] (THRIFT-2026) Fix TCompactProtocol 64 bit builds

2017-03-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15933089#comment-15933089 ] ASF GitHub Bot commented on THRIFT-2026: Github user jeking3 commented on a diff

[GitHub] thrift issue #1218: export thrift::mem::TBufferTransport

2017-03-20 Thread flier
Github user flier commented on the issue: https://github.com/apache/thrift/pull/1218 Thanks, we use open source project because we are not intent to reinvent wheel :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo