[
https://issues.apache.org/jira/browse/THRIFT-4329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177110#comment-16177110
]
ASF GitHub Bot commented on THRIFT-4329:
Github user gadLinux commented on the issue:
Github user gadLinux commented on the issue:
https://github.com/apache/thrift/pull/1361
It seems the protocol decorator was removed, I suppose I copied and pasted
wrong...
I always forget that the build system is Cmake and forget to test it
against it.
---
[
https://issues.apache.org/jira/browse/THRIFT-3766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177123#comment-16177123
]
ASF GitHub Bot commented on THRIFT-3766:
Github user Jens-G commented on the issue:
[
https://issues.apache.org/jira/browse/THRIFT-3821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177255#comment-16177255
]
ASF GitHub Bot commented on THRIFT-3821:
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/THRIFT-3821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177257#comment-16177257
]
James E. King, III commented on THRIFT-3821:
I checked in a small change to make the maximum
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1012
@jfarrell this can be closed; it was resolved as won't fix.
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1015
@jfarrell this PR can be closed; the line of code removed here was already
done by another commit.
---
[
https://issues.apache.org/jira/browse/THRIFT-3766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177160#comment-16177160
]
ASF GitHub Bot commented on THRIFT-3766:
Github user jeking3 commented on the issue:
[
https://issues.apache.org/jira/browse/THRIFT-3916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177263#comment-16177263
]
ASF GitHub Bot commented on THRIFT-3916:
Github user jeking3 commented on the issue:
[
https://issues.apache.org/jira/browse/THRIFT-3830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177259#comment-16177259
]
ASF GitHub Bot commented on THRIFT-3830:
Github user jeking3 commented on the issue:
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1075
@SimenB if you are interested in resurrecting this let me know - rebase on
current master and push to CI will run all our tests.
---
[
https://issues.apache.org/jira/browse/THRIFT-4339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176936#comment-16176936
]
James E. King, III commented on THRIFT-4339:
In the future add the Jira item to the front of
[
https://issues.apache.org/jira/browse/THRIFT-4340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III updated THRIFT-4340:
---
Description:
When a client closes a connection to a framed server the server was
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1370
Test
---
[
https://issues.apache.org/jira/browse/THRIFT-3766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177112#comment-16177112
]
ASF GitHub Bot commented on THRIFT-3766:
Github user Jens-G commented on the issue:
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1370
Yeah, test. I got only 2 mails this time. Your comment generated 3 mails. I
had cases where I got up to 7 mails for one github comment.
---
[
https://issues.apache.org/jira/browse/THRIFT-4329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III updated THRIFT-4329:
---
Affects Version/s: (was: 1.0)
0.10.0
> c_glib Doesn't
[
https://issues.apache.org/jira/browse/THRIFT-4329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III updated THRIFT-4329:
---
Fix Version/s: (was: 1.0)
> c_glib Doesn't have a multiplexed processor
>
[
https://issues.apache.org/jira/browse/THRIFT-2740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III reassigned THRIFT-2740:
--
Assignee: James E. King, III
> Perl coding standards
> -
[
https://issues.apache.org/jira/browse/THRIFT-2740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176960#comment-16176960
]
James E. King, III commented on THRIFT-2740:
[~hcorg] Sufficient to resolve this issue?
Github user gadLinux commented on the issue:
https://github.com/apache/thrift/pull/1361
Perfect, now fails on things not related to my changes.
---
[
https://issues.apache.org/jira/browse/THRIFT-4329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177210#comment-16177210
]
ASF GitHub Bot commented on THRIFT-4329:
Github user gadLinux commented on the issue:
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1370
---
[
https://issues.apache.org/jira/browse/THRIFT-3766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177251#comment-16177251
]
ASF GitHub Bot commented on THRIFT-3766:
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/THRIFT-3766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III resolved THRIFT-3766.
Resolution: Fixed
Fix Version/s: 0.11.0
> Add getUnderlyingTransport() to
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1370
I've been really busy. :)
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1263
This should be rebased on the current master as I have updated the docker
files. Perhaps if you could open a Jira ticket for this issue and rebase on
master and force push, we can get a more
Hi,
haven 't read your changes, but although I made the same proposal a while
ago here are my thoughts:
a) I'm against removing the patch method entirely
b) would nevertheless make clear that we absolutely prefer pull requests
c) make PRs mandatory only if the patch is beyond a certain size,
[
https://issues.apache.org/jira/browse/THRIFT-3766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177118#comment-16177118
]
ASF GitHub Bot commented on THRIFT-3766:
Github user jeking3 commented on the issue:
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1370
@Jens-G test?
---
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1369
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1361
@gadLinux I am running the cross test suite locally. The errors in the
build appear to be in c_glib...
---
[
https://issues.apache.org/jira/browse/THRIFT-4329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177270#comment-16177270
]
ASF GitHub Bot commented on THRIFT-4329:
Github user jeking3 commented on the issue:
[
https://issues.apache.org/jira/browse/THRIFT-4329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176220#comment-16176220
]
ASF GitHub Bot commented on THRIFT-4329:
Github user gadLinux commented on the issue:
Github user gadLinux commented on the issue:
https://github.com/apache/thrift/pull/1361
rebased
---
Github user gadLinux commented on the issue:
https://github.com/apache/thrift/pull/1361
Ok. I will do it.
---
[
https://issues.apache.org/jira/browse/THRIFT-4329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176018#comment-16176018
]
ASF GitHub Bot commented on THRIFT-4329:
Github user gadLinux commented on the issue:
[
https://issues.apache.org/jira/browse/THRIFT-4329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177362#comment-16177362
]
ASF GitHub Bot commented on THRIFT-4329:
Github user jeking3 commented on the issue:
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1361
Hmm, I ran cross tests locally and multi isn't being exercised for c_glib
server:
```
root@ecb350ad7c01:/thrift/src# test/test.py --server c_glib --client java
Apache Thrift -
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1361
This passed for me locally on a full cross, so I'll merge it.
---
[
https://issues.apache.org/jira/browse/THRIFT-4326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177489#comment-16177489
]
ASF GitHub Bot commented on THRIFT-4326:
Github user benweint commented on the issue:
Github user benweint closed the pull request at:
https://github.com/apache/thrift/pull/1352
---
[
https://issues.apache.org/jira/browse/THRIFT-4326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177490#comment-16177490
]
ASF GitHub Bot commented on THRIFT-4326:
Github user benweint closed the pull request at:
Github user benweint commented on the issue:
https://github.com/apache/thrift/pull/1352
Ok, I've finally figured out how to reproduce that test failure locally on
macOS. For posterity, here's what I did:
```
PATH="/usr/local/opt/bison/bin:$PATH" ./configure
[
https://issues.apache.org/jira/browse/THRIFT-4329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177363#comment-16177363
]
ASF GitHub Bot commented on THRIFT-4329:
Github user jeking3 commented on the issue:
[
https://issues.apache.org/jira/browse/THRIFT-4283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jean-Noël Goor updated THRIFT-4283:
---
Fix Version/s: 0.11.0
> TNamedPipeServer race condition in interrupt
>
[
https://issues.apache.org/jira/browse/THRIFT-4283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176389#comment-16176389
]
James E. King, III commented on THRIFT-4283:
Hi, thanks for the patch. Someone needs to make
[
https://issues.apache.org/jira/browse/THRIFT-4264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176404#comment-16176404
]
ASF GitHub Bot commented on THRIFT-4264:
Github user norrs commented on the issue:
[
https://issues.apache.org/jira/browse/THRIFT-4336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xiaomingzhongguo updated THRIFT-4336:
-
Description:
Run in TThreadedServer mode
run some times,thrift accept thread lock at
[
https://issues.apache.org/jira/browse/THRIFT-4340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176338#comment-16176338
]
ASF GitHub Bot commented on THRIFT-4340:
Github user jeking3 commented on the issue:
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1367
---
[
https://issues.apache.org/jira/browse/THRIFT-4340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III resolved THRIFT-4340.
Resolution: Fixed
Committed - thanks.
> Erlang fix a crash on client close
>
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1367
I opened THRIFT-4340 for you on this.
---
[
https://issues.apache.org/jira/browse/THRIFT-4329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176409#comment-16176409
]
ASF GitHub Bot commented on THRIFT-4329:
Github user gadLinux commented on the issue:
Github user gadLinux commented on the issue:
https://github.com/apache/thrift/pull/1361
I just went back in history and pushed again after rebase. Now it should be
ok
---
[
https://issues.apache.org/jira/browse/THRIFT-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176324#comment-16176324
]
Allen George commented on THRIFT-4187:
--
Ooops. Yup - will get on this soon!
> Dart -> Rust Framed
[
https://issues.apache.org/jira/browse/THRIFT-4329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176356#comment-16176356
]
ASF GitHub Bot commented on THRIFT-4329:
Github user jeking3 commented on the issue:
Github user norrs commented on the issue:
https://github.com/apache/thrift/pull/1315
@jeking3 : Done; let's see how it goes this time.
---
James E. King, III created THRIFT-4340:
--
Summary: Erlang fix a crash on client close
Key: THRIFT-4340
URL: https://issues.apache.org/jira/browse/THRIFT-4340
Project: Thrift
Issue Type:
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1361
Doesn't look like a rebase, unfortunately.
What I would suggest is that you refresh your master from upstream, branch
off it, cherry-pick the original commits you made in order, then squash them
[
https://issues.apache.org/jira/browse/THRIFT-4329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176358#comment-16176358
]
ASF GitHub Bot commented on THRIFT-4329:
Github user jeking3 commented on the issue:
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1361
Try this:
```
git checkout master
git pull upstream master
git checkout -b THRIFT-4329-take-2
git cherry-pick 1d1d9d8
git cherry-pick 0aedc8a
git cherry-pick 3df26ec
[
https://issues.apache.org/jira/browse/THRIFT-4283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176430#comment-16176430
]
Jean-Noël Goor commented on THRIFT-4283:
I would prefer you to do it if you don't mind. Thanks.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1361
Build job 4 failed in ruby testing. Looking for a match in PRs or Jira.
---
[
https://issues.apache.org/jira/browse/THRIFT-4341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Merter Sualp updated THRIFT-4341:
-
Description:
While using thrift-maven-plugin, we define our Javascript execution as below:
We've been using github for a while now. At this point everyone should be
expected to submit changes to the project through github. Tickets in Jira
that have patches without a pull request experience significant delays. I
would prefer to see the Jira option for "Patch Available" removed. Folks
[
https://issues.apache.org/jira/browse/THRIFT-4264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III reassigned THRIFT-4264:
--
Assignee: James E. King, III
> PHP - Support both shared & static linking of
[
https://issues.apache.org/jira/browse/THRIFT-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176561#comment-16176561
]
James E. King, III commented on THRIFT-2913:
Appeared again in a pull request:
Merter Sualp created THRIFT-4341:
Summary: No WARNING or ERROR when included .thrift file is not
found
Key: THRIFT-4341
URL: https://issues.apache.org/jira/browse/THRIFT-4341
Project: Thrift
[
https://issues.apache.org/jira/browse/THRIFT-4341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Merter Sualp updated THRIFT-4341:
-
Description:
While using thrift-maven-plugin, we define our Javascript execution as below:
[
https://issues.apache.org/jira/browse/THRIFT-4341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Merter Sualp updated THRIFT-4341:
-
Description:
While using thrift-maven-plugin, we define our Javascript execution as below:
[
https://issues.apache.org/jira/browse/THRIFT-4341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Merter Sualp updated THRIFT-4341:
-
Priority: Minor (was: Major)
Summary: No WARNING or ERROR when included .thrift file is not
[
https://issues.apache.org/jira/browse/THRIFT-4264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III resolved THRIFT-4264.
Resolution: Fixed
Fix Version/s: 0.11.0
Committed, thanks.
> PHP - Support
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1315
---
[
https://issues.apache.org/jira/browse/THRIFT-4329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176551#comment-16176551
]
ASF GitHub Bot commented on THRIFT-4329:
Github user jeking3 commented on the issue:
[
https://issues.apache.org/jira/browse/THRIFT-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III updated THRIFT-2913:
---
Environment:
openSUSE 13.2, Ruby 2.1.0
also in docker ubuntu-xenial image, per CI
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1361
Ruby error in build job 4 is
https://issues.apache.org/jira/browse/THRIFT-2913. c_glib unit tests ran so we
can overlook this failure.
---
[
https://issues.apache.org/jira/browse/THRIFT-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III updated THRIFT-2913:
---
Affects Version/s: 0.10.0
> Ruby Server Thrift::ThreadPoolServer should serve inside
[
https://issues.apache.org/jira/browse/THRIFT-4329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176565#comment-16176565
]
ASF GitHub Bot commented on THRIFT-4329:
Github user jeking3 commented on the issue:
[
https://issues.apache.org/jira/browse/THRIFT-4341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Merter Sualp updated THRIFT-4341:
-
Attachment: no_thrift_js_reported.jpg
> No WARNING or ERROR when included .thrift file is not
[
https://issues.apache.org/jira/browse/THRIFT-4264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176543#comment-16176543
]
ASF GitHub Bot commented on THRIFT-4264:
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/THRIFT-4258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176637#comment-16176637
]
James E. King, III commented on THRIFT-4258:
The current implementation supports C++03 as
[
https://issues.apache.org/jira/browse/THRIFT-4283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176665#comment-16176665
]
ASF GitHub Bot commented on THRIFT-4283:
GitHub user jeking3 opened a pull request:
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1368
THRIFT-4283: fix TNamedPipeServer race condition in interrupt
Client: C++
Patch: jn.g...@evs.com
You can merge this pull request into a Git repository by running:
$ git pull
[
https://issues.apache.org/jira/browse/THRIFT-4289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176603#comment-16176603
]
James E. King, III commented on THRIFT-4289:
Would you be able to submit a github pull
James E. King, III created THRIFT-4342:
--
Summary: Support ruby rspec 3
Key: THRIFT-4342
URL: https://issues.apache.org/jira/browse/THRIFT-4342
Project: Thrift
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/THRIFT-4283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III reassigned THRIFT-4283:
--
Assignee: James E. King, III
> TNamedPipeServer race condition in interrupt
>
[
https://issues.apache.org/jira/browse/THRIFT-3480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III reassigned THRIFT-3480:
--
Assignee: James E. King, III
> offer a simple approach to compute byte size
[
https://issues.apache.org/jira/browse/THRIFT-3480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III resolved THRIFT-3480.
Resolution: Won't Fix
This can be achieved with a TMemoryBuffer (I wrote a unit
[
https://issues.apache.org/jira/browse/THRIFT-3480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III closed THRIFT-3480.
--
> offer a simple approach to compute byte size of the serialized object
>
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1369
THRIFT-3821: make memory buffer size configurable
so unit test doesn't need 2GB to run;
also added a unit test to prove THRIFT-3480 alternative
You can merge this pull request into a Git
[
https://issues.apache.org/jira/browse/THRIFT-3821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176872#comment-16176872
]
ASF GitHub Bot commented on THRIFT-3821:
GitHub user jeking3 opened a pull request:
[
https://issues.apache.org/jira/browse/THRIFT-4283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176735#comment-16176735
]
ASF GitHub Bot commented on THRIFT-4283:
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/THRIFT-4283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III resolved THRIFT-4283.
Resolution: Fixed
Committed, thanks.
> TNamedPipeServer race condition in
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1368
---
[
https://issues.apache.org/jira/browse/THRIFT-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176737#comment-16176737
]
James E. King, III commented on THRIFT-1761:
Any interest in reviving this, or can it be
Github user djnym commented on the issue:
https://github.com/apache/thrift/pull/1367
I added a jira ticket yesterday
https://issues.apache.org/jira/browse/THRIFT-4339
---
[
https://issues.apache.org/jira/browse/THRIFT-4339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176879#comment-16176879
]
ASF GitHub Bot commented on THRIFT-4339:
Github user djnym commented on the issue:
[
https://issues.apache.org/jira/browse/THRIFT-4339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anthony Molinaro updated THRIFT-4339:
-
Attachment: erl_framed_transport_fix.patch
> Thrift Framed Transport in Erlang crashes
[
https://issues.apache.org/jira/browse/THRIFT-3481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176882#comment-16176882
]
James E. King, III commented on THRIFT-3481:
I agree with [~nsuke] here - modifying
1 - 100 of 110 matches
Mail list logo
