[jira] [Updated] (THRIFT-4214) map key treated as hex value in JavaScript

[ https://issues.apache.org/jira/browse/THRIFT-4214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Teodor Atroshenko updated THRIFT-4214: -- Component/s: (was: JavaScript - Library) (was: JavaScript -

Re: Can changes for the 0.12.0 compiler still be submitted?

A bit of background on that commit since I authored it: The feature is behind a new compiler flag which hasn't been released yet, so it should be safe to include as well as a non-breaking feature addition. If you want to cherry pick it, I think it's fine but it isn't critical to include it.

[jira] [Commented] (THRIFT-4214) map key treated as hex value in JavaScript

[ https://issues.apache.org/jira/browse/THRIFT-4214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678663#comment-16678663 ] ASF GitHub Bot commented on THRIFT-4214: thexeos commented on issue #1519: THRIFT-4214: map key

[jira] [Created] (THRIFT-4663) Request payload is two endpoints concatenated together

David Wire created THRIFT-4663: -- Summary: Request payload is two endpoints concatenated together Key: THRIFT-4663 URL: https://issues.apache.org/jira/browse/THRIFT-4663 Project: Thrift Issue

[jira] [Updated] (THRIFT-4663) Request payload is two endpoints concatenated together

[ https://issues.apache.org/jira/browse/THRIFT-4663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Wire updated THRIFT-4663: --- Description: Originally encountered as a 500 error received from our server. Investigating the

[jira] [Commented] (THRIFT-4663) Request payload is two endpoints concatenated together

[ https://issues.apache.org/jira/browse/THRIFT-4663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678917#comment-16678917 ] Brian Forbis commented on THRIFT-4663: -- Seems to be related to THRIFT-4564 maybe? > Request

[jira] [Commented] (THRIFT-4663) Request payload is two endpoints concatenated together

[ https://issues.apache.org/jira/browse/THRIFT-4663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679223#comment-16679223 ] David Wire commented on THRIFT-4663: That does read pretty similarly. Weird that it's marked as

[jira] [Commented] (THRIFT-4451) Rust client fails to communicate with multiplexed perl/c_glib servers

[ https://issues.apache.org/jira/browse/THRIFT-4451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679271#comment-16679271 ] Allen George commented on THRIFT-4451: -- Somehow the client is shutting down the connection before

[jira] [Commented] (THRIFT-4661) Rust enum name wrong case in generated structs

[ https://issues.apache.org/jira/browse/THRIFT-4661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678112#comment-16678112 ] ASF GitHub Bot commented on THRIFT-4661: allengeorge commented on issue #1623: THRIFT-4661: Rust

[jira] [Commented] (THRIFT-4529) Rust generation should include #![allow(non_snake_case)] or force conform to Rust style guidelines

[ https://issues.apache.org/jira/browse/THRIFT-4529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678114#comment-16678114 ] Allen George commented on THRIFT-4529: -- Looks like it. For some reason I totally missed the variant

[jira] [Commented] (THRIFT-4529) Rust generation should include #![allow(non_snake_case)] or force conform to Rust style guidelines

[ https://issues.apache.org/jira/browse/THRIFT-4529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678088#comment-16678088 ] Allen George commented on THRIFT-4529: -- I'm sorry I missed this :/ Does this happen only for enum

[jira] [Issue Comment Deleted] (THRIFT-4529) Rust generation should include #![allow(non_snake_case)] or force conform to Rust style guidelines

[ https://issues.apache.org/jira/browse/THRIFT-4529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George updated THRIFT-4529: - Comment: was deleted (was: Looks like it. For some reason I totally missed the variant section

[jira] [Assigned] (THRIFT-4662) Rust const string calls function at compile time

[ https://issues.apache.org/jira/browse/THRIFT-4662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George reassigned THRIFT-4662: Assignee: Allen George > Rust const string calls function at compile time >

[jira] [Assigned] (THRIFT-4661) Rust enum name wrong case in generated structs

[ https://issues.apache.org/jira/browse/THRIFT-4661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George reassigned THRIFT-4661: Assignee: Allen George > Rust enum name wrong case in generated structs >

[jira] [Assigned] (THRIFT-4529) Rust generation should include #![allow(non_snake_case)] or force conform to Rust style guidelines

[ https://issues.apache.org/jira/browse/THRIFT-4529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George reassigned THRIFT-4529: Assignee: Allen George > Rust generation should include #![allow(non_snake_case)] or

[jira] [Commented] (THRIFT-4529) Rust generation should include #![allow(non_snake_case)] or force conform to Rust style guidelines

[ https://issues.apache.org/jira/browse/THRIFT-4529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678115#comment-16678115 ] Allen George commented on THRIFT-4529: -- Looks like it. For some reason I totally missed the variant

[jira] [Commented] (THRIFT-4662) Rust const string calls function at compile time

[ https://issues.apache.org/jira/browse/THRIFT-4662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677894#comment-16677894 ] ASF GitHub Bot commented on THRIFT-4662: jake-ruyi opened a new pull request #1624: THRIFT-4662:

[jira] [Commented] (THRIFT-4662) Rust const string calls function at compile time

[ https://issues.apache.org/jira/browse/THRIFT-4662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677895#comment-16677895 ] J W commented on THRIFT-4662: - Created PR: https://github.com/apache/thrift/pull/1624 > Rust const string

[jira] [Issue Comment Deleted] (THRIFT-4662) Rust const string calls function at compile time

[ https://issues.apache.org/jira/browse/THRIFT-4662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] J W updated THRIFT-4662: Comment: was deleted (was: Created PR: https://github.com/apache/thrift/pull/1624) > Rust const string calls

Can changes for the 0.12.0 compiler still be submitted?

Hi all - I’d like to cherry-pick a couple of PRs for the rust generator to the 0.12.0 branch. I know a message was sent about the branch being cut. Has packaging started yet? That is, is it too late for these generator changes to make it in for 0.12.0? Thanks, Allen

[jira] [Commented] (THRIFT-4661) Rust enum name wrong case in generated structs

[ https://issues.apache.org/jira/browse/THRIFT-4661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678107#comment-16678107 ] ASF GitHub Bot commented on THRIFT-4661: allengeorge commented on issue #1623: THRIFT-4661: Rust

[jira] [Commented] (THRIFT-4661) Rust enum name wrong case in generated structs

[ https://issues.apache.org/jira/browse/THRIFT-4661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677827#comment-16677827 ] ASF GitHub Bot commented on THRIFT-4661: jake-ruyi opened a new pull request #1623: THRIFT-4661:

[jira] [Commented] (THRIFT-4662) Rust const string calls function at compile time

[ https://issues.apache.org/jira/browse/THRIFT-4662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678210#comment-16678210 ] ASF GitHub Bot commented on THRIFT-4662: allengeorge commented on a change in pull request

[jira] [Commented] (THRIFT-4662) Rust const string calls function at compile time

[ https://issues.apache.org/jira/browse/THRIFT-4662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678211#comment-16678211 ] ASF GitHub Bot commented on THRIFT-4662: allengeorge commented on issue #1624: THRIFT-4662: Rust

[jira] [Commented] (THRIFT-4662) Rust const string calls function at compile time

[ https://issues.apache.org/jira/browse/THRIFT-4662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678281#comment-16678281 ] ASF GitHub Bot commented on THRIFT-4662: jake-ruyi commented on a change in pull request #1624:

Re: Can changes for the 0.12.0 compiler still be submitted?

Looking at the diff [1] most changes seem safe to include except da1169d - I'm not familiar enough with JS to comment on that. Cheers, Can [1] https://github.com/apache/thrift/compare/0.12.0...master On Wed, 7 Nov 2018, at 16:58, James E. King III wrote: > All changes since the branch was

Re: Can changes for the 0.12.0 compiler still be submitted?

All changes since the branch was taken should be scrutinized, including build system changes, for inclusion in 0.12.0. I haven't seen any follow-ups since my review comments on the 0.12.0 build. - Jim On Wed, Nov 7, 2018 at 6:52 AM Allen George wrote: > Hi all - > > I’d like to cherry-pick a