Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1326
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user asuhan commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1326#discussion_r132613779
--- Diff: lib/cpp/src/thrift/transport/TBufferTransports.cpp ---
@@ -361,9 +361,13 @@ void TMemoryBuffer::ensureCanWrite(uint32_t len) {
}
Github user asuhan commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1326#discussion_r132612556
--- Diff: lib/cpp/test/TMemoryBufferTest.cpp ---
@@ -117,4 +117,17 @@ BOOST_AUTO_TEST_CASE(test_exceptions) {
BOOST_CHECK_NO_THROW(buf2.write((const ui
Github user asuhan commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1326#discussion_r132612265
--- Diff: lib/cpp/src/thrift/transport/TBufferTransports.cpp ---
@@ -361,9 +361,13 @@ void TMemoryBuffer::ensureCanWrite(uint32_t len) {
}
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1326#discussion_r132611000
--- Diff: lib/cpp/src/thrift/transport/TBufferTransports.cpp ---
@@ -361,9 +361,13 @@ void TMemoryBuffer::ensureCanWrite(uint32_t len) {
}
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1326#discussion_r132611133
--- Diff: lib/cpp/test/TMemoryBufferTest.cpp ---
@@ -117,4 +117,17 @@ BOOST_AUTO_TEST_CASE(test_exceptions) {
BOOST_CHECK_NO_THROW(buf2.write((const u
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1326#discussion_r132545680
--- Diff: lib/cpp/src/thrift/transport/TBufferTransports.cpp ---
@@ -361,9 +361,12 @@ void TMemoryBuffer::ensureCanWrite(uint32_t len) {
}
GitHub user asuhan opened a pull request:
https://github.com/apache/thrift/pull/1326
THRIFT-3821
Going over 2 GB is quite possible when using Thrift for serialization. We
can detect the condition and throw an exception.
You can merge this pull request into a Git repository by runni
