[
https://issues.apache.org/jira/browse/THRIFT-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16122089#comment-16122089
]
Mario Emmenlauer commented on THRIFT-2221:
--
Thanks again [~jking] , super great
[
https://issues.apache.org/jira/browse/THRIFT-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16121953#comment-16121953
]
James E. King, III commented on THRIFT-2221:
Okay that one was fun... :)
> G
[
https://issues.apache.org/jira/browse/THRIFT-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16121952#comment-16121952
]
ASF GitHub Bot commented on THRIFT-2221:
Github user asfgit closed the pull reque
[
https://issues.apache.org/jira/browse/THRIFT-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16121937#comment-16121937
]
ASF GitHub Bot commented on THRIFT-2221:
Github user jeking3 commented on the iss
[
https://issues.apache.org/jira/browse/THRIFT-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16121665#comment-16121665
]
ASF GitHub Bot commented on THRIFT-2221:
Github user jeking3 commented on the iss
[
https://issues.apache.org/jira/browse/THRIFT-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16119994#comment-16119994
]
ASF GitHub Bot commented on THRIFT-2221:
Github user jeking3 commented on the iss
[
https://issues.apache.org/jira/browse/THRIFT-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16118943#comment-16118943
]
ASF GitHub Bot commented on THRIFT-2221:
Github user jeking3 commented on a diff
[
https://issues.apache.org/jira/browse/THRIFT-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16118931#comment-16118931
]
ASF GitHub Bot commented on THRIFT-2221:
Github user jeking3 commented on a diff
[
https://issues.apache.org/jira/browse/THRIFT-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16118932#comment-16118932
]
ASF GitHub Bot commented on THRIFT-2221:
Github user jeking3 commented on a diff
[
https://issues.apache.org/jira/browse/THRIFT-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16118928#comment-16118928
]
ASF GitHub Bot commented on THRIFT-2221:
Github user jeking3 commented on a diff
[
https://issues.apache.org/jira/browse/THRIFT-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16118758#comment-16118758
]
ASF GitHub Bot commented on THRIFT-2221:
Github user octopus-prime commented on a
[
https://issues.apache.org/jira/browse/THRIFT-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16118751#comment-16118751
]
ASF GitHub Bot commented on THRIFT-2221:
Github user octopus-prime commented on a
[
https://issues.apache.org/jira/browse/THRIFT-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16118619#comment-16118619
]
ASF GitHub Bot commented on THRIFT-2221:
Github user hcorg commented on a diff in
[
https://issues.apache.org/jira/browse/THRIFT-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16118614#comment-16118614
]
ASF GitHub Bot commented on THRIFT-2221:
Github user hcorg commented on a diff in
[
https://issues.apache.org/jira/browse/THRIFT-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16118603#comment-16118603
]
ASF GitHub Bot commented on THRIFT-2221:
Github user hcorg commented on a diff in
[
https://issues.apache.org/jira/browse/THRIFT-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16115459#comment-16115459
]
ASF GitHub Bot commented on THRIFT-2221:
GitHub user jeking3 opened a pull reques
[
https://issues.apache.org/jira/browse/THRIFT-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16115437#comment-16115437
]
ASF GitHub Bot commented on THRIFT-2221:
Github user jeking3 closed the pull requ
[
https://issues.apache.org/jira/browse/THRIFT-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16036873#comment-16036873
]
Mike Gresens commented on THRIFT-2221:
--
In my option std::unique_ptr is always avail
[
https://issues.apache.org/jira/browse/THRIFT-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16036853#comment-16036853
]
Mario Emmenlauer commented on THRIFT-2221:
--
I think this is the problem, but I d
[
https://issues.apache.org/jira/browse/THRIFT-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16036846#comment-16036846
]
Mike Gresens commented on THRIFT-2221:
--
Mario,
may be is not includes but used lat
[
https://issues.apache.org/jira/browse/THRIFT-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16036380#comment-16036380
]
Mario Emmenlauer commented on THRIFT-2221:
--
The patch works on several Linux der
[
https://issues.apache.org/jira/browse/THRIFT-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16036097#comment-16036097
]
Mario Emmenlauer commented on THRIFT-2221:
--
Thanks [~msg-72]! This is the key. W
[
https://issues.apache.org/jira/browse/THRIFT-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035060#comment-16035060
]
Mike Gresens commented on THRIFT-2221:
--
Mario,
try:
template using scoped_ptr = s
[
https://issues.apache.org/jira/browse/THRIFT-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16034550#comment-16034550
]
Mario Emmenlauer commented on THRIFT-2221:
--
Dear [~jking3], is there a cummulati
[
https://issues.apache.org/jira/browse/THRIFT-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15980573#comment-15980573
]
James E. King, III commented on THRIFT-2221:
I also found namespace pollution
[
https://issues.apache.org/jira/browse/THRIFT-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15980411#comment-15980411
]
Mario Emmenlauer commented on THRIFT-2221:
--
Two thumbs up for the great work!!!
[
https://issues.apache.org/jira/browse/THRIFT-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15980407#comment-15980407
]
James E. King, III commented on THRIFT-2221:
Things a developer shouldn't say
[
https://issues.apache.org/jira/browse/THRIFT-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15980217#comment-15980217
]
James E. King, III commented on THRIFT-2221:
This same technique for stdcxx.h
[
https://issues.apache.org/jira/browse/THRIFT-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15980216#comment-15980216
]
James E. King, III commented on THRIFT-2221:
[~hcorg] Good point; let's see h
[
https://issues.apache.org/jira/browse/THRIFT-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15980068#comment-15980068
]
ASF GitHub Bot commented on THRIFT-2221:
GitHub user jeking3 opened a pull reques
[
https://issues.apache.org/jira/browse/THRIFT-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15980020#comment-15980020
]
Mario Emmenlauer commented on THRIFT-2221:
--
Great work, I'm very curious to test
[
https://issues.apache.org/jira/browse/THRIFT-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15979967#comment-15979967
]
Konrad Grochowski commented on THRIFT-2221:
---
quick note: `scoped_ptr` to `share
[
https://issues.apache.org/jira/browse/THRIFT-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15979958#comment-15979958
]
James E. King, III commented on THRIFT-2221:
I was able to isolate the follow
[
https://issues.apache.org/jira/browse/THRIFT-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972998#comment-15972998
]
James E. King, III commented on THRIFT-2221:
It should be fairly easy to to.
[
https://issues.apache.org/jira/browse/THRIFT-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972900#comment-15972900
]
Mario Emmenlauer commented on THRIFT-2221:
--
This looks like a very suitable solu
[
https://issues.apache.org/jira/browse/THRIFT-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972558#comment-15972558
]
James E. King, III commented on THRIFT-2221:
I think it would be better to us
[
https://issues.apache.org/jira/browse/THRIFT-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972322#comment-15972322
]
Mario Emmenlauer commented on THRIFT-2221:
--
Maybe its possible to have both opti
[
https://issues.apache.org/jira/browse/THRIFT-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13922091#comment-13922091
]
Dima Korolev commented on THRIFT-2221:
--
Hi,
$0.02: I've put together a small piece
[
https://issues.apache.org/jira/browse/THRIFT-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13788158#comment-13788158
]
Henrique Mendonça commented on THRIFT-2221:
---
Hi Chris,
I was also just looking
[
https://issues.apache.org/jira/browse/THRIFT-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13788127#comment-13788127
]
Ben Craig commented on THRIFT-2221:
---
This probably isn't happening for a while. See so
40 matches
Mail list logo