Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/776
ah - ok. i get what is happening now. thanks for clarifying. in that case:
VOTE +1
---
[
https://issues.apache.org/jira/browse/TINKERPOP-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327748#comment-16327748
]
ASF GitHub Bot commented on TINKERPOP-1868:
---
Github user spmallette commented on the issue:
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/777
When I run the integration tests with `docker/build.sh -t -i` I get some
failures in spark - do they fail for you too @PBGraff ?
```text
[ERROR] Tests run: 619, Failures: 0,
[
https://issues.apache.org/jira/browse/TINKERPOP-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327733#comment-16327733
]
ASF GitHub Bot commented on TINKERPOP-1862:
---
Github user spmallette commented on the issue:
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/776
I don't think that it is a breaking change as it only prevents users from
sending traversals with invalid arguments for the `inject` step to the server
which should cause a runtime error
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/780
I think this could be re-targetted at the tp32 branch - is there any reason
not to @artem-aliev ?
---
[
https://issues.apache.org/jira/browse/TINKERPOP-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327743#comment-16327743
]
ASF GitHub Bot commented on TINKERPOP-1868:
---
Github user FlorianHockmann commented on the
stephen mallette created TINKERPOP-1872:
---
Summary: Apply edgeFunction in SparkMessenger
Key: TINKERPOP-1872
URL: https://issues.apache.org/jira/browse/TINKERPOP-1872
Project: TinkerPop
[
https://issues.apache.org/jira/browse/TINKERPOP-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Artem Aliev updated TINKERPOP-1870:
---
Affects Version/s: 3.2.7
3.3.1
> n^2 synchronious operation in
GitHub user artem-aliev opened a pull request:
https://github.com/apache/tinkerpop/pull/780
improve performace by not handling excepptions
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/artem-aliev/tinkerpop TINKERPOP-1871
Artem Aliev created TINKERPOP-1871:
--
Summary: Exception handling is slow in element ReferenceElement
creation
Key: TINKERPOP-1871
URL: https://issues.apache.org/jira/browse/TINKERPOP-1871
Project:
[
https://issues.apache.org/jira/browse/TINKERPOP-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Artem Aliev updated TINKERPOP-1870:
---
Attachment: findTraverserFixed.png
findTraverser2.png
[
https://issues.apache.org/jira/browse/TINKERPOP-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326941#comment-16326941
]
Artem Aliev commented on TINKERPOP-1870:
I wrapped the block into findVertexTraverser() method
[
https://issues.apache.org/jira/browse/TINKERPOP-1860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stephen mallette closed TINKERPOP-1860.
---
Resolution: Fixed
Assignee: stephen mallette
Fix Version/s: 3.3.2
[
https://issues.apache.org/jira/browse/TINKERPOP-1858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327148#comment-16327148
]
ASF GitHub Bot commented on TINKERPOP-1858:
---
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/TINKERPOP-1489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327164#comment-16327164
]
ASF GitHub Bot commented on TINKERPOP-1489:
---
Github user jorgebay commented on the issue:
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/776
If this is a breaking change for .NET users in some way, it would be good
to write something in the upgrade documentation about it. A changelog entry
would also be good (either way).
---
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/773
---
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/774
---
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/767
---
[
https://issues.apache.org/jira/browse/TINKERPOP-1858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stephen mallette closed TINKERPOP-1858.
---
Resolution: Fixed
Assignee: stephen mallette
Fix Version/s: 3.3.2
[
https://issues.apache.org/jira/browse/TINKERPOP-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327233#comment-16327233
]
ASF GitHub Bot commented on TINKERPOP-1868:
---
Github user spmallette commented on the issue:
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/778#discussion_r161835490
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/gryo/GryoVersion.java
---
@@ -305,6 +307,7 @@ public String
[
https://issues.apache.org/jira/browse/TINKERPOP-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327465#comment-16327465
]
ASF GitHub Bot commented on TINKERPOP-1870:
---
Github user spmallette commented on a diff in
[
https://issues.apache.org/jira/browse/TINKERPOP-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327474#comment-16327474
]
ASF GitHub Bot commented on TINKERPOP-1870:
---
Github user spmallette commented on the issue:
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/778
I was about to ask for more details on how much of an improvement this was
in terms of performance, but it's on the JIRA issue - for others reviewing,
please see:
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/780
VOTE: +1
---
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/779
Can you please a) create a Jira ticket for this issue (then rename the PR
accordingly) and b) add a test case, that would fail without this change?
---
[
https://issues.apache.org/jira/browse/TINKERPOP-1861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327243#comment-16327243
]
ASF GitHub Bot commented on TINKERPOP-1861:
---
Github user spmallette commented on a diff in
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/772
> My concern is that people may still override/implement the old method and
not the new one, thus yielding programs that don't execute properly
Hmmas I look at the way it is now,
[
https://issues.apache.org/jira/browse/TINKERPOP-1861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327267#comment-16327267
]
ASF GitHub Bot commented on TINKERPOP-1861:
---
Github user spmallette commented on the issue:
[
https://issues.apache.org/jira/browse/TINKERPOP-1867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327780#comment-16327780
]
ASF GitHub Bot commented on TINKERPOP-1867:
---
Github user spmallette commented on the issue:
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/775
I was hoping I could come up with some other form of testing for this
change, but I can't seem to think of anything...
VOTE +1 (pending changelog entry)
---
[
https://issues.apache.org/jira/browse/TINKERPOP-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16328128#comment-16328128
]
ASF GitHub Bot commented on TINKERPOP-1862:
---
Github user PBGraff commented on the issue:
[
https://issues.apache.org/jira/browse/TINKERPOP-1860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327116#comment-16327116
]
ASF GitHub Bot commented on TINKERPOP-1860:
---
Github user asfgit closed the pull request at:
35 matches
Mail list logo
