Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/621
This test has two `prettyPrint()` assertions.
The first does `prettyPrint()` no args. It passes. However, it's strange
in that two of the `found`s catch the same line:
```
[
https://issues.apache.org/jira/browse/TINKERPOP-1865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16409477#comment-16409477
]
ASF GitHub Bot commented on TINKERPOP-1865:
---
Github user spmallette commented on the issue:
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/820
VOTE +1
---
[
https://issues.apache.org/jira/browse/TINKERPOP-1682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16409395#comment-16409395
]
ASF GitHub Bot commented on TINKERPOP-1682:
---
Github user robertdale commented on the issue:
Github user rcaunt commented on the issue:
https://github.com/apache/tinkerpop/pull/818
@spmallette I've been working with @jbaker-nca to understand this issue a
bit more.
Our use case for discovering this bug was essentially merging two separate
graphs into a single graph.
[
https://issues.apache.org/jira/browse/TINKERPOP-1682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16409464#comment-16409464
]
ASF GitHub Bot commented on TINKERPOP-1682:
---
Github user spmallette commented on the issue:
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/621
I'm sorta +0 to add a new strategy right before release, so I'm fine to see
this wait for the next round of releases. also, this is targetted at tp33 - is
there a specific reason for that?
[
https://issues.apache.org/jira/browse/TINKERPOP-1880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jorge Bay updated TINKERPOP-1880:
-
Fix Version/s: 3.3.2
3.2.8
> Gremlin.NET Strong name signature could not
[
https://issues.apache.org/jira/browse/TINKERPOP-1682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16409591#comment-16409591
]
ASF GitHub Bot commented on TINKERPOP-1682:
---
Github user robertdale commented on the issue:
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/621
@dkuppitz
https://gist.github.com/robertdale/8b5fa41432d29b3e99bf5ff2515dff3d
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/822
could you please update the dev docs with the .NET core version required
now:
[
https://issues.apache.org/jira/browse/TINKERPOP-1880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16409581#comment-16409581
]
ASF GitHub Bot commented on TINKERPOP-1880:
---
Github user jorgebay commented on the issue:
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/822
Nice catch @spmallette, I've fixed it.
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/818
@rcaunt how did you do this part:
> copy the edges from the original vertex to a new one
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/621
Looks like my line is longer because it has `vertex` instead of `edge`.
---
[
https://issues.apache.org/jira/browse/TINKERPOP-1682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16409633#comment-16409633
]
ASF GitHub Bot commented on TINKERPOP-1682:
---
Github user robertdale commented on the issue:
[
https://issues.apache.org/jira/browse/TINKERPOP-1923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16409631#comment-16409631
]
ASF GitHub Bot commented on TINKERPOP-1923:
---
Github user spmallette commented on the issue:
GitHub user jorgebay opened a pull request:
https://github.com/apache/tinkerpop/pull/822
TINKERPOP-1880 Sign assembly on Linux and macOS
With the latest .NET Core SDK (2.1.101), its now possible to sign
assemblies from Linux and macOS.
We should update our own local
[
https://issues.apache.org/jira/browse/TINKERPOP-1928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16409536#comment-16409536
]
stephen mallette commented on TINKERPOP-1928:
-
> I personally think that providing an
[
https://issues.apache.org/jira/browse/TINKERPOP-1682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16409510#comment-16409510
]
ASF GitHub Bot commented on TINKERPOP-1682:
---
Github user dkuppitz commented on the issue:
[
https://issues.apache.org/jira/browse/TINKERPOP-1923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16409673#comment-16409673
]
ASF GitHub Bot commented on TINKERPOP-1923:
---
Github user jbaker-nca commented on the issue:
[
https://issues.apache.org/jira/browse/TINKERPOP-1880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16409541#comment-16409541
]
ASF GitHub Bot commented on TINKERPOP-1880:
---
GitHub user jorgebay opened a pull request:
[
https://issues.apache.org/jira/browse/TINKERPOP-1880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16409562#comment-16409562
]
ASF GitHub Bot commented on TINKERPOP-1880:
---
Github user spmallette commented on the issue:
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/621
@dkuppitz Still, why is it testing `prettyPrint()` and `prettyPrint(160)`?
What does the `160` do for us?
---
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/621
Ah, because `IncidentToAdjacentStrategy` kicks in earlier on your system
(for whatever reason).
> What does the 160 do for us?
AFAIK, the Gremlin console determines the width of your
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/621
I saw a lot of queries recently, that would have benefited from this
strategy's rewrites, that's why I wanted to get it into the 3.3 line. But if
you prefer to wait, I'm fine with it.
[
https://issues.apache.org/jira/browse/TINKERPOP-1682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16409602#comment-16409602
]
ASF GitHub Bot commented on TINKERPOP-1682:
---
Github user robertdale commented on the issue:
Github user jbaker-nca commented on the issue:
https://github.com/apache/tinkerpop/pull/818
The copying code is as follows (I've simplified a little to make it clearer
what's happening, as it's actually part of a bigger chunk code):
List newEdges = new
[
https://issues.apache.org/jira/browse/TINKERPOP-1880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16409440#comment-16409440
]
Jorge Bay commented on TINKERPOP-1880:
--
I've just verified that .NET Core 2.1.101 SDK on macOS is
[
https://issues.apache.org/jira/browse/TINKERPOP-1866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16409876#comment-16409876
]
stephen mallette commented on TINKERPOP-1866:
-
I think that I have the basics of this
[
https://issues.apache.org/jira/browse/TINKERPOP-1866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stephen mallette reassigned TINKERPOP-1866:
---
Assignee: stephen mallette
> Support g:T for .NET
>
[
https://issues.apache.org/jira/browse/TINKERPOP-1682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16409694#comment-16409694
]
ASF GitHub Bot commented on TINKERPOP-1682:
---
Github user dkuppitz commented on the issue:
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/820
I think that I need this one merged to properly test out TINKERPOP-1866 as
`T` serialization only works right on GraphSON 3.0
---
[
https://issues.apache.org/jira/browse/TINKERPOP-1865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410001#comment-16410001
]
ASF GitHub Bot commented on TINKERPOP-1865:
---
Github user spmallette commented on the issue:
[
https://issues.apache.org/jira/browse/TINKERPOP-1865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410131#comment-16410131
]
ASF GitHub Bot commented on TINKERPOP-1865:
---
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/TINKERPOP-1865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stephen mallette closed TINKERPOP-1865.
---
Resolution: Fixed
Assignee: Florian Hockmann (was: Jorge Bay)
> Run
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/820
---
So, TINKERPOP-1865 merged and TINKERPOP-1866 is in PR form awaiting review:
https://github.com/apache/tinkerpop/pull/823
Insanely great work from Florian Hockmann killing all these .NET tickets on
the way up to release prior to his holiday time - appreciated!
I think we also want to get in
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/823#discussion_r176566595
--- Diff:
gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/ScenarioData.cs ---
@@ -30,6 +30,7 @@
using Gremlin.Net.Process.Remote;
[
https://issues.apache.org/jira/browse/TINKERPOP-1880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410263#comment-16410263
]
ASF GitHub Bot commented on TINKERPOP-1880:
---
Github user dkuppitz commented on the issue:
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/822
VOTE: +1
---
[
https://issues.apache.org/jira/browse/TINKERPOP-1866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410264#comment-16410264
]
ASF GitHub Bot commented on TINKERPOP-1866:
---
Github user spmallette commented on a diff in
GitHub user spmallette opened a pull request:
https://github.com/apache/tinkerpop/pull/823
TINKERPOP-1866 Support g:T for .NET
https://issues.apache.org/jira/browse/TINKERPOP-1866
Issuing this PR for @FlorianHockmann now that TINKERPOP-1865 has merged.
Builds with
[
https://issues.apache.org/jira/browse/TINKERPOP-1866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410152#comment-16410152
]
ASF GitHub Bot commented on TINKERPOP-1866:
---
GitHub user spmallette opened a pull request:
[
https://issues.apache.org/jira/browse/TINKERPOP-1866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410260#comment-16410260
]
ASF GitHub Bot commented on TINKERPOP-1866:
---
Github user dkuppitz commented on a diff in the
Github user dkuppitz commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/823#discussion_r176565685
--- Diff:
gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/CommonSteps.cs ---
@@ -239,7 +240,8 @@ private static object ToLambda(string
[
https://issues.apache.org/jira/browse/TINKERPOP-1866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410259#comment-16410259
]
ASF GitHub Bot commented on TINKERPOP-1866:
---
Github user dkuppitz commented on a diff in the
Github user dkuppitz commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/823#discussion_r176565903
--- Diff:
gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/ScenarioData.cs ---
@@ -30,6 +30,7 @@
using Gremlin.Net.Process.Remote;
[
https://issues.apache.org/jira/browse/TINKERPOP-1866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410279#comment-16410279
]
ASF GitHub Bot commented on TINKERPOP-1866:
---
Github user spmallette commented on a diff in
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/823
VOTE: +1
---
Github user dkuppitz commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/823#discussion_r176568322
--- Diff:
gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/CommonSteps.cs ---
@@ -239,7 +240,8 @@ private static object ToLambda(string
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/823#discussion_r176569502
--- Diff:
gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/ScenarioData.cs ---
@@ -30,6 +30,7 @@
using Gremlin.Net.Process.Remote;
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/823#discussion_r176567525
--- Diff:
gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/CommonSteps.cs ---
@@ -239,7 +240,8 @@ private static object ToLambda(string
[
https://issues.apache.org/jira/browse/TINKERPOP-1928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16409244#comment-16409244
]
Jorge Bay commented on TINKERPOP-1928:
--
I personally think that providing an implementation for
GitHub user ashwini-ms opened a pull request:
https://github.com/apache/tinkerpop/pull/824
Uniform object model for GraphSON response for client drivers
Based on the discussion here:
[](https://issues.apache.org/jira/browse/TINKERPOP-1909)
You can merge this pull request
[
https://issues.apache.org/jira/browse/TINKERPOP-1909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410530#comment-16410530
]
Ashwini Singh commented on TINKERPOP-1909:
--
Thanks for detail discussion. This is really
[
https://issues.apache.org/jira/browse/TINKERPOP-1909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410524#comment-16410524
]
ASF GitHub Bot commented on TINKERPOP-1909:
---
GitHub user ashwini-ms opened a pull request:
57 matches
Mail list logo
