GitHub user otaviojava opened a pull request:
https://github.com/apache/tinkerpop/pull/920
optmizes collection copy with Collections addAll
Copying of array contents to a collection where each element is added
individually using a for a loop. We can be replaced by a call to
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/914
---
Github user otaviojava commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/919#discussion_r211940616
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/util/DefaultTraversalMetrics.java
---
@@ -208,14 +208,14 @@
Github user otaviojava commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/919#discussion_r211950542
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/util/DefaultTraversalMetrics.java
---
@@ -208,14 +208,14 @@
Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/919#discussion_r211952645
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/util/DefaultTraversalMetrics.java
---
@@ -208,14 +208,14 @@
Github user otaviojava commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/919#discussion_r211956497
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/util/DefaultTraversalMetrics.java
---
@@ -286,10 +286,10 @@
Github user otaviojava commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/919#discussion_r211956428
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/util/DefaultTraversalMetrics.java
---
@@ -208,14 +208,14 @@
Github user otaviojava commented on the issue:
https://github.com/apache/tinkerpop/pull/919
@spmallette @robertdale When I changed the branch to tp32. When execute
this code:
`return new ASTTransformationCustomizer(InterpreterMode.class);` It returns
an NPE, I checked the code.
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/919
@otaviojava did you decompile the bytecode to make sure the compiler didn't
do that automagically? Otherwise, StringBuilder vars should be final.
---
Github user otaviojava commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/919#discussion_r211940698
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/util/DefaultTraversalMetrics.java
---
@@ -286,10 +286,10 @@
Github user otaviojava commented on the issue:
https://github.com/apache/tinkerpop/pull/919
@spmallette done.
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/919
thanks for the contribution @otaviojava - please edit the PR to target
tp32. we handle the rest of the merge flow to tp33 and master from there unless
there are really ugly merges or something
Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/919#discussion_r211948320
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/util/DefaultTraversalMetrics.java
---
@@ -208,14 +208,14 @@
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/919
@otaviojava was that locally? the travis build failed due to grapes
download.
---
Github user mattallenuk commented on the issue:
https://github.com/apache/tinkerpop/pull/889
@jorgebay I've rebased my TINKERPOP-1977 onto tp32 and made changes to the
documentation. Not sure I've done it right as I'm seeing lots of conflicts here
now lol!
Let me know if
[
https://issues.apache.org/jira/browse/TINKERPOP-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16588864#comment-16588864
]
ASF GitHub Bot commented on TINKERPOP-1977:
---
Github user mattallenuk commented on the
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/889
Note that it's pulling in commits from master now. Not sure how you got to
that point exactly, but I think you need to just rebase your commits in your
local repository on your branch.
[
https://issues.apache.org/jira/browse/TINKERPOP-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16588876#comment-16588876
]
ASF GitHub Bot commented on TINKERPOP-1977:
---
Github user spmallette commented on the issue:
Github user mattallenuk commented on the issue:
https://github.com/apache/tinkerpop/pull/889
@jorgebay I think I've got it now. Starting to see through the fog.
Hopefully that last push is the one :)
---
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/917
---
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/916
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/898
@daem0ndev do you have any thoughts on the recent comments made here?
---
GitHub user otaviojava opened a pull request:
https://github.com/apache/tinkerpop/pull/919
String loop to String builder
String concatenation in loops. As every String concatenation copies the
whole String, usually it is preferable to replace it with explicit calls to
Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/919#discussion_r211934275
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/util/DefaultTraversalMetrics.java
---
@@ -286,10 +286,10 @@
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/912
VOTE +1 - server integration tests are good - nice job with docs and
everything. thanks for doing this nerd work
---
Github user robertdale commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/919#discussion_r211934120
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/util/DefaultTraversalMetrics.java
---
@@ -208,14 +208,14 @@
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/889
Great contribution @mattallenuk!
We should merge it to `tp32`. @mattallenuk do you want to change the base
branch of this pull request and rebase? There shouldn't be any conflicts. We
Github user otaviojava commented on the issue:
https://github.com/apache/tinkerpop/pull/919
There are optimizations in Java 8 to String, however, it does not cover to
String in a loop. Yes, I checked also in the bytecode. After that, I put the
final var.
Thank you for the help.
[
https://issues.apache.org/jira/browse/TINKERPOP-2023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16588765#comment-16588765
]
ASF GitHub Bot commented on TINKERPOP-2023:
---
Github user spmallette commented on the issue:
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/889
I think the git branch is still based on`master` instead of `tp32`, that's
why github shows a lot of additional commits.
---
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/889
its not a problem :)
As long as you make sure you don't loose your commits on the process (make
sure you push a backup branch to your personal repository).
I think the issue is
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/889
awesome!
First, lets restore `tp32` on your repo:
```
git fetch upstream tp32
git checkout tp32
git reset --hard upstream/tp32
git push origin tp32
```
Github user mattallenuk commented on the issue:
https://github.com/apache/tinkerpop/pull/889
```
First, rewinding head to replay your work on top of it...
Generating patches: 100% (757/757), done.
Applying: valueMap should always return string keys
Using index info to
Github user mattallenuk commented on the issue:
https://github.com/apache/tinkerpop/pull/889
If i look at https://github.com/mattallenuk/tinkerpop/commits/tp32, it
appears to be what you were expecting? Have I done it the wrong way around?
---
Github user mattallenuk commented on the issue:
https://github.com/apache/tinkerpop/pull/889
origin https://github.com/mattallenuk/tinkerpop.git (fetch)
origin https://github.com/mattallenuk/tinkerpop.git (push)
upstreamhttps://github.com/apache/tinkerpop.git (fetch)
Github user mattallenuk commented on the issue:
https://github.com/apache/tinkerpop/pull/889
Ok, done that which way do I rebase? Tried
```
git checkout TINKERPOP-1977
git rebase origin/tp32
```
and getting some merges required with files I've not
[
https://issues.apache.org/jira/browse/TINKERPOP-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16588990#comment-16588990
]
ASF GitHub Bot commented on TINKERPOP-1977:
---
Github user mattallenuk commented on the
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/889
At this stage you have to use "rebase interactive" to manually select your
commits and skip the rest.
If you have a tool to do that, it would make your job a lot easier.
---
Github user mattallenuk commented on the issue:
https://github.com/apache/tinkerpop/pull/889
:( sorry
---
Github user mattallenuk commented on the issue:
https://github.com/apache/tinkerpop/pull/889
@spmallette thanks I think I've got it right now. Not a git expert, still
learning :)
---
[
https://issues.apache.org/jira/browse/TINKERPOP-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16588939#comment-16588939
]
ASF GitHub Bot commented on TINKERPOP-1977:
---
Github user spmallette commented on the issue:
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/919
Hmm.. it happens on tp32.
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/919
Nevermind, still just grapes.
---
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/919
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/914
VOTE +1
---
45 matches
Mail list logo
