[jira] [Commented] (TINKERPOP-1415) Vertex programs that rely on getting path parameters can't work

2016-08-25 Thread Bryn Cooke (JIRA)

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15436848#comment-15436848
 ] 

Bryn Cooke commented on TINKERPOP-1415:
---

Closed, but just want to throw in the idea that PathRetractionStrategy could 
pick up the specific variables that are required rather than globally disabling 
path retraction. 

> Vertex programs that rely on getting path parameters can't work
> ---
>
> Key: TINKERPOP-1415
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1415
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.2.1
>Reporter: Bryn Cooke
>
> Recently some of our vertex programs have started failing.
> They rely of being able to retrieve an element out of the path.
> However, whereas this used to work now the path element isn't there anymore.
> The root cause is that path retraction doesn't know that the vertex program 
> is interested in the path and therefore culls out parameter.
> I can understand why it does this, but there seems to be no way of exposing 
> the vertex program path requirements such that PathRetractionStrategy can 
> pick them up and do the right thing.
> I tried hacking together a solution by making ProgramVertexProgramStep 
> implement Scoping. This did fix the issue, but I am not confident that this 
> is the way to go.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (TINKERPOP-1415) Vertex programs that rely on getting path parameters can't work

2016-08-25 Thread Ted Wilmes (JIRA)

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15436838#comment-15436838
 ] 

Ted Wilmes commented on TINKERPOP-1415:
---

It's all coming back to me know, thanks [~okram].  [~bryncooke] in light of 
TINKERPOP-1280 and in the meantime, the availability of {{withPath}} would you 
be okay with closing this ticket out?

> Vertex programs that rely on getting path parameters can't work
> ---
>
> Key: TINKERPOP-1415
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1415
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.2.1
>Reporter: Bryn Cooke
>
> Recently some of our vertex programs have started failing.
> They rely of being able to retrieve an element out of the path.
> However, whereas this used to work now the path element isn't there anymore.
> The root cause is that path retraction doesn't know that the vertex program 
> is interested in the path and therefore culls out parameter.
> I can understand why it does this, but there seems to be no way of exposing 
> the vertex program path requirements such that PathRetractionStrategy can 
> pick them up and do the right thing.
> I tried hacking together a solution by making ProgramVertexProgramStep 
> implement Scoping. This did fix the issue, but I am not confident that this 
> is the way to go.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (TINKERPOP-1415) Vertex programs that rely on getting path parameters can't work

2016-08-25 Thread Marko A. Rodriguez (JIRA)

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15436734#comment-15436734
 ] 

Marko A. Rodriguez commented on TINKERPOP-1415:
---

There is a ticket of {{VertexProgram.getRequirements()}} however, in that 
ticket, we note that we are trying to get rid of the concept of 
{{TraversalRequirements}} !! :D... we were going to have 
{{g.withRequirements(...)}} that people could force, but then again, it 
"requirements." Lets see where the {{TraversalRequirements}} goes in 3.3.x and 
if it stays, then we add {{VertexProgram.getRequirements()}}.

> Vertex programs that rely on getting path parameters can't work
> ---
>
> Key: TINKERPOP-1415
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1415
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.2.1
>Reporter: Bryn Cooke
>
> Recently some of our vertex programs have started failing.
> They rely of being able to retrieve an element out of the path.
> However, whereas this used to work now the path element isn't there anymore.
> The root cause is that path retraction doesn't know that the vertex program 
> is interested in the path and therefore culls out parameter.
> I can understand why it does this, but there seems to be no way of exposing 
> the vertex program path requirements such that PathRetractionStrategy can 
> pick them up and do the right thing.
> I tried hacking together a solution by making ProgramVertexProgramStep 
> implement Scoping. This did fix the issue, but I am not confident that this 
> is the way to go.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (TINKERPOP-1415) Vertex programs that rely on getting path parameters can't work

2016-08-24 Thread Ted Wilmes (JIRA)

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15435078#comment-15435078
 ] 

Ted Wilmes commented on TINKERPOP-1415:
---

Hi Bryn, do things work if you use {{withPath}} by chance like: 
{{g.withPath().V().program(...)}}?

[~okram] do you think it would make sense to add a {{getRequirements}} to 
{{VertexProgram}} that would be bubbled up to the strategies via the 
{{ProgramVertexProgramStep}}?

> Vertex programs that rely on getting path parameters can't work
> ---
>
> Key: TINKERPOP-1415
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1415
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.2.1
>Reporter: Bryn Cooke
>
> Recently some of our vertex programs have started failing.
> They rely of being able to retrieve an element out of the path.
> However, whereas this used to work now the path element isn't there anymore.
> The root cause is that path retraction doesn't know that the vertex program 
> is interested in the path and therefore culls out parameter.
> I can understand why it does this, but there seems to be no way of exposing 
> the vertex program path requirements such that PathRetractionStrategy can 
> pick them up and do the right thing.
> I tried hacking together a solution by making ProgramVertexProgramStep 
> implement Scoping. This did fix the issue, but I am not confident that this 
> is the way to go.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (TINKERPOP-1415) Vertex programs that rely on getting path parameters can't work

2016-08-24 Thread Ted Wilmes (JIRA)

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15435076#comment-15435076
 ] 

Ted Wilmes commented on TINKERPOP-1415:
---

Hi Bryn, do things work if you use {{withPath}} by chance like: 
{{g.withPath().V().program(...)}}?

[~okram] do you think it would make sense to add a {{getRequirements}} to 
{{VertexProgram}} that would be bubbled up to the strategies via the 
{{ProgramVertexProgramStep}}?

> Vertex programs that rely on getting path parameters can't work
> ---
>
> Key: TINKERPOP-1415
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1415
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.2.1
>Reporter: Bryn Cooke
>
> Recently some of our vertex programs have started failing.
> They rely of being able to retrieve an element out of the path.
> However, whereas this used to work now the path element isn't there anymore.
> The root cause is that path retraction doesn't know that the vertex program 
> is interested in the path and therefore culls out parameter.
> I can understand why it does this, but there seems to be no way of exposing 
> the vertex program path requirements such that PathRetractionStrategy can 
> pick them up and do the right thing.
> I tried hacking together a solution by making ProgramVertexProgramStep 
> implement Scoping. This did fix the issue, but I am not confident that this 
> is the way to go.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)